fix: restore bin/ dir for release SBOM step#55
Merged
Merged
Conversation
.gitignore keeps bin/ present only via the un-ignored bin/README.md (`/bin/**` + `!/bin/README.md`). That file was deleted in the v4 squash, so a fresh checkout had no bin/ dir and the release workflow's "Generate CycloneDX SBOM" step (which writes bin/sbom.cyclonedx.json) failed with "cannot find the path specified", blocking the release job. Restore bin/README.md to keep the directory tracked, as before v4. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
monstercameron
pushed a commit
that referenced
this pull request
Jul 6, 2026
passphraseEncryptor memoized every salt->derived-key pair with no bound. Sealing reuses this instance's single salt, but decryption derives from each ciphertext's HEADER salt, so decrypting data sealed by many replicas (each with its own random salt) grew the cache — and retained a derived key (sensitive material) — one entry per distinct salt, without limit. Cap the memo at 128 entries with FIFO eviction; a later hit on an evicted salt simply re-runs PBKDF2. Pinned by TestDeriveKeyCacheIsBounded. Assessment of the rest of #55: localfirst presence already TTL-expires peers; the text CRDT's tombstone map growth is the standard CRDT tradeoff whose safe GC needs causal- stability tracking (an owner-level feature, not a contained fix). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores bin/README.md (deleted in the v4 squash) so the bin/ directory exists on a fresh checkout; the release workflow's CycloneDX SBOM step writes bin/sbom.cyclonedx.json and was failing without it.
🤖 Generated with Claude Code