test(ui): deepen effects parity (multiple effects, deps, ordering)#47
Merged
Conversation
Toward React equivalency for the hooks/effects suite: several effects in one component run in declaration order on mount; on re-render a dep-driven effect re-runs (cleanup then setup) only when its deps change, a static-deps effect does not re-run, and a no-deps effect re-runs every render; cleanups run on unmount in order. Verified via the native reconciler harness. All pass; no version bump. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
monstercameron
pushed a commit
that referenced
this pull request
Jul 6, 2026
GetEntry returned a struct copy sharing the SourceIDs backing array with the live entry, so a caller mutating/reading it could race SetRegionSourceIDs. Deep-copy SourceIDs under the RLock. Hot-path field getters left un-copied (deliberate perf path; writer replaces the slice). Pinned; runtime2 green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deepens effects: declaration-order on mount, dep-driven re-run, static-deps no-rerun, no-deps every-render, cleanup-on-unmount order. All pass; no version bump.
🤖 Generated with Claude Code