test(ui): deepen Children parity (count/flatten)#44
Merged
Conversation
Toward React-suite equivalency for the GWC-applicable ReactChildren subset (count/flatten/filter — GWC has html.Children normalization, not the Children.map/forEach/count API): count is 0 for nil/empty, 1 for a single arrayless or sliced child, N for flat and deeply (2-3 level) nested structures, nil is filtered, mixed kinds flatten; deep nesting flattens in document order. All pass; no version bump. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
monstercameron
pushed a commit
that referenced
this pull request
Jul 6, 2026
#44) The wasm backend now leads the console call with the message string when it is non-empty (console.log(message, record)) so the message is readable and matchable in devtools. But two test console stubs still captured parseArgs[0] as the structured "entry"/"payload" — now the MESSAGE STRING — so getLoggingTestRecord/findLoggingTestPayload called .Get("message") on a string and panicked ("Value.Get on non-object"), failing the whole logging wasm suite. Capture the LAST argument (always the record object) instead. The other #44 item (parallel-region wasm panic) is resolved: the ParallelRegion wasm tests pass (the specific failure was fixed under #40). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deepens the ReactChildren port: count/flatten/filter across many input shapes (nil/single/flat/nested/mixed), deep-flatten order. All pass; no version bump.
🤖 Generated with Claude Code