noscript support#11
Open
s3ththompson wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first pass at implementing noscript.
Unfortunately implementing this cleanly is more difficult than I thought. There seems to be no good way to hide the non-noscript element from a browser that is in noscript mode. This implementation sets the non-noscript element to
display:none;until client-side JS runs, but this seems less than ideal as it means image containers won't take shape until the JS bundle is executed.Let me know if you have any thoughts here...
EDIT: or perhaps hiding the non-noscript element should not work out of the box but instead require pasting a snippet of code into the head? lazysizes seems to suggest this, but it's not clear to me how the .no-js class gets added/removed.