[skia-sync] Merge upstream chrome/m151#274
Merged
Merged
Conversation
* Adds types and stubs for DrawAtlas refactor * Has NO functional impact * Adaptation of this patch https://skia-review.git.corp.google.com/c/skia/+/1181876 Change-Id: Ibd482f13875b77a485516a82d7a65a1d03df44df Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1254276 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Thomas Smith <thomsmit@google.com>
The submit proc is invoked with success=true if any tasks were executed and the submission of *those* tasks succeeded. Async reads also need to be gated on whether or not their actual task was executed. Bug: 517992755 Fixed: 517992755 Change-Id: I75b196111f03873c92b6d2f599a1055ce6a814cf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1257336 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
The GM displays 4 grids, under different types of transformation. Previously, Graphite only could apply an analytic rrect clip in the top left transformation case. In the follow-up CL, all transforms in this GM can be clipped with the same shader. Within each transformation grid, the 16 possible circular corner configurations are tested. Previously, only 0 corner, 1 corner, 4 corner, or 2 corner-on-the-same-side could be handled in the shader. In the follow-up CL, all corner combinations can be clipped. Change-Id: Id823e153d14d8dfcde160d7bc7f385b65ed13a6d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1256576 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
…usage" This reverts commit 6e003d7. Reason for revert: Disable CTS enforcement of the new unit test The other two Android-specific Precompile tests also are not CTS enforced. Original change's description: > Revert "Add public API to query a serialized key for external format usage" > > This reverts commit 8eb1070. > > Reason for revert: test failing on Cuttlefish in Skia->Android roll > > Original change's description: > > Add public API to query a serialized key for external format usage > > > > In order to allow serialized keys that contain external formats to be skipped over by precompilation we need some query. This is, perhaps, the simplest way to do this. > > > > We could also hide it somewhere and make it only available to Android. > > > > Bug: b/482036727 > > Bug: b/498213682 > > Change-Id: Ife5d4eaa31d39a5b304f7ecec02b77eeb03b400b > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1248236 > > Commit-Queue: Robert Phillips <robertphillips@google.com> > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > Bug: b/482036727 > Bug: b/498213682 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I56bb72ed369464710d898c029fdee6de781c0dc8 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1255237 > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> Bug: b/482036727 Bug: b/498213682 Change-Id: I6f54db3d10ba3e4d85db3f29fd0d1e70053b9a53 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1257396 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
This is a pure reland of: https://skia-review.googlesource.com/c/skia/+/1239656 The previous reland was reverted due to unexported symbols in the Windows component build. This, along with C++20 compatibility issues, has been fixed by the recent partition_alloc roll. Original change's description: > MiraclePtr: Add raw_ptr definitions > > Add "raw_ptr_noop" target, where Skia provides a "no-op" > implementation of PartitionAlloc of "raw_ptr". They are used when > PartitionAlloc is disabled. Bug: 351867706 Change-Id: Ica2ed04684fc21934c412084490981ef55982e1c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1257256 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Kaylee Lubick <kjlubick@google.com>
SDFTSubRun has a hard assumption of the kA8 mask format and if the vertex filler differs, there will be a memory mismatch. This catches it when deserializing the Slug and changes the debug-only assert to be runtime to make sure we don't miss other places. Bug: 520571816 Fixed: 520571816 Change-Id: I9ae3e509397e23d38d621cb7eb8bb5b955a43d7d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1257397 Commit-Queue: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Thomas Smith <thomsmit@google.com>
…contexts Before https://skia-review.git.corp.google.com/c/skia/+/1257336 landed, Ganesh was calling the async read callback with a successful result because the only time the protected state was checked was in the actual GrVkGpu::transferPixelsFrom() execution run by the task. This would skip the work and return false, but that did not propagate up to impact the success of the overall submit proc or finish proc. This allowed the expectations of the AsyncReadPixelsContextShutdown test to pass even when run on a protected context; it just saw unitialized buffers that it ignored. After the above CL, the execution status was visible to the AsyncReadPixelsContext and the user callback was invoked with a failure result. While this was the right thing, it caused the test's expectations to fail, so this changes the test to require the result if unprotected and require no result when protected. It does still confirm that the callback is invoked in either case. Bug: Bug: 517992755 Change-Id: I23888f7bb4249b398b56ca355fad791119e93884 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1257816 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Nicolette Prevost <nicolettep@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
There was an issue with fScratchGlyphRunBuilder that allowed a malicious drawTextBlob to use an SkCustomTypeface with a reentrant drawable that contains a drawTextBlob, which caused a UAF. The first drawTextBlob would start using fScratchGlyphRunBuilder, then the second drawTextBlob would clear and use fScratchGlyphRunBuilder before the first drawTextBlob would finish. To resolve this issue, an STArray of GlyphRunBuilders (fScratchGlyphRunBuilders) is used with 1 GlyphRunBuilder by default, with more allocated as needed. To verify the behavior is consistent and make the maintenance easier for the user, an RAII pattern was used (AutoGlyphRunBuilder). A benchmark was added to show the performance change on RSXform Glyph Runs within a text blob, and a test was added to verify the UAF bug was fixed. # Without Changes: alexisdavidc@alexisdavidc2:~/skia/skia (testingbefore)$ ninja -C out/Release/ && out/Release/nanobench --match GlyphRunRSXform ninja: Entering directory `out/Release/' ninja: no work to do. Timer overhead: 23.9ns curr/maxrss loops min median mean max stddev samples config bench 123/122 MB 1 29.2µs 29.8µs 29.7µs 30.1µs 1% █▅▁▃▆▇▄▇▄▅ 8888 GlyphRunRSXform_cached 147/140 MB 215 22.7µs 22.9µs 22.9µs 23.1µs 1% █▄▁▁▄▂▃▆█▃ gl GlyphRunRSXform_cached alexisdavidc@alexisdavidc2:~/skia/skia (testingbefore)$ ninja -C out/Release/ && out/Release/nanobench --match GlyphRunRSXform ninja: Entering directory `out/Release/' ninja: no work to do. Timer overhead: 23.8ns curr/maxrss loops min median mean max stddev samples config bench 123/121 MB 1 29.7µs 30µs 29.9µs 30.2µs 0% ▄█▃▃▁▅▆▅▄▅ 8888 GlyphRunRSXform_cached 147/139 MB 219 22.8µs 23.5µs 23.6µs 25.8µs 4% ▄█▁▄▆▁▁▃▁▁ gl GlyphRunRSXform_cached # With Changes: alexisdavidc@alexisdavidc2:~/skia/skia (security)$ ninja -C out/Release/ && out/Release/nanobench --match GlyphRunRSXform ninja: Entering directory `out/Release/' ninja: no work to do. Timer overhead: 23.8ns curr/maxrss loops min median mean max stddev samples config bench 123/119 MB 1 29.6µs 29.9µs 29.9µs 30.4µs 1% ▇▄█▁▃▄▃▁▆▂ 8888 GlyphRunRSXform_cached 147/138 MB 204 22.7µs 22.9µs 23.4µs 24.9µs 4% ▁█▂▁██▂▂▁▂ gl GlyphRunRSXform_cached alexisdavidc@alexisdavidc2:~/skia/skia (security)$ ninja -C out/Release/ && out/Release/nanobench --match GlyphRunRSXform ninja: Entering directory `out/Release/' ninja: no work to do. Timer overhead: 23.8ns curr/maxrss loops min median mean max stddev samples config bench 123/116 MB 1 29.3µs 29.7µs 29.7µs 30.3µs 1% ▄█▄▂▃▂▃▁▃▄ 8888 GlyphRunRSXform_cached 147/134 MB 221 22.5µs 22.7µs 22.7µs 22.9µs 0% ▃▂▄█▄▄▄▁▂▃ gl GlyphRunRSXform_cached Bug: b/513820666 Change-Id: If8e5e9a3dc0f656eb1fc6b03ae79fdf39e67328e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1248477 Commit-Queue: Alexis Cruz-Ayala <alexisdavidc@google.com> Reviewed-by: Kaylee Lubick <kjlubick@google.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/537ea5cb1a35..2f96412cd516 Also rolling transitive DEPS: https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/f3f1169512c713d979a7aa1bc0c6c0fd89f0a85f..199cb207b911501ddd76dcddf100a6e21c15ef23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC kjlubick@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: kjlubick@google.com Change-Id: I80cae562f230f8576a3e9c50c737d9b2ba7d6904 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1258036 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/debugger-app-base-skia Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: borenet@google.com Change-Id: I88a3c1b59b18a734120e2c7d1fc46adf399a2636 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1257440 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/jsfiddle-base-skia Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: borenet@google.com Change-Id: I191b1a15393cddba4ca0bd0bf0c2a6942f5cca3f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1258196 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://swiftshader.googlesource.com/SwiftShader.git/+log/d26a3e6606c0..5b0479bd2d15 2026-06-08 dsinclair@google.com Revert "Default to use llvm16" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-skia-autoroll Please CC bsalomon@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Test-Ubuntu24.04-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader Bug: None Tbr: kjlubick@google.com Change-Id: Ic3d11d2bcce7c7b78bded6be6d728258643acde5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1258156 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://dawn.googlesource.com/dawn.git/+log/58263faefe3c..841e08144fb8 2026-06-09 dawn-autoroll@skia-public.iam.gserviceaccount.com Manual roll SwiftShader from 9898204d91d6 to 5b0479bd2d15 (6 revisions) 2026-06-09 rharrison@chromium.org Roll third_party/protobuf/ 96835044c..a2f1387bf (3 commits) 2026-06-09 nathan.teodosio@canonical.com CIPD: Add aarch64 string to detect native ARM. 2026-06-08 lokokung@google.com [platform] Fix the number of jobs in thread pool tracking. 2026-06-08 alanbaker@google.com [vulkan] Set varying subgroup size for fragment shaders 2026-06-08 tikuta@google.com generator: Fix missing inputs for dawn_gpu_info_gen 2026-06-08 jrprice@google.com [msl] Add workaround for u32 div/mod miscompile 2026-06-08 swarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com [owners] Remove petermcneeley@google.com from src/tint/OWNERS 2026-06-08 alanbaker@google.com [tint] Cleanup def files 2026-06-08 cwallez@chromium.org [dawn][frontend] Fix IsRangeOverlapped early out. 2026-06-08 lehoangquyen@chromium.org Add Platform::ReportProgress to prevent watchdog timeout 2026-06-08 kainino@chromium.org Refresh CONTRIBUTING.md 2026-06-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 169387bb6e56 to 537ea5cb1a35 (20 revisions) 2026-06-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1184faa057e3 to 39f691795d05 (15 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC cwallez@google.com,dsinclair@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac14-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: None Tbr: dsinclair@google.com Change-Id: I8b599e7f6bb0bd2d29f734a57fdcf66423a90bf9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1258176 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/angle/angle.git/+log/dc32cd831434..7f76f214a5a4 2026-06-09 cclao@google.com Add ImageTest.AHBUpdatedExternalTextureWithSharedContext test 2026-06-09 syoussefi@chromium.org Add native platform type to display map key 2026-06-09 cclao@google.com Vulkan: Force submit staged update for textures created from EGLImage 2026-06-09 lexa.knyazev@gmail.com Use packed enums for PixelStore params 2026-06-09 wangra@google.com D3D11: Fix resource type mismatch in Image11 copy 2026-06-08 syoussefi@chromium.org Skip timeout-y test 2026-06-08 syoussefi@chromium.org Skip failing X11 test blocking CQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC jmadill@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win11-Clang-Dell3930-GPU-GTX1660-x86_64-Debug-All-ANGLE Tbr: kjlubick@google.com Test: Test: angle_end2end_tests --gtest_filter="*CopyTexSubImage3DTarget3DSource2DMatches*" Change-Id: I6affb7f8fe2a16e854401fd5dda84e460ab8371f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1257439 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Add a getWidthsStrided() API to SkStrikeRef which allows scattered memory access into input glyph list and provides scattered writes with a stride length into a client provided output buffer. Useful for fast access and transfer of advance widths, for example in text shaping. Shown to improve Blink performance: 1. Speedometer 0.2% win on Linux-perf https://pinpoint-dot-chromeperf.appspot.com/job/172b3a63490000 2. 3.8% improvement in blink_perf.CJK-article.hml https://pinpoint-dot-chromeperf.appspot.com/job/1035a28b490000 Bug: 518697702 Change-Id: I0f0a94e7dd0d572603e6fc2dcd02d6f21044f10c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1252496 Reviewed-by: Dominik Röttsches <drott@google.com> Commit-Queue: Dominik Röttsches <drott@google.com> Reviewed-by: Florin Malita <fmalita@google.com>
It's currently failing with a Go version mismatch between the toolchain we're sending and one downloaded by Dawn. We don't need our own Go version for anything, so this CL just stops sending it to the task and allows use of the one downloaded via DEPS. Change-Id: I018d2b26017cf88eec4a5a4cb57aa5f8a8a39948 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1253416 Auto-Submit: Eric Boren <borenet@google.com> Commit-Queue: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Kaylee Lubick <kjlubick@google.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/2f96412cd516..e97d808085af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC kjlubick@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: kjlubick@google.com Change-Id: I285880649dd21e98307336cbffd6e963590053e7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1258916 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://skia.googlesource.com/buildbot.git/+log/aa3b5a254aa6..5feb27468419 2026-06-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll command_wrapper from 3ebf8aabbb6eb28de... to 927dee2590500c16f... (1 revision) 2026-06-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-final from 4144e0c23545 to a9cfd21a697d 2026-06-05 borenet@google.com [autogardener] Speculative fixes for tasks which generated no logs 2026-06-05 nscobie@google.com [autoroll] Allow Android rollers with CQ perms to always accept PV+1 2026-06-05 wenbinzhang@google.com [perf] Fix triage ignore toast visibility in explore-multi-v2-sk 2026-06-05 zhanliang@google.com [CBB] Add jetstream3 to CBB trigger script 2026-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-final from a21b63d2cd57 to 4144e0c23545 2026-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Depot Tools from cefcb89275e0 to 533321c34e1c (1 revision) 2026-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll command_wrapper from 238fb9930009a5600... to 3ebf8aabbb6eb28de... (1 revision) 2026-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-final from 3cde3026d499 to 9e9f7d5d4b58 2026-06-04 zhanliang@google.com [CBB] Update script to manual trigger a CBB run 2026-06-04 borenet@google.com [structuredlogging] Fix missing error message for skerr.ErrorWithContext 2026-06-04 borenet@google.com [autoroll] Force use of /a/ endpoints for gitiles 2026-06-04 brettos@google.com [Ansible] Updated "stdout_callback" to use superseded option 2026-06-04 brettos@google.com [Ansible] Migrating from gsutil to gcloud for linux_package_src task 2026-06-04 brettos@google.com [Ansible][eSkia] Increase number of skia-i-eskia* hostnames from 4 to 8 2026-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-final from 6ab7ca4f56b2 to 3cde3026d499 2026-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-final from d8211dc3f781 to a21b63d2cd57 2026-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll luci-auth from 7257396558bc9c7c7... to ec87456d811bea90f... (1 revision) 2026-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll command_wrapper from b7cfb7071e556e297... to 238fb9930009a5600... (1 revision) 2026-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Depot Tools from ea198736a0bc to cefcb89275e0 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:519472989 Tbr: borenet@google.com Change-Id: I0373139475eee8c50ac60ce6362ec42a5364c496 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1256896 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Kaylee Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
The shader logic is updated to have a 2x2 transform applied to the fragment coordinate that sk_analytic_clip is invoked with. This is sufficient to support all affine transformations so long as any decomposed translation is pre-applied on the CPU (handled in ClipStack). This same transformation (device-to-clip local space) describes the Jacobian we need to apply in order to get the device-space coverage value from distance equations. I experimented with using dFdx, or fwidth and the quality was low on my M3 and in this case, it really doesn't add much overhead at all. The shader computes both circular distance for the quarter circles and the edge distance, mixing them together when a pixel is outside of the quarter circle zone. Previously we would clamp the pixel's coordinate to the quarter circle, but with the derivative calculations it relied on a lot of infinity * near-zero values doing the right thing in a saturate() call later on and that made me nervous. Lastly, the shader logic has an updated way of encoding intersect vs. difference so that we can avoid branching. --- On the CPU side, there was extensive simplification. Other than extracting the 2x2 transform and detecting circular radii, the rrect geometry can effectively be sent directly to the GPU. What little adjustment logic there is on top of that is now handled in KeyHelpers instead of being part of PaintParams. I also opted to remove the NonMSAAClipData in favor of just passing the original NonMSAAClip struct to KeyHelpers. --- In terms of support, assuming there's no perspective, the clip's transform will not prevent Graphite from using an analytic shader clip. The rrects themselves now include anything that passes AllCornersRelativelyCircular() in its original coordinate space, OR if they were mapped to a circular rrect in device space, OR we can apply an additional Y axis scale to the clip's local space to coerce the elliptical corners to all be circular. --- In terms of performance, I tested a couple of scenarios with GPU captures: 1. clip_rrects_analytic w/ cases removed so pre-CL was also always able to use an analytic clip: an increase in 46 instructions, regressed from 307us up to 316us on my M3. 2. clip_rrects_analytic w/ all corner cases but no tough transforms: net frame time was identical, although no MSAA is triggered anymore. 3. clip_rrects_analytic w/ all cases and tough transforms: improved from 292us down to 278us, and did not trigger MSAA anymore. 4. RE rotated PiP SKP from Noelle -> 550us down to 548us and no more MSAA. It would not surprise me that on lower end devices if the regression for the hyper-simple case was more pronounced than the small regression I measured in #1. However, I would also expect that on those same devices, the avoidance of MSAA in more complicated cases is a worthwhile tradeoff. Avoiding having an axis-aligned variant and a full transform variant should also mean that the precompile cases in RE that currently capture analytic clips when axis-aligned will apply to their rotated gesture cases. This also means that we should no longer be triggering MSAA ever and could remove all MSAA RP cases from precompile. Bug: 521797619 Bug: 498213682 Bug: 514566920 Change-Id: I9c87e0b54204c18aed615319b352f6bde9bf8b44 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1257357 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Chromium has something in autoninja to automatically add in --quiet for ninja and that seemed like a good idea to tell the agents about to reduce token usage and context size. Change-Id: I5e3c42b7faef60ff0b2b5f1bb4432b923b0960ae No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1259536 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com> Auto-Submit: Kaylee Lubick <kjlubick@google.com>
Before this change, SkImage and SkSurface were asked to track their own metadata for capture (fDerivedSurfaceID, fContentID, etc.) This gets messy and required a lot of syncing across different Skia objects. Moving to a model that images and surfaces point to the same object that tracks this information simplifies the memory and state identification model. Change-Id: I1f2b1227ad2a09eb5de87a83f090e013c295a3d7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1238456 Commit-Queue: Jorge Betancourt <jmbetancourt@google.com> Reviewed-by: Alexis Cruz-Ayala <alexisdavidc@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (depot_tools) into this repository. The build that created this CL was https://ci.chromium.org/b/8679422120601799041 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/2eed415f7526676d124ba74da6807a26d2227f4c 2eed415 (rop@google.com) [metadata] Update license validation warning to point to docume... Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I0f9ae6bcacc64be0f030dd6b08ec447d6affbadb Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1259736 Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/e97d808085af..f253d7659dd3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC kjlubick@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: kjlubick@google.com Change-Id: Ia206734353241fc9a826a50582143643485c00ea Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1258991 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/jsfiddle-base-skia Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: borenet@google.com Change-Id: I078db69c096441673876d1927db0c49b99bf29ae Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1259916 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://dawn.googlesource.com/dawn.git/+log/841e08144fb8..926483c39198 2026-06-10 dsinclair@chromium.org [validator] Move user call functional checks. 2026-06-10 dsinclair@chromium.org [validator] Move convert functional checks. 2026-06-10 dsinclair@chromium.org [validator] Move member builtin call functional checks. 2026-06-10 dsinclair@chromium.org [validator] Move builtin call functional checks. 2026-06-10 dsinclair@chromium.org [validator] Move unary functional checks. 2026-06-10 lokokung@google.com [build] Enable cross compilation for Mac on Linux host. 2026-06-10 jiawei.shao@intel.com [Vulkan] Check if mResourceMemoryAllocator is null in Device::DestroyImpl() 2026-06-09 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll GLFW from b00e6a8a88ad to 567b1ec2442d (3 revisions) 2026-06-09 dsinclair@chromium.org [spirv-reader] Handle transposed square matrices. 2026-06-09 dsinclair@chromium.org [validator] Move swizzle functional checks. 2026-06-09 dsinclair@chromium.org [validator] Move switch functional checks. 2026-06-09 jrprice@google.com [tint] Print configs in all fuzzers 2026-06-09 rharrison@chromium.org [fuzz] Suppress specific UBSAN warning for libFuzzer itself 2026-06-09 dsinclair@chromium.org [validator] Move store functional checks. 2026-06-09 dsinclair@chromium.org [validator] Move loop functional checks. 2026-06-09 sarath.singapati@huawei.com vulkan: Disable shader-f16 on Huawei Maleoon GPUs 2026-06-09 dawn-autoroll@skia-public.iam.gserviceaccount.com Manual roll Chromium from 66ce96771f9d to 91300ae47c89 (364 revisions) 2026-06-09 dsinclair@chromium.org [validator] Move load/store vector element functional checks. 2026-06-09 dsinclair@chromium.org [validator] Move load functional checks. 2026-06-09 dsinclair@chromium.org [validator] Move if functional checks. 2026-06-09 dsinclair@chromium.org [validator] Move binary functional checks. 2026-06-09 bajones@chromium.org Fix OOB read when validating repeated bundles 2026-06-09 dsinclair@chromium.org Roll Chromium from e22e82d4f48c to 66ce96771f9d (4531 revisions) 2026-06-09 tikuta@google.com Fix missing inputs and absolute paths in generator_lib 2026-06-09 rharrison@chromium.org [fuzz] Make sure that `--dump-ir` works with WGSL fuzzers 2026-06-09 dsinclair@chromium.org [validator] Move access functional checks. 2026-06-09 dsinclair@chromium.org [validator] Move construct functional checks. 2026-06-09 dsinclair@chromium.org [validator] Move let functional checks. 2026-06-09 dsinclair@chromium.org [validator] Move initial var functional checks. 2026-06-09 dsinclair@chromium.org [validator] Move override functional checks. 2026-06-09 dsinclair@chromium.org [validator] Move current validation into structural 2026-06-09 dsinclair@chromium.org [validator] Create split validator files 2026-06-09 dsinclair@chromium.org Reland "Fix location selection for pixel center polyfill." 2026-06-09 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 537ea5cb1a35 to 1e06e96ec17d (10 revisions) 2026-06-09 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from 8ed708842c1c to d6e0ca4a0c25 (1 revision) 2026-06-09 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 39f691795d05 to 30d7a564a750 (7 revisions) 2026-06-09 kainino@chromium.org Tidy wasm/node build config, add development tips docs 2026-06-09 jrprice@google.com [tint] Add PrintReflected() helper 2026-06-09 kjlubick@google.com Add missing header to CMakeLists 2026-06-09 arthursonzogni@chromium.org feat: Add extensible CheckBannedPatterns check Also rolling transitive DEPS: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/d16e32215c3ab90ba57c2e904a5344d85c7353e4..d08063d672d7693c1844d682848bcfec237f833e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC cwallez@google.com,dsinclair@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac14-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: None Tbr: dsinclair@google.com Change-Id: Ib2676740b25248ad23271b0183359a11ac750ca4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1259876 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/debugger-app-base-skia Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: borenet@google.com Change-Id: Icd70808c1aa7d25715bc5b4104ad0ddf23086ba2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1259836 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://skia.googlesource.com/buildbot.git/+log/5feb27468419..9aaa7e56e7b8 2026-06-09 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - off - perf/FREEZELOCK 2026-06-09 jeffyoon@google.com Revert "[perf/androidx] update url for a2.json instnace url to androidx" 2026-06-09 eduardoyap@google.com Fix V1 crash on transition 2026-06-09 zhanliang@google.com [CBB] Set readable workflow ID for single_commit_runner 2026-06-09 sruslan@google.com Style links within trace chart tooltips. 2026-06-09 sergeirudenkov@google.com omit CI checks for FREEZE toggler, fix paragraph 2026-06-09 sruslan@google.com Migrate tricon2-sk to LitElement. 2026-06-09 sruslan@google.com Migrate revision-info-sk to LitElement. 2026-06-09 sruslan@google.com Migrate word-cloud-sk to LitElement. 2026-06-09 sruslan@google.com Migrate query-chooser-sk to LitElement. 2026-06-09 sruslan@google.com Refactor perf-scaffold-sk to use LitElement. 2026-06-09 mordeckimarcin@google.com [Perf] enable revision info menu link on ng instances 2026-06-09 sergeirudenkov@google.com omit CI checks for FREEZE toggler 2026-06-09 sergeirudenkov@google.com add chrome_public_autopush looking at internal db 2026-06-09 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - on - perf/FREEZELOCK 2026-06-09 ansid@google.com Fix buganizer link 2026-06-09 ansid@google.com Apply saas migration for generated files 2026-06-09 ansid@google.com Apply sass-migrator: elements-sk/modules 2026-06-09 mordeckimarcin@google.com [Perf] autobisect - change status handling schema 2026-06-09 ansid@google.com Start using per-instance sheriff configs 2026-06-09 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - off - perf/FREEZELOCK 2026-06-09 sruslan@google.com Refactor Wasm API and suggestion engine. 2026-06-09 sergeirudenkov@google.com perf: authenticate Gitiles client in startVisibilityChecker 2026-06-09 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - on - perf/FREEZELOCK 2026-06-09 sruslan@google.com Migrate extra-links-sk to LitElement. 2026-06-09 sruslan@google.com Migrate favorites-sk to LitElement and use @lit/task for data fetching. 2026-06-09 sruslan@google.com Refactor commit-detail-picker-sk to use LitElement and @lit/task. 2026-06-09 maximsheshukov@google.com Store job list table setting in the local storage 2026-06-09 maximsheshukov@google.com Support column reordering in the job table 2026-06-09 maximsheshukov@google.com Use fakeAsync plus tick() 2026-06-09 ansid@google.com Apply sass-migrator: perf/modules 2026-06-09 sergeirudenkov@google.com perf spanner migrations SKILL.md 2026-06-09 maximsheshukov@google.com Make the new job page creating Pinpoint jobs 2026-06-09 maximsheshukov@google.com Create a new job page 2026-06-09 maximsheshukov@google.com Make job table headers sortable 2026-06-09 maximsheshukov@google.com Add a toggle between all jobs and user jobs 2026-06-09 maximsheshukov@google.com Add a selector for visible columns 2026-06-09 maximsheshukov@google.com Add "Bug" column to the list job table 2026-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-final from 8c25a6a341f6 to 0e799f10b1b8 2026-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll command_wrapper from 927dee2590500c16f... to 5feb2746841970344... (1 revision) 2026-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-final from a9cfd21a697d to d9e72b3a6381 2026-06-08 eduardoyap@google.com [Multi V2] report page: selected anomalies should be highlighted on the graphs 2026-06-08 sergeirudenkov@google.com [perf] Initialize demo DB using versioned migrations 2026-06-08 jeffyoon@google.com [perf/androidx] update url for a2.json instnace url to androidx 2026-06-08 wenbinzhang@google.com [perf] Add Bug ID display to V2 chart tooltip 2026-06-08 ansid@google.com Protect template access with a mutex and improve DevMode error handling. 2026-06-08 ansid@google.com Fix sid on local runs 2026-06-08 sergeirudenkov@google.com [perf] Fix Spanner Emulator migration DDL errors and make test assertions dynamic 2026-06-08 ansid@google.com Switch TypeScript transpiler from tsc to swc. 2026-06-08 ansid@google.com Anomaly table UI improvements 2 2026-06-08 mordeckimarcin@google.com [Perf] E2E smoke test script for autobisection 2026-06-08 ansid@google.com Add graph button for anomaly groups 2026-06-08 sergeirudenkov@google.com [public's a subset] chrome autopush switch 2026-06-08 sergeirudenkov@google.com [perf] database schema version in UI 2026-06-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-final from 9e9f7d5d4b58 to 8c25a6a341f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:504536191,chromium:513167043,chromium:517536293,chromium:517538256,chromium:517541431,chromium:519483919 Tbr: borenet@google.com Change-Id: I894e83f15db0f4c9c0a2b0eb6f26e1026c726aba Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1259738 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/angle/angle.git/+log/7f76f214a5a4..0c063596e689 2026-06-10 syoussefi@chromium.org Fix test display creation on wayland 2026-06-09 timvp@google.com Intel+Win: Skip flaky UniformBufferTest[31] / UniformTestES31 2026-06-09 bsheedy@chromium.org Add src-side Win/MSVC builders 2026-06-09 syoussefi@chromium.org Vulkan: Test large IMAGE_HEIGHT vs texture image ghosting 2026-06-09 bsheedy@chromium.org Share builder dimensions 2026-06-09 bsheedy@chromium.org Remove legacy Linux/x64/rel test specs 2026-06-09 wangra@google.com D3D11: Fix Use-After-Free in TextureStorage11 onDestroy 2026-06-09 wangra@google.com D3D11: Fix OOB write in D3D11 baseInstance drawing 2026-06-09 sergiosolano@google.com Support std::array in ArraySize helper 2026-06-09 lexa.knyazev@gmail.com Move CompileShader validation out of Context 2026-06-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 169387bb6e56 to bbd56e4662f7 (31 revisions) 2026-06-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from d26a3e6606c0 to 5b0479bd2d15 (1 revision) 2026-06-09 lexa.knyazev@gmail.com Remove no-op validation functions 2026-06-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 5241a9bb4839 to 20b3fbfbc185 (20 revisions) 2026-06-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2b631f486ca2 to bc7f0ab2de53 (1572 revisions) 2026-06-09 arthursonzogni@chromium.org Angle: enable PartitionAlloc shim. 2026-06-09 zork@google.com Fix parallel-link race in GL_KHR_no_error context If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC jmadill@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win11-Clang-Dell3930-GPU-GTX1660-x86_64-Debug-All-ANGLE Tbr: kjlubick@google.com Test: Test: None Test: Test: angle_end2end_tests --gtest_filter="*DivisorDoesNotDivideBaseInstance*" Test: Test: angle_end2end_tests --gtest_filter=ContextNoErrorTest.ParallelLinkRelinkRace Change-Id: I609258903fd4a6f1b33cf8a0b1050f83d581aba4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1259936 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
For the interior point case, the x value must be strictly different from BOTH surrounding points. Bug: b/395659818 Change-Id: I5f24d97123644b11ddffa802fd7788274422d667 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1251296 Commit-Queue: Maryla Ustarroz-Calonge <maryla@google.com> Reviewed-by: Christopher Cameron <ccameron@google.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/f253d7659dd3..1ebd280d7a28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC kjlubick@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: kjlubick@google.com Change-Id: Ie022304b02e3da84f5905387b23e7d2966b8087a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1260856 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/f2b9fece7c67..421bfddfc5bd Also rolling transitive DEPS: https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/7db050bf022d203df651f8daa3e4542fdc2a8aea..f25a3b067eed21f6ce43186942eec3c407cade02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC michaelludwig@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: michaelludwig@google.com Change-Id: I97a7d5ee9ab8500cd0172013522cc924db077d5c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1279744 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Manual roll requested by robertphillips@google.com https://dawn.googlesource.com/dawn.git/+log/b295347f18d1..5f4709f1a2c7 2026-06-26 kainino@chromium.org [utils] Test ASSERT/ASSUME side effects, apply -Wno-assume globally 2026-06-26 shrekshao@google.com Add back -Wno-nonportable-system-include-path 2026-06-26 chouinard@google.com Add LiteRT-LM DEP and build scripts 2026-06-26 jrprice@google.com Disable -Wnonportable-system-include-path for windows.h 2026-06-26 cwallez@chromium.org [utils] Add [Byte]SpanFromRef and SpanAs[Writable]Bytes 2026-06-26 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll GLFW from 567b1ec2442d to ed6452b13c76 (5 revisions) 2026-06-26 jrprice@google.com Revert "Add raw_ptr tests and fix no-op implementation" 2026-06-26 arthursonzogni@chromium.org Demote DAWN_UNSAFE_BUFFERS safety comment check to warning 2026-06-26 arthursonzogni@chromium.org Add raw_ptr tests and fix no-op implementation 2026-06-26 chouinard@google.com Update gitmodules 2026-06-26 cwallez@chromium.org [utils] Mark dawn::Span satisfying ranges::view/borrowed_range 2026-06-26 jrprice@google.com [github] Enable TINT_ENABLE_INSTALL on CI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC cwallez@google.com,jrprice@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac14-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: None Tbr: jrprice@google.com,robertphillips@google.com Change-Id: I676736bad47c3f033e44bc79b2dfaeb9d33b0586 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1279879 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (depot_tools) into this repository. The build that created this CL was https://ci.chromium.org/b/8677888891087543313 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/1e85b18d8037bca45f9a9891ae9325729f3ebcd4 1e85b18 (nerima@google.com) git_cache: scale bootstrap download concurrency with the machine Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I9f57544cb8884d585b651dd46c849f8571aaddb3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1279964 Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
- Update `getSampler` to allow sampling for non-interlaced images, I’ll implement interlaced images in the next CL and leave APNG unsupported - Update `fDstRowSize` in `incrementalDecodeXForm` because the `swizzleWidth` is only initialized later - Update `canReadRow` to avoid decoding directly when sampling - Only process the rows that need to be processed when sampling (`rowNeeded` and stopping after reaching the sampled dimension) - Added diff tests with the libpng impl for comparison BUG=378697848 Change-Id: Id1b568066d6f381ee246de570de0677d21ffbe3e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1279296 Reviewed-by: Łukasz Anforowicz <lukasza@google.com> Commit-Queue: Elliot Sisteron <elliotsisteron@google.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/421bfddfc5bd..dee190b82ff3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC michaelludwig@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: michaelludwig@google.com Change-Id: Ide2c8ac8488c70002d5ecbc52bcf39c711a38b6d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1280060 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/dee190b82ff3..e44f14c91d6d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC michaelludwig@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: michaelludwig@google.com Change-Id: I76c0da816ab71695d79b33166f0cd8d1665894e5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1280176 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skp-skia Please CC maxhudnell@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SKP CIPD package: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: maxhudnell@google.com Change-Id: I164df2e300e3ad0caad9affc8027565728722f41 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1280256 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/e44f14c91d6d..782a48bf2db0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC maxhudnell@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: maxhudnell@google.com Change-Id: I58d53baac22370054cda2095d0737bbcd1a2214d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1280396 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (depot_tools) into this repository. The build that created this CL was https://ci.chromium.org/b/8677701407953142881 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/c8f585f8380a43c70fa5682b1a9ae4f84abf820f c8f585f (ovsienko@google.com) vpython: push newest version of vpython to depot_tools. Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I09df6ae962b336b7b4de96727f2135047ce02e7f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1280496 Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://dawn.googlesource.com/dawn.git/+log/5f4709f1a2c7..7807dcbdca24 2026-06-28 chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com Remove stale WebGPU CTS expectations 2026-06-28 chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com Remove stale WebGPU Compat CTS expectations 2026-06-27 cwallez@chromium.org [dawn][native] Spanify RenderPassEncoder::ExecuteBundles 2026-06-27 cwallez@chromium.org [dawn][native] Spanify AdapterPropertiesMemoryHeaps/SubgroupMatrixConfigs 2026-06-27 kainino@chromium.org [cmake] Fix DAWN_SUPPORTS_GLFW_FOR_WINDOWING variable to match GN 2026-06-26 kainino@chromium.org Revert "[utils] Test ASSERT/ASSUME side effects, apply -Wno-assume globally" 2026-06-26 kainino@chromium.org [github] Send an alert on 'release' action failure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC cwallez@google.com,jrprice@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac14-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: None Tbr: jrprice@google.com Change-Id: Ib02c4dd58feebb1a8aae2f0158ae624e1eec088a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1280596 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://skia.googlesource.com/buildbot.git/+log/51dfbce05960..c0e4e8a0a6bd 2026-06-26 zhanliang@google.com [CBB] Fix some CBB result links 2026-06-26 mordeckimarcin@google.com [Perf dryrun] Fix progress messages and others 2026-06-26 sruslan@google.com Apply default parameter selections to V2 dashboard queries. 2026-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-final from 652584df4ec6 to d541f52540e5 2026-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll command_wrapper from 5b7ad37722bb8000a... to e92314cc0e96e4166... (1 revision) 2026-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Depot Tools from 1773156872f4 to 0b07c9299381 (2 revisions) 2026-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-final from faff0347f130 to fb8c6d6c373a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:522200527 Tbr: borenet@google.com Change-Id: I316e3b89bab0156cfaafc8baf0023d7fb1778d77 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1280599 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/782a48bf2db0..0af4fee9206d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC maxhudnell@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: maxhudnell@google.com Change-Id: I31e28a6dbe1b654c98cfb93805a2ba0c964089ed Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1280617 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/angle/angle.git/+log/6e65aeaa7006..98dab44d9cd2 2026-06-28 cclao@google.com Vulkan: Add initializeColorAttachmentWithWhite for app workaround 2026-06-28 lexa.knyazev@gmail.com Use standard enums for 64-bit types 2026-06-27 zychen2828@gmail.com IR Validation: add pointer validation for operands and results 2026-06-26 abdolrashidi@google.com Vulkan: Fix layer index/count for update from FBO 2026-06-26 kbr@chromium.org Increase size of buffer pool for argument buffers. 2026-06-26 merckhung@google.com Consolidate common arch flags If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC jmadill@google.com,maxhudnell@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win11-Clang-Dell3930-GPU-GTX1660-x86_64-Debug-All-ANGLE Tbr: maxhudnell@google.com Test: Test: Verified ANGLE compiles on x86_64 and arm64; verified Change-Id: If3b3ae93d610c678bab0195e386a4a89699bf9fe Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1280616 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (depot_tools) into this repository. The build that created this CL was https://ci.chromium.org/b/8677682533304137105 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/c8e2adf799bf514bce55b7c083ec84fd6f30cd0e c8e2adf (ovsienko@google.com) [cipd] Cache cipd_bin_setup to reduce tool latency Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I6726390eee2cb5f4d5d16220045de8999a9883b1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1280696 Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (depot_tools) into this repository. The build that created this CL was https://ci.chromium.org/b/8677677499416683857 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/cd4ad4bdbfe3c63e123909d7bcfd1918acbd8209 cd4ad4b (ovsienko@google.com) Revert "vpython: push newest version of vpython to depot_tools." Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I203e63dc467548d85347a3b0e373a541b4f27a00 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1280736 Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (depot_tools) into this repository. The build that created this CL was https://ci.chromium.org/b/8677673726287284337 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/932167e4f1e7afa8d19c2951d020dfb099507a30 932167e (ovsienko@google.com) vpython: push new version of vpython including fix for proxy pr... Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: Ic1985ea5d29e34de49feb90efd7332b98f718797 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1280698 Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Flaky crash on Test-Ubuntu24.04-Clang-NUC11TZi5-GPU-IntelIrisXe-x86_64-Release-All-DDL3_TSAN_Vulkan Change-Id: I55adc2d737238f7a82cc8bff04827d914246cdba Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1280976 Commit-Queue: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Refactors DrawAtlas::Plot to store allocated items using the new EntryID to Rect16 hashmap, instead of directly mutating a single passed AtlasLocator. * Internal cleanup DrawAtlas::Plot: positional (location of the plot within the atlas, and page) is separated from data (size of the rect, mask format). * Notably the generation counter is removed from Plot, and instead the AtlasLocator now holds a Record (PlotID + EntryID). * In order to process evictions without the generation counter,Plot::genID() is polyfilled to simply return its fPlotID, so when a plot is recycled, the new fPlotID also is a new genID. * Adaptation of this patch https://skia-review.git.corp.google.com/c/skia/+/1181876 Change-Id: Id04ac3503f7b41909af3c16693ef38db70d51cb4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1254877 Commit-Queue: Thomas Smith <thomsmit@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
* Adds the simd version of the sparse strips CPU coverage generation Bug: b/466122293 Bug: b/466119734 Bug: b/385170952 Change-Id: I97d96f1fb0ef447d1d71d449a19c85515d473cc3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1165677 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Thomas Smith <thomsmit@google.com>
* If only a portion of the stencil attachment is cleared, we should not mark the entire attachment as cleared. This CL makes it such that we check which area has most recently been cleared to make an informed decision. Bug: b/514010477 Change-Id: I3800ca3125f25341dffd818f6c557692020027be Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1255256 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (depot_tools) into this repository. The build that created this CL was https://ci.chromium.org/b/8677644781164902753 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6048720d2e72ff2f48548fde0870629afdb2ac82~..99c70721367b26efa545923daed4fcb20012fb07 6048720 (ovsienko@google.com) depot_tools: fix presubmit failure by breaking ITTT up to not h... 99c7072 (nerima@google.com) git_cache: read default branch from bootstrap snapshot, not ls-... Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: Idaa823340a61ab087ef16fb700638fcbcfa00854 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1281116 Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
# Conflicts: # DEPS # bazel/external/dawn/dawn_files.bzl # src/gpu/ganesh/ops/AtlasTextOp.cpp # src/gpu/ganesh/ops/StrokeTessellateOp.cpp # src/gpu/graphite/dawn/DawnGraphicsPipeline.cpp # src/gpu/graphite/render/SDFTextLCDRenderStep.cpp # src/ports/SkTypeface_mac_ct.h
In m151, include/private/base/* headers were flattened to include/private/*. Update our C API to use the new path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The m150->m151 merge left three benign divergences from upstream that have no effect on SkiaSharp's shipped output: - infra/bots/jobs.json / tasks.json: upstream m151 added cq_config blocks to the CanvasKit WASM jobs (commit-queue location filters). The merge carried the m150-style entries without them. Restore upstream's versions so the fork's CI config matches m151 exactly. - DEPS: drop the stale commented-out microhttpd entry. Upstream removed libmicrohttpd entirely in m151; the fork only ever referenced it as a commented line, so removing it keeps the commented deps in sync with upstream. In-use DEPS pins (brotli, expat, freetype, harfbuzz, libjpeg-turbo, libpng, libwebp, vulkan-*, zlib) are deliberately preserved. infra_revision already matches upstream m151. The .disabled.go.mod/.disabled.go.sum files are already byte-identical to upstream's go.mod/go.sum (only the filename differs, to disable Go tooling), so they need no change. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
mattleibow
added a commit
to mono/SkiaSharp
that referenced
this pull request
Jun 30, 2026
PR mono/skia#274 ([skia-sync] Merge upstream chrome/m151) has merged into the skiasharp branch as merge commit 5209f4a49b55. Re-pin the submodule from the pre-merge PR head (68e1c7fe3c90) to the merged tip and update the cgmanifest 'Main Skia repository reference' commitHash to match, so Component Governance scans the commit that is actually vendored. The merged tip's tree is identical to 68e1c7fe3c90 (the merge brought in nothing beyond the PR head), so no source content changes. Version numbers in scripts/VERSIONS.txt were already bumped to m151 / soname 151.0.0 / assembly+nuget 4.151.0 (C API increment stays 0), and the cgmanifest CVE entry already tracks chrome_milestone 151 / upstream 79e2e1538e. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mattleibow
added a commit
to mono/SkiaSharp
that referenced
this pull request
Jun 30, 2026
[skia-sync] Update Skia to milestone m151 (4.151.0) (#4294) Changes: mono/skia@chrome/m150...chrome/m151 Companion: mono/skia#274 (merged into the skiasharp branch as 5209f4a49b55) Advances the bundled Skia from chrome/m150 to chrome/m151, bumping the SkiaSharp native/managed version to 4.151.0. Bumps the externals/skia submodule, regenerates scripts/VERSIONS.txt (skia release m151, libSkiaSharp milestone/soname 151, SkiaSharp assembly/file 4.151.0.0), updates SKIASHARP_VERSION in azure-templates-variables.yml, and refreshes cgmanifest.json (chrome_milestone 151, upstream_merge_commit 79e2e1538e, Skia repo ref 5209f4a49b55) for CVE/component tracking. Unlike the m150 sync, this is a clean milestone bump. The C API surface is unchanged (SK_C_INCREMENT stays 0; binding regeneration produces zero diffs in SkiaApi.generated.cs and friends), there are no managed source changes, and no native source fixes had to be carried: all five M150 backports the fork was holding are now upstream in m151. Only two integration touch-ups were needed. ~~ C API include path ~~ m151 flattened include/private/base/* into include/private/* and removed the private/base/ subdirectory. The one affected C API file was fixed in the fork (SkTemplates.h include path), with no C function added, removed, or changed. ~~ Native build config (partition_alloc) ~~ m151 introduced src/partition_alloc/, whose BUILD.gn by default imports ${skia_partition_alloc_dir}/partition_alloc.gni. Our DEPS does not vendor partition_alloc, so skia_use_partition_alloc=false is added to the gn args in every clang platform's native/**/build.cake to opt into the bundled src/partition_alloc/noop/ fallback. The default is is_clang (true on every platform we ship), so the override is required. linux and wasm set it on both the libSkiaSharp and libHarfBuzzSharp GnNinja calls; macos/ios/tvos/windows/ tizen/android set it on libSkiaSharp only (HarfBuzzSharp there builds via xcodebuild/msbuild/ndk-build/tizen, not gn). Per known-gotchas.md #23 the arg lives in build.cake, not --gnArgs. ~~ Submodule pin ~~ Re-pins externals/skia to 5209f4a49b55, the merge commit of fork PR #274 on the stable skiasharp branch (tree-identical to the integration tip 68e1c7fe3c90), and sets the cgmanifest Skia repo reference to match. ~~ Release-notes support tiers ~~ Updates the hand-maintained support block in scripts/infra/docs/versions.json to stable [4.148, 4.150] / preview [4.151]: 4.148 stays Chrome Extended-stable for a few more days, 4.150 (our RC line) goes stable imminently, and 4.151 becomes the in-flight preview. Drop 4.148 once Google retires extended-stable. Full CI is green: build 158573 succeeded across all native platforms (Windows/macOS/Linux/WASM/Tizen/Android/iOS/tvOS), managed build, API diff, tests, and samples. Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated upstream merge of
chrome/m151.Update Skia to milestone 151 (m150 → m151)
Summary
Merges upstream
chrome/m151into ourskiasharpfork.79e2e1538e94bb1d6b5bbbc56279036aa7574b10(chrome/m151)280ec21ada(skiasharp)a2147f95b93c234daa99Conflicts resolved
Seven conflicts came up during the upstream merge:
DEPSinfra_revision; kept our commented-out unused deps and pinned versions (libpng, expat, harfbuzz, libjpeg-turbo, freetype, zlib, brotli, libwebp, vulkanmemoryallocator, vulkan-headers).bazel/external/dawn/dawn_files.bzlgit rm. Not used by our build.src/gpu/ganesh/ops/AtlasTextOp.cpp--theirs. Our M150 backport (86bafa2700 Turn off LCD in SDF slugs) is upstreamed as95dbfa24e0.src/gpu/ganesh/ops/StrokeTessellateOp.cpp--theirs. Our M150 backport (fd9c3a7681 Prevent overflow) is upstreamed asdcf3ebf072.src/gpu/graphite/dawn/DawnGraphicsPipeline.cpp--theirs. Our M150 backport (9f330f1704 Use stable collection) is upstreamed as6a4be3addd.src/gpu/graphite/render/SDFTextLCDRenderStep.cpp--theirs. Our M150 backport (68a31ebe6d Reject Slugs perspective) is upstreamed asa145861ad1.src/ports/SkTypeface_mac_ct.h--theirs. Our M150 backport (14d05ec761 Resolved Data Race on fStream) is upstreamed asba3ee9b265.All five M150 bug-fix backports we carried in our fork are now in upstream m151. No fork patches needed to be re-applied on top.
Verify-upstream-or-reapply audit
Compared the fork patch snapshot (1,021 lines) taken before the merge against the post-merge fork patch list:
src/c/andinclude/c/C API directories are intact (no upstream content collided with our shim).--theirs/--oursresolutions were applied: every conflicted file was classified individually per known-gotchas.md Update skia to m53 #15.C API fix
m151 flattened
include/private/base/*intoinclude/private/*(theprivate/base/subdirectory was removed entirely). Updated our one affected C API file:src/c/sk_font.cpp:#include "include/private/base/SkTemplates.h"→#include "include/private/SkTemplates.h"No new C functions were added; binding regeneration in the parent repo produced no diffs.
SK_C_INCREMENTis already0upstream and stays at0(milestone change resets it).Build
Verified with
dotnet cake --target=externals-linux --arch=x64on the parent repo. BothlibSkiaSharp.so.151.0.0andlibHarfBuzzSharp.so.0.61421.0link cleanly. All 5,584 C# tests pass on Linux x64.Items needing human attention
skia_use_partition_alloc=falsegn arg added in the parent repo'snative/**/build.cake. m151 introducedsrc/partition_alloc/which by default tries to importthird_party/externals/partition_alloc/partition_alloc.gni. OurDEPSdeliberately does not vendor partition_alloc, so we use the noop fallback insrc/partition_alloc/noop/. The arg is applied to every clang platform'sbuild.cake(linux/wasm/macos/tvos/windows/tizen/android/ios) and to both SkiaSharp and HarfBuzzSharp GnNinja calls on linux+wasm — but only linux x64 was actually built in this automated workflow. Please verify the gn args still configure cleanly on Windows/macOS/iOS/Android/WASM in CI before merging.DEPSblock preserves our pinned versions for everything incgmanifest.json. Spot-check that no required new upstream dep was accidentally dropped during the manual resolution.Created by skia-upstream-sync.