Add sk_codec_is_animated C API#263
Open
mattleibow wants to merge 2 commits into
Open
Conversation
mattleibow
force-pushed
the
dev/issue-3939-codec-isanimated
branch
from
9136a6d to
f118794
Compare
Wraps SkCodec::isAnimated() to disambiguate RepetitionCount == 0. Returns enum indicating if codec is animated (Yes/No/Unknown). Issue: mono/SkiaSharp#3939 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use explicit static_cast through int to properly convert C++ enum class to C enum. C-style cast may not work correctly for enum class types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mattleibow
force-pushed
the
dev/issue-3939-codec-isanimated
branch
from
28722b5 to
97f5f22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add C API for
isAnimated()to disambiguateRepetitionCount == 0.C API changes
sk_codec_animation_status_tenum (YES=0, NO=1, UNKNOWN=2)sk_codec_is_animated()functionImplementation notes
Uses explicit
static_cast<int>()to convert C++enum classto C enum. C-style cast does not work correctly for enum class types - it was causing all values to be returned incorrectly, making the API non-functional.Per Skia's own tests (
tests/CodecAnimTest.cpp): animated images withFrameCount > 1returnIsAnimated::kYes, static images returnIsAnimated::kNo.Fixes mono/SkiaSharp#3939