[skia-sync] Merge upstream chrome/m150#253
Merged
Merged
Conversation
https://chromium.googlesource.com/angle/angle.git/+log/997936e81bd4..95d16933d919 2026-05-07 amaiorano@google.com Vulkan: fix potential OOB read in reformatStagedBufferUpdates 2026-05-07 yuxinhu@google.com Skip BasicCopyTextureTest.SelfCopyOOBWrite*GLES on Pixel 10 2026-05-07 bsheedy@chromium.org Remove win-perf builders 2026-05-07 kbr@chromium.org GL: Add recreateFboUponFlush workaround. 2026-05-07 m.maiya@samsung.com Skip trex_200 on S24 bot 2026-05-06 yuxinhu@google.com Skip AttachToMultipleCubeFacesThenMSRTT tests on Pixel 10 2026-05-06 syoussefi@chromium.org Vulkan: Re-enable dynamic state on JM Mali on r51+ 2026-05-06 syoussefi@chromium.org Require that src texture is fb-complete in glCopy*Texture* 2026-05-06 zork@google.com [ANGLE][Metal] Fix GPU memory disclosure in index rewriting 2026-05-06 chenyanx.zhu@intel.com EGL: fix eglChooseConfig crash when EGL_CONFIG_ID is EGL_DONT_CARE 2026-05-06 zmo@chromium.org [angle] Use full logic for HLSL short-circuit unfolding. 2026-05-06 cclao@google.com Vulkan: Limit VertexConversionBuffer to single attribIndex 2026-05-06 bsheedy@chromium.org Calculate commit position in perf test script 2026-05-06 syoussefi@chromium.org Vulkan: Fix removing staged updates during cube map redefine 2026-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from f8972f88c952 to 7a23dfb3e490 (695 revisions) 2026-05-06 syoussefi@chromium.org Translator: Verify that qualifiers are paired with in/out 2026-05-06 solti@google.com Android: Bump com.android.angle targetSdkVersion to 37 2026-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 3fe33a325af9 to 979a45ec1bb1 (4 revisions) 2026-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f02244db668b to 0cac26b01455 (25 revisions) 2026-05-06 victorvianna@google.com Clarify C++ standard in .clang-format If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC alexisdavidc@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win11-Clang-Dell3930-GPU-GTX1660-x86_64-Debug-All-ANGLE Tbr: alexisdavidc@google.com Test: Test: angle_end2end_tests --gtest_filter="EGLChooseConfigTest.ConfigIdDontCare*" Change-Id: I851057cee588973d58305b914ba355825f20e4ae Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1228118 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/766d49b68e2f..a4ff3c87bd50 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/a96bd4933c6adfc21329d15e9999791a0153bbf3..d88097b51e70f357a96237c4571ded3433ccde99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC alexisdavidc@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: alexisdavidc@google.com Change-Id: I3701b76677608d9196952d0b383264f16caf832e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1228476 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Change-Id: Ib2a1a9b2a87e3beb637c2af160f7af460b62b325 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1227756 Reviewed-by: Alexis Cruz-Ayala <alexisdavidc@google.com> Commit-Queue: Alexis Cruz-Ayala <alexisdavidc@google.com> Auto-Submit: Jorge Betancourt <jmbetancourt@google.com>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (depot_tools) into this repository. The build that created this CL was https://ci.chromium.org/b/8682443906884557681 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/a9e01d55dbd1213e45cf9465aff7091cedc1f7c2 a9e01d5 (gavinmak@google.com) Revert "Support parallel DEPS hooks" Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I988bed0d2c2aef37e80f681318ced436150e89b3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1228956 Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Change-Id: Ic92ae7fd7087a188a4a3ca523a75808f7ef06eae Bug: oss-fuzz:506737090 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1229176 Commit-Queue: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com> Auto-Submit: Kaylee Lubick <kjlubick@google.com>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (depot_tools) into this repository. The build that created this CL was https://ci.chromium.org/b/8682429436236628945 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/059acdf446d83eea090f56d674fe038f7607804a 059acdf (dsanders11@ucsbalum.com) gclient_paths: try `<gclient_root>/src/buildtools` for finding... Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I99fd1572e7c3760b31ba230a378223efe4c21fb0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1229296 Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
An SkPicture can contain an SkReadBuffer which can contain an SkPicture which contains an SkPicture which can contain an SkPicture which contains an SkPicture which can contain ... https://review.skia.org/592736 added support for avoiding deeply nested skps, but missed the case where a ReadBuffer got tossed in the mix. I had a test case for this in PS2, but removed it because it was effectively just a huge opaque binary checked in and I didn't want it to get stale eventually. Bug: 496175229 Fixed: 496175229 Change-Id: I6183a78ed5a69499cb457d16d7e0fc430bff2b1f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1226696 Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Kaylee Lubick <kjlubick@google.com>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8682423775120777521 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+log/419f0b9a3c8b99726df412e238a6e1f7b7b83e2f~..526437857cd166aa3680db39165847ceab45435d 419f0b9 (chanli@google.com) [TurboCI] placeholder: fix getting workplan ID from current sta... 5264378 (chanli@google.com) [TurboCI] re-enable real TurboCI client in recipes Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I6c74c98d69edd79beff7d9b3a9dd08caa9087d09 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1229359 Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/a4ff3c87bd50..f2bd0563dba7 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/8864cdc896bbc2a9b6eb36b3218fc9ef57908d77..7f233bc128bebd91c914ddc3678aa970828031d6 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/5d40749670ccde08fd91412d3daa074615940d6a..d2994039d549970c5d8f60603209a947c5241cb2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC alexisdavidc@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: alexisdavidc@google.com Change-Id: I4a37fe49dc37fa85424149c8961a540aa9ec5859 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1229496 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://skia.googlesource.com/buildbot.git/+log/f7c1e4ac4125..99ee78410476 2026-05-07 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - on - perf/FREEZELOCK 2026-05-07 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - off - perf/FREEZELOCK 2026-05-07 wenbinzhang@google.com Revert "[public's a subset] Add TraceVisibility and TraceParams.is_public" 2026-05-07 wenbinzhang@google.com Revert "[public's a subset] fetch logic" 2026-05-07 eduardoyap@google.com [pinpoint] Support base_extra_args and experiment_extra_args in Pairwise Try Jobs 2026-05-07 borenet@google.com [mcp] Support loading logs in reverse for Skia tasks 2026-05-07 eduardoyap@google.com [Pinpoint] Handle compare pairwise edge cases (NaN/Inf JSON crash) 2026-05-07 eduardoyap@google.com [Pinpoint] Truncate mismatched control/treatment arrays in pairwise runner 2026-05-07 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - on - perf/FREEZELOCK 2026-05-07 eduardoyap@google.com [explore-multi-v2-sk] Support deterministic time range (begin/end) and synchronous drag URL updates 2026-05-07 borenet@google.com [task driver] Support loading log pages in reverse 2026-05-07 ansid@google.com Make shortcuts work on local runs 2026-05-07 faridzad@google.com [Skia] Fix the 'pinpoint/go/workflows/worker' build error. 2026-05-07 mordeckimarcin@google.com Show legacy anomalies on autopush by default 2026-05-07 viktarzinkou@google.com [perf] Provide an option to limit traces in backfilling 2026-05-07 ansid@google.com Rename multi-select-sk to resolve conflict with another multi-select-sk 2026-05-07 sergeirudenkov@google.com [public's a subset] fetch logic 2026-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-final from 030bdcebf467 to 2c96eeafb886 2026-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Depot Tools from fba5d8a8b46a to 8a58b411c2ee (3 revisions) 2026-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-final from 9b60011b738f to 85705a7dd4f0 2026-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll command_wrapper from c22572d57995c53bb... to 5bc13f809f6c32d4b... (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC kjlubick@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:346836299,chromium:504536191,chromium:508227920 Tbr: kjlubick@google.com Change-Id: I4d2fe16bb00c1dd5d5b2213d5f3b7c036324b793 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1229776 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (depot_tools) into this repository. The build that created this CL was https://ci.chromium.org/b/8682397350475607793 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/835fc3f2cb489a1e0a2cf598350d648a28d31e49 835fc3f (rop@google.com) [metadata] Add reciprocal license disallowance Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: Iaf58fbc78fa7eb4aa2ccb81d30813d54fcdfd834 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1229858 Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://chromium.googlesource.com/angle/angle.git/+log/95d16933d919..ab41985470ba 2026-05-07 syoussefi@chromium.org AST: Fix variable declaration in dead code in `case` 2026-05-07 solti@google.com Harness: Preserve --gtest_output for Google Test 2026-05-07 syoussefi@chromium.org Add a test for unbound storage images 2026-05-07 syoussefi@chromium.org Revert "GL: Assume GL 3.2+ when deciding caps" 2026-05-07 sergiosolano@google.com Update Span to match modern base::span patterns 2026-05-07 bsheedy@chromium.org Remove win-perf //infra/specs entries 2026-05-07 syoussefi@chromium.org EGL: Fix UAF if initialization fails 2026-05-07 syoussefi@chromium.org MSL: Inspect loop init/cond/expr in loop-forward-progress 2026-05-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0cac26b01455 to 9cab38ea0404 (7 revisions) 2026-05-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7a23dfb3e490 to 19bd71e8d112 (790 revisions) 2026-05-07 syoussefi@chromium.org Test that gl_Clip/CullDistance cannot be redeclared without size If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC alexisdavidc@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win11-Clang-Dell3930-GPU-GTX1660-x86_64-Debug-All-ANGLE Tbr: alexisdavidc@google.com Test: Test: b/510380885#comment2, b/510380885#comment3 Change-Id: I55169864a31e2473dae79a0f15372948574c4177 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1229658 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/f2bd0563dba7..df94adb30172 Also rolling transitive DEPS: https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/1f2dd1627ae782fa999b6ed86514c6a905438e3c..58006c901d1d5c37dece6b6610e9af87fa951375 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/7f233bc128bebd91c914ddc3678aa970828031d6..0e9de566b7d4051c5cc1b762e242c46565956bdf https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/d2994039d549970c5d8f60603209a947c5241cb2..353f23f2c0bdf90bce0df551633c5ed873f530ba https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/d88097b51e70f357a96237c4571ded3433ccde99..8752119a6a407bac16313d38f3e935c8d619b089 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC alexisdavidc@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: alexisdavidc@google.com Change-Id: Iec3f7a322c4e802e8b857d5d93b6632f154b1b55 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1229751 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bug: b/502632493 Change-Id: If70ed0b515a52c57f211e7410d36caf0af368596 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1218399 Reviewed-by: Julia Lavrova <jlavrova@google.com> Auto-Submit: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Florin Malita <fmalita@google.com>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (depot_tools) into this repository. The build that created this CL was https://ci.chromium.org/b/8682361489172267633 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/d18b0f4fe3d0311cbc269f91813fbb7b6cf3dcb3 d18b0f4 (agrieve@chromium.org) Improve the "build finished" message for agents Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I66fb85c29c13c53c86a8ab03971c40ef03e28964 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1230241 Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This reverts commit 5a12179. Reason for revert: Tint supports F16+FramebufferFetch now Original change's description: > Disable FramebufferFetch for Android > > Dawn/Vulkan doesn't support FramebufferFetch and ShaderF16 used > together. Disable FramebufferFetch until that is resolved. > > Bug: b/493892934 > Change-Id: I07e3630e1d8b9582db712351738b0f5b25150c8c > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1226596 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > Commit-Queue: Kyle Charbonneau <kylechar@google.com> Bug: b/493892934 Change-Id: I523fc8518fceb4ff683c77dfef43978ec372e75c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1230737 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Kyle Charbonneau <kylechar@google.com>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8682319966624920177 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/70bb072f0c4b15194060aafbafe3e0ce79a0387f 70bb072 (chromium-autoroll@skia-public.iam.gserviceaccount.com) Roll CAS Client from 3df8f33fc497 to af8531728740 Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I8cf1b908e403474982bba4b53dba858fdcfb3206 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1230418 Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/df94adb30172..3a658da10db4 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/0e9de566b7d4051c5cc1b762e242c46565956bdf..8cfaaa1d4deedc865e52a42e654c5ec0d7d75eb0 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/353f23f2c0bdf90bce0df551633c5ed873f530ba..ead00c13573f705b49130425cb38d70bd2aea0cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC alexisdavidc@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: alexisdavidc@google.com Change-Id: I95cb11b42a50c665d188ab3d7728efb0b1848062 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1230464 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skp-skia Please CC jmbetancourt@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SKP CIPD package: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: jmbetancourt@google.com Change-Id: I6c97b4d6d55b7b9058ae09bb59becc3cfb184e07 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1230956 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/3a658da10db4..e069d6e7382e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC jmbetancourt@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: jmbetancourt@google.com Change-Id: Ic234b03c4ed1f56ca61ceba5921da3d09b6581e1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1231096 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/debugger-app-base-skia Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: borenet@google.com Change-Id: I84d52ef72e3aafd00031e36563893e14072c011e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1231217 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://skia.googlesource.com/buildbot.git/+log/99ee78410476..4ff5776b821e 2026-05-08 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - off - perf/FREEZELOCK 2026-05-08 zhanliang@google.com [CBB] Use team alias for failure notification emails 2026-05-08 zhanliang@google.com Revert "[pinpoint] Support base_extra_args and experiment_extra_args in Pairwise Try Jobs" 2026-05-08 zhanliang@google.com [CBB] Improve failure emails 2026-05-08 sergeirudenkov@google.com Reland "[public's a subset] Add TraceVisibility and TraceParams.is_public" 2026-05-08 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - on - perf/FREEZELOCK 2026-05-08 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - off - perf/FREEZELOCK 2026-05-08 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - on - perf/FREEZELOCK 2026-05-08 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - off - perf/FREEZELOCK 2026-05-08 sruslan@google.com Make suggestions in multi-explore view query-specific. 2026-05-08 sruslan@google.com Extract trace type definitions to a separate file. 2026-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-final from 85705a7dd4f0 to 0bea37cb1de7 2026-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll command_wrapper from 5bc13f809f6c32d4b... to a1663394b3c883bb9... (1 revision) 2026-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Depot Tools from 8a58b411c2ee to 86ddfc92bce7 (4 revisions) 2026-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-final from 2c96eeafb886 to 79350e38c42b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:346836299,chromium:504536191 Tbr: borenet@google.com Change-Id: Ibe10c8515d1022ba725ade293d23852d424e94c7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1231198 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (depot_tools) into this repository. The build that created this CL was https://ci.chromium.org/b/8682128072539906401 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/7b46edbbedc92d910a485815c2499d74254b4f74 7b46edb (wnwen@google.com) Add EPL-2.0 to allowlist Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: Ica02316e07b2804bbd3bc11c315287f4c0acacbc Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1231202 Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://chromium.googlesource.com/angle/angle.git/+log/ab41985470ba..2d8f36f37859 2026-05-10 kbr@chromium.org Add !isMesa to recreateFboUponFlush workaround. 2026-05-08 lexa.knyazev@gmail.com Remove unrelated code from image data size validation 2026-05-08 cclao@google.com Vulkan: Fix bug with framebuffer layer change without rebind 2026-05-08 syoussefi@chromium.org Update test to match ANGLE's style 2026-05-08 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll Chromium from 19bd71e8d112 to 7d34a38cf72c (905 revisions) 2026-05-08 bsheedy@chromium.org Remove legacy win-trace builder 2026-05-08 m.maiya@samsung.com Vulkan: Unconditionally enable GL_ANGLE_rgbx_internal_format extension 2026-05-08 ynovikov@chromium.org Skip DeleteTextureBoundToImageUnit on Pixel 10 GLES 2026-05-08 bsheedy@chromium.org Add src-side win-trace equivalent 2026-05-08 kbr@chromium.org Restrict recreateFboUponFlush workaround. 2026-05-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9cab38ea0404 to 4c5f45e113d5 (24 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC jmadill@google.com,jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win11-Clang-Dell3930-GPU-GTX1660-x86_64-Debug-All-ANGLE Tbr: jmbetancourt@google.com Change-Id: I33aa1b6dcbf9eb66a21f3dd770be77143f0ea5f8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1231099 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/e069d6e7382e..4391cb02adc5 Also rolling transitive DEPS: https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/58006c901d1d5c37dece6b6610e9af87fa951375..98c842bd561ac67c5ff98d599c8c960ba9edb7fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC jmbetancourt@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: jmbetancourt@google.com Change-Id: Ie0b9b9104427d133ca5af134f25ef3bc912cccdd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1231284 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Change-Id: I9dae8bb736f4e45586db584e8c28421464392b95 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1160878 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Thomas Smith <thomsmit@google.com>
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (depot_tools) into this repository. The build that created this CL was https://ci.chromium.org/b/8682082148947222849 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/ea763c7cac5b37021331eb181b2989b826a29701 ea763c7 (christianxu@chromium.org) Add --skip-worktrees to rebase-update Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I463a843796339508970e8d630396c16c59f0da82 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1231896 Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
The abseil-cpp version was updated in DEPS but wasn't being changed in deps.json or deps_gen.go. Presumably this is a limitation of our roller. Manually updated these versions to complete the roll. https://review.skia.org/1231220 used as a base. Roll Dawn from b048990c1246 to 294c85cfb313 (27 revisions) https://dawn.googlesource.com/dawn.git/+log/b048990c1246..294c85cfb313 2026-05-10 chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com Remove stale WebGPU CTS expectations 2026-05-09 kylechar@google.com Reland "vulkan: Implement coherent FramebufferFetch" 2026-05-09 shrekshao@google.com Fix CaptureWalkTest.cpp Build.gn 2026-05-09 shanxing.mei@intel.com [d3d12][intel] Enable DecomposeWorkgroupAccess for cts failures 2026-05-09 lokokung@google.com [tests] Add new feature list after AtomicVec2uMinMax changes 2026-05-08 jrprice@google.com [uniformity] Fix partial pointer call argument handling 2026-05-08 jrprice@google.com [uniformity] Fix let propagation of partial pointers 2026-05-08 chouinard@google.com [tint][spirv] Decorate intermediates with RelaxedPrecision 2026-05-08 chouinard@google.com [tint][spirv] Support f16 Framebuffer Fetch 2026-05-08 dsinclair@chromium.org Call `Base::Destroy` instead of `Instruction::Destroy`. 2026-05-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7180bfbb2f20 to 6be6fe6fefe6 (1161 revisions) 2026-05-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 21e55b140a12 to ab41985470ba (10 revisions) 2026-05-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from 7ee36d8371f2 to 54a6469009c5 (1 revision) 2026-05-08 rharrison@chromium.org Fix body text of source code license headers 2026-05-07 rharrison@chromium.org [fuzz] Add -mesa to ./tools/run fuzz 2026-05-07 rharrison@chromium.org [fuzz] Add fuzzer front ends for fuzzing mesa 2026-05-07 rharrison@chromium.org [fuzz] Overhaul structure of Tint fuzzers 2026-05-07 petermcneeley@google.com [tint] AtomicVec2u (64bit) for DX12 backend 2026-05-07 shrekshao@google.com Capture: Surface and SwapChain 2026-05-07 cwallez@chromium.org [YUV AHB] W/a Exynos GPUs not handling RGB_IDENTITY correctly. 2026-05-07 cwallez@chromium.org [YUV AHB] Fix PQ and HLG color space luminance. 2026-05-07 dsinclair@chromium.org Convert builtin_polyfill files over to using lambda. 2026-05-07 lokokung@google.com Manual roll Chromium from c8fb3065f829 to 7180bfbb2f20 (12812 revisions) 2026-05-07 cwallez@chromium.org [dawn][node] Add support for ResourceTable. 2026-05-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from fe2615732899 to 7ee36d8371f2 (1 revision) 2026-05-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5f0e794041ec to 21e55b140a12 (44 revisions) 2026-05-07 lokokung@google.com Revert "[emscripten] Add support for immediates" Also rolling transitive DEPS: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/dd4432fb02583b7a5b2b4fbf2012f7053e286ce0..204ad6277cf961a6551b437e9c32ac3c528a3649 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC alanbaker@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac14-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: None Change-Id: I79c2283ea1f0096843f004935d0bfc66c6aad789 Tbr: alanbaker@google.com Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1231756 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Brandon Wilson <bwils@google.com>
Change-Id: Ibb38fac9e2b149e774e76555058fa85a79eb30e1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1230696 Commit-Queue: Thomas Smith <thomsmit@google.com> Reviewed-by: Kaylee Lubick <kjlubick@google.com>
This reverts commit b4d0d3a. Reason for revert: Likely culprit for build break- https://task-driver.skia.org/td/9bbKcY7nhrqpUoehO8Je Original change's description: > Manually created dawn roll. > > The abseil-cpp version was updated in DEPS but wasn't being changed in > deps.json or deps_gen.go. Presumably this is a limitation of our roller. > Manually updated these versions to complete the roll. > > https://review.skia.org/1231220 used as a base. > > Roll Dawn from b048990c1246 to 294c85cfb313 (27 revisions) > > https://dawn.googlesource.com/dawn.git/+log/b048990c1246..294c85cfb313 > > 2026-05-10 chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com Remove stale WebGPU CTS expectations > 2026-05-09 kylechar@google.com Reland "vulkan: Implement coherent FramebufferFetch" > 2026-05-09 shrekshao@google.com Fix CaptureWalkTest.cpp Build.gn > 2026-05-09 shanxing.mei@intel.com [d3d12][intel] Enable DecomposeWorkgroupAccess for cts failures > 2026-05-09 lokokung@google.com [tests] Add new feature list after AtomicVec2uMinMax changes > 2026-05-08 jrprice@google.com [uniformity] Fix partial pointer call argument handling > 2026-05-08 jrprice@google.com [uniformity] Fix let propagation of partial pointers > 2026-05-08 chouinard@google.com [tint][spirv] Decorate intermediates with RelaxedPrecision > 2026-05-08 chouinard@google.com [tint][spirv] Support f16 Framebuffer Fetch > 2026-05-08 dsinclair@chromium.org Call `Base::Destroy` instead of `Instruction::Destroy`. > 2026-05-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7180bfbb2f20 to 6be6fe6fefe6 (1161 revisions) > 2026-05-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 21e55b140a12 to ab41985470ba (10 revisions) > 2026-05-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from 7ee36d8371f2 to 54a6469009c5 (1 revision) > 2026-05-08 rharrison@chromium.org Fix body text of source code license headers > 2026-05-07 rharrison@chromium.org [fuzz] Add -mesa to ./tools/run fuzz > 2026-05-07 rharrison@chromium.org [fuzz] Add fuzzer front ends for fuzzing mesa > 2026-05-07 rharrison@chromium.org [fuzz] Overhaul structure of Tint fuzzers > 2026-05-07 petermcneeley@google.com [tint] AtomicVec2u (64bit) for DX12 backend > 2026-05-07 shrekshao@google.com Capture: Surface and SwapChain > 2026-05-07 cwallez@chromium.org [YUV AHB] W/a Exynos GPUs not handling RGB_IDENTITY correctly. > 2026-05-07 cwallez@chromium.org [YUV AHB] Fix PQ and HLG color space luminance. > 2026-05-07 dsinclair@chromium.org Convert builtin_polyfill files over to using lambda. > 2026-05-07 lokokung@google.com Manual roll Chromium from c8fb3065f829 to 7180bfbb2f20 (12812 revisions) > 2026-05-07 cwallez@chromium.org [dawn][node] Add support for ResourceTable. > 2026-05-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from fe2615732899 to 7ee36d8371f2 (1 revision) > 2026-05-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5f0e794041ec to 21e55b140a12 (44 revisions) > 2026-05-07 lokokung@google.com Revert "[emscripten] Add support for immediates" > > Also rolling transitive DEPS: > https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/dd4432fb02583b7a5b2b4fbf2012f7053e286ce0..204ad6277cf961a6551b437e9c32ac3c528a3649 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/dawn-skia-autoroll > Please CC alanbaker@google.com,cwallez@google.com on the revert to ensure that a human > is aware of the problem. > > To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry > To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry > > To report a problem with the AutoRoller itself, please file a bug: > https://issues.skia.org/issues/new?component=1389291&template=1850622 > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md > > Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac14-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 > Bug: None > Change-Id: I79c2283ea1f0096843f004935d0bfc66c6aad789 > Tbr: alanbaker@google.com > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1231756 > Reviewed-by: Eric Boren <borenet@google.com> > Commit-Queue: Brandon Wilson <bwils@google.com> Bug: None Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac14-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I5f669d9a3897c821514e5e6a2cc68a147632690d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1231679 Commit-Queue: Brandon Wilson <bwils@google.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/d8c0b6852f61..b57006f9536e Also rolling transitive DEPS: https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/af15c1bd0e5ec2c3da9e6439bc262cd73c0d79f4..39813baec458ada43263749757b15fbfbd6be107 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC nicolettep@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: nicolettep@google.com Change-Id: Iee85b1537120755b50769d6aa8a205c10eed8f17 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1250377 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://skia.googlesource.com/buildbot.git/+log/db195a05b659..2da962880dc7 2026-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-final from c8dc9f871a83 to ec71bc8087ae 2026-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Depot Tools from 2f9bc10799af to 4bf9218cac07 (1 revision) 2026-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-final from cd0f7fec4181 to b341aa58ae4f 2026-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll command_wrapper from 60f170d7971d1f726... to 2e6f0be1cab54719a... (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC kjlubick@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: kjlubick@google.com Change-Id: I39f5b37c4e591e7a039dca6c396680cf15a5df96 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1250556 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/angle/angle.git/+log/31b176246d7e..c01fdb7503e3 2026-05-30 valentine.burley@collabora.com Vulkan: Fix Turnip driver version string 2026-05-29 bsheedy@chromium.org Suppress flaky Intel test 2026-05-29 timvp@google.com FramebufferTest: Fix InvalidateIncompleteDepthStencil 2026-05-29 bsheedy@chromium.org Switch Win/x64/rel to historyless 2026-05-29 cclao@google.com Vulkan: Fix ImageTestES3.RenderToYUVAHB regression 2026-05-29 yuxinhu@google.com Add an option to clean the submodules 2026-05-29 cclao@google.com Vulkan: Properly clean up CommandBufferHelpers on context error 2026-05-29 bsheedy@chromium.org Switch Linux/x64/Release to Starlark tests 2026-05-29 geofflang@chromium.org Manual roll third_party/dawn 2026-05-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 9898204d91d6 to d26a3e6606c0 (5 revisions) 2026-05-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4029144db7a0 to 3cececf546e2 (12 revisions) 2026-05-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 0e65a7575c25 to bdd6350bab8e (1600 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC jmadill@google.com,nicolettep@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win11-Clang-Dell3930-GPU-GTX1660-x86_64-Debug-All-ANGLE Tbr: nicolettep@google.com Test: Test: ./scripts/roll_aosp.sh in android external/angle Test: Test: angle_end2end_tests \ Change-Id: I99e58854a636479f7bfddaa270bfa32dbc77a5bb Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1250496 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Manual roll requested by kjlubick@google.com https://dawn.googlesource.com/dawn.git/+log/ce586f1e2a62..63f25feec51e 2026-06-01 kjlubick@google.com Fix bazel select for windows 2026-05-31 chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com Remove stale WebGPU Compat CTS expectations 2026-05-31 chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com Remove stale WebGPU CTS expectations 2026-05-30 amaiorano@google.com [native][d3d12] Fix dispatch size 0 not increment dispatch counter 2026-05-30 amaiorano@google.com [native] Fix IndirectDrawValidationEncoder merging non-matching passes 2026-05-30 jrprice@google.com Bandaid fix for X11 header issue 2026-05-29 arthursonzogni@chromium.org infra: Enable Python unit tests for root PRESUBMIT 2026-05-29 bsheedy@google.com Suppress Pixel 10 failures 2026-05-29 alanbaker@google.com [msl] Fix host-shareable struct emission with buffer_view 2026-05-29 jrprice@google.com Bump golang version in DEPS 2026-05-29 kainino@chromium.org Fix cross-compilation for Windows on Mac/Linux 2026-05-29 kainino@chromium.org [gn] Autoformat all GN files 2026-05-29 blundell@chromium.org [GN] Avoid ANGLE dylibs being built when ANGLE is linked statically 2026-05-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a8f28255baa4 to 3cececf546e2 (7 revisions) 2026-05-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e357a3a4893e to 31b176246d7e (6 revisions) 2026-05-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5bdd0d2b0742 to 823a409ba1ef (751 revisions) 2026-05-29 kainino@chromium.org [cmake] Enable dawn_version target in Wasm 2026-05-29 dsinclair@chromium.org Update build file include paths. 2026-05-29 jrprice@google.com [ir] Add DisallowVectorMinMaxClamp property 2026-05-29 jrprice@google.com [ir] Combine scalarization options 2026-05-29 jrprice@google.com [ir] Move AllowOverrides to a property 2026-05-29 kainino@chromium.org [deps] Add clangd as optional dep 2026-05-29 lokokung@google.com [native] Early out storing function in the BlobCache. 2026-05-29 kainino@chromium.org [utils] Move windows_with_undefs.h to utils/ 2026-05-29 kainino@chromium.org [utils] Move NonMovable and NonCopyable to utils/ 2026-05-29 jrprice@google.com Revert "Reland: [gn] Add support for generated sources" 2026-05-29 lokokung@google.com [fuzz] Make sure that we teardown for fuzzer injected errors. 2026-05-29 dsinclair@chromium.org Update dawn/wire includes 2026-05-29 dsinclair@chromium.org Update dawn/utils includes 2026-05-29 dsinclair@chromium.org Update dawn/tests includes 2026-05-29 jrprice@google.com [ir] Add protobuf support for constexpr_if 2026-05-29 dsinclair@chromium.org Add resource_table transform document. 2026-05-28 jrprice@google.com [fuzz] Add generic mechanism for unsupported properties 2026-05-28 jrprice@google.com [ir] Move AllowMultipleEntryPoints to a property 2026-05-28 cwallez@chromium.org [dawn][vulkan] Put PipelineSpecialization caches under a Mutex. 2026-05-28 cwallez@chromium.org [dawn][common] Signal the CondVar before unlocking the mutex. 2026-05-28 rharrison@chromium.org Add -triage to ./tools/run fuzz 2026-05-28 amaiorano@google.com [native][d3d12] Fix use of incorrect descriptor heaps on cross-pass heap 2026-05-28 jrprice@google.com [ir] Add ValueArrayCount support to protobuf 2026-05-28 dsinclair@chromium.org Update dawn/samples includes 2026-05-28 dsinclair@chromium.org Update dawn/replay includes 2026-05-28 jrprice@google.com [ir] Add override support to protobuf 2026-05-28 cwallez@chromium.org [dawn][vk] Use VkDriverId to decide workaround toggles. 2026-05-28 dsinclair@chromium.org Update dawn/platform includes 2026-05-28 dsinclair@chromium.org Update dawn/partition_alloc includes 2026-05-28 jrprice@google.com [fuzz] Remove SubstituteOverridesConfig helpers 2026-05-28 dsinclair@chromium.org Update dawn/native includes 2026-05-28 jrprice@google.com [ir] Add Property enum to Module 2026-05-28 jrprice@google.com [fuzz] Pass --verbose to assembler during corpus generation 2026-05-28 dsinclair@chromium.org Update dawn/native/webgpu includes 2026-05-28 dsinclair@chromium.org Update dawn/native/vulkan includes 2026-05-28 kainino@chromium.org [utils] Add 'nocompile' testing 2026-05-28 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 6846f3d39e27 to 5bdd0d2b0742 (777 revisions) 2026-05-28 dsinclair@chromium.org Update dawn/native/utils includes 2026-05-28 dsinclair@chromium.org Update dawn/native/stream includes 2026-05-28 dsinclair@chromium.org Update dawn/native/opengl includes 2026-05-28 dsinclair@chromium.org Update dawn/native/null includes 2026-05-28 dsinclair@chromium.org Update dawn/native/metal includes 2026-05-28 dsinclair@chromium.org Update dawn/native/d3d12 includes 2026-05-28 dsinclair@chromium.org Update dawn/native/d3d11 includes 2026-05-28 dsinclair@chromium.org Update dawn/native/d3d includes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC cwallez@google.com,kjlubick@google.com,shrekshao@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac14-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: None Tbr: shrekshao@google.com,kjlubick@google.com Change-Id: I9a751a1193f608c2904bfe333f0cd19fe39295b8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1251096 Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/b57006f9536e..d418e8ba7c95 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC nicolettep@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE Bug: None Tbr: nicolettep@google.com Change-Id: I0f1704c1c21a1f9802702d26c2ed1ec7b4b25584 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1251136 Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Follow-up to https://review.skia.org/1245496. Since we use the Chromium Windows toolchain (which changed to dynamic ASAN linking in https://crrev.com/c/5921462) we have to update what we do. This uses dynamic linking and then copies in the runtime to the out directory. Bug: 514697001 Change-Id: I513b1e92b839ae7cade0361b8a757ba1370e45d5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1251116 Reviewed-by: Nicolette Prevost <nicolettep@google.com> Commit-Queue: Kaylee Lubick <kjlubick@google.com> Commit-Queue: Nicolette Prevost <nicolettep@google.com>
Change-Id: Ib0d1d9d37a441637038078219fdf0c7c29c2379b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1252356 Bot-Commit: chrome-branch-day <chrome-branch-day@chops-service-accounts.iam.gserviceaccount.com>
Change-Id: I75e49dd1b53884d6af91c691fa1a722758d35e6b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1252244 Bot-Commit: chrome-branch-day <chrome-branch-day@chops-service-accounts.iam.gserviceaccount.com>
A couple more headers have been moved to src/utils/BUILD.bazel. Change-Id: Ie81ff2519c5e52fbb4bb77c012c8a1233badf1b4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1251476 Reviewed-by: Kaylee Lubick <kjlubick@google.com> Commit-Queue: Kaylee Lubick <kjlubick@google.com> Auto-Submit: Florin Malita <fmalita@google.com> Commit-Queue: Florin Malita <fmalita@google.com> (cherry picked from commit 886ce5f) Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1252536 Reviewed-by: Florin Malita <fmalita@google.com> Auto-Submit: Kaylee Lubick <kjlubick@google.com>
Original change's description: > Turn off LCD in SDF slugs when downscaling too far > > LCD text samples the glyph at 1/3 offsets derived from screen-space > derivatives of its local coords. Each SDF atlas only has 2px of > transparent padding that these offsets can read into. > > If an LCD slug was downscaled after creating its masks by a scale > of ~0.2, its R and B samples could extend into adjacent glyphs. > At such a downscaling, the SDF is already fairly low quality because > it's not sampled by mipmaps. IMO switching to grayscale SDF looked > better because it approached smooth gray vs. randomized colors. > > This applies to both Ganesh and Graphite, although Graphite is able to > continue to use LCD with SDFs when there's perspective. Since Ganesh > only uses SkMatrix and not Transform, there's no easy way to estimate > the perspective scale factors applied over the slug's bounding box. > > I tested by modifying GM_slug to use LCD and SDF fonts and interacted > with viewer's dynamic transforms to trigger the switch between modes. > > Bug: 516915337 > Change-Id: Idfa838cfe4ff9443bf2c15078ff52d34a5a5c8f3 > Fixed: 516915337 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1251156 > Reviewed-by: Thomas Smith <thomsmit@google.com> > Commit-Queue: Michael Ludwig <michaelludwig@google.com> (cherry picked from commit 95dbfa2) Bug: 519444909,516915337,516915337 Change-Id: Idfa838cfe4ff9443bf2c15078ff52d34a5a5c8f3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1254076 Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Original change's description: > [ganesh] Prevent overflow in StrokeTessellateOp > > Bug: b/519168327 > Change-Id: Ic809a5c9c93018bc584b6284ba1b64205485f83b > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1253636 > Commit-Queue: Thomas Smith <thomsmit@google.com> > Reviewed-by: Michael Ludwig <michaelludwig@google.com> (cherry picked from commit dcf3ebf) Bug: 520437099,b/519168327 Change-Id: Ic809a5c9c93018bc584b6284ba1b64205485f83b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1256017 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Original change's description: > Reject Slugs that have creationMatrix with perspective > > This shouldn't happen during normal use [1] but if the data > is corrupted, there are some assumptions that can can cause > issues, like the ones linked in the bug. > > This rejects those and turns one assert into an actual runtime > check to provide defense in depth. > > [1] https://github.com/google/skia/blob/9eecbdc30f7da675edab96974b23174a9d521e0c/src/text/gpu/SubRunContainer.cpp#L1578-L1581 > > Bug: 520113415 > Fixed: 520113415 > Change-Id: I6ec23df9a23ea588fa89f7a62dc1f197fe3905fd > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1256016 > Commit-Queue: Kaylee Lubick <kjlubick@google.com> > Reviewed-by: Thomas Smith <thomsmit@google.com> (cherry picked from commit a145861) Bug: 520918962,520113415,520113415 Change-Id: I6ec23df9a23ea588fa89f7a62dc1f197fe3905fd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1257276 Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Original change's description: > Avoid improper mask formats for SDFT runs > > SDFTSubRun has a hard assumption of the kA8 mask format and > if the vertex filler differs, there will be a memory mismatch. > > This catches it when deserializing the Slug and changes the > debug-only assert to be runtime to make sure we don't miss other > places. > > Bug: 520571816 > Fixed: 520571816 > Change-Id: I9ae3e509397e23d38d621cb7eb8bb5b955a43d7d > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1257397 > Commit-Queue: Kaylee Lubick <kjlubick@google.com> > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > Reviewed-by: Thomas Smith <thomsmit@google.com> (cherry picked from commit eac1515) Bug: 522133313,520571816,520571816 Change-Id: I9ae3e509397e23d38d621cb7eb8bb5b955a43d7d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1260716 Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Original change's description: > [ganesh] Track async task execution for callbacks > > The submit proc is invoked with success=true if any tasks were executed > and the submission of *those* tasks succeeded. Async reads also need > to be gated on whether or not their actual task was executed. > > Bug: 517992755 > Fixed: 517992755 > Change-Id: I75b196111f03873c92b6d2f599a1055ce6a814cf > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1257336 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Michael Ludwig <michaelludwig@google.com> (cherry picked from commit 22c683d) Bug: 522134444,517992755,517992755 Change-Id: I75b196111f03873c92b6d2f599a1055ce6a814cf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1260736 Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
…m m150 The // TODO(kjlubick) comment was carried over the conflict merge and is a fork-only delta against upstream chrome/m150. Removing it so the test file matches upstream exactly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SkPDFTag.cpp used std::views::reverse, which requires libc++ ranges support. emscripten 3.1.34 (libc++ 15) ships ranges behind disabled incomplete-features, breaking the WASM .NET 8 build. Replace the range-based loop with an equivalent reverse-iterator loop that also compiles on Tizen clang 10. Guard the PDF document factories in sk_document.cpp with SK_SUPPORT_PDF so libSkiaSharp links when skia_enable_pdf=false (needed for the Tizen stopgap that disables the C++20 PDF backend). See #4155. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Skia m150's PDF backend uses C++20 defaulted three-way comparison
(operator<=>) and defaulted operator==, which require <compare> and a
C++20 stdlib. Tizen Studio's clang 10 + gcc 9.2 libstdc++ (tizen-8.0
rootstrap) lacks <compare> and crashes parsing the defaulted spaceship,
so SkiaSharp had to disable skia_enable_pdf on Tizen (SkiaSharp #4155).
The std::views::reverse usage in SkPDFTag.cpp was already replaced with
a reverse-iterator loop in the parent commit (for WASM/emscripten).
This commit removes the remaining C++20-only constructs:
src/pdf/SkPDFTypes.h
- drop <compare>
- SkPDFIndirectReference / SkPDFParentTreeKey: replace defaulted
operator<=> with explicit ==,!=,<,<=,>,>= over fValue.
src/pdf/SkPDFTag.cpp
- drop <compare> and the now-unused <ranges>
- ContentIndex: explicit comparison operators (lexicographic over
fParentId then fMcid).
- ContentSpan::Data and ContentSpan: explicit operator== replacing
the defaulted ones.
Behaviour is identical. Unblocks re-enabling skia_enable_pdf on Tizen.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Backport m150 PDF three-way comparisons to C++17 so PDF compiles on the Tizen clang-10/gcc-9.2 toolchain (re #4155). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…Set4 m150's SkFontMgr_win_dw.cpp uses IDWriteFontSet4, declared only in the Windows 11 SDK (10.0.22621). gn selects the lowest installed SDK >= min_win_sdk_version, so raise the floor from upstream's 10.0.16299.0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The C++17 PDF backport used std::optional<Data>::emplace(ci, ci), but ContentSpan::Data is an aggregate (no user-declared constructor). On the Tizen gcc-9.2 libstdc++, optional::emplace requires is_constructible, which aggregate initialization does not satisfy, so the build failed with 'no matching member function for call to emplace'. Assign an aggregate- initialized Data instead, which compiles on all toolchains. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
m150 added the ml3/ml4 SkOpts micro-arch levels which pass -march=x86-64-v3 and -march=x86-64-v4 on non-Windows x86_64. Those CPU names were added in clang 12; Tizen Studio's clang 10 rejects them with 'unknown target CPU'. Use the ISA-equivalent haswell / skylake-avx512 names (already used for the 32-bit x86 branch) when is_tizen, leaving other platforms on v3/v4. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
m150 commit 20c3044 guarded GrBackendTextureData::equal and GrBackendRenderTargetData::equal under GPU_TEST_UTILS but left GrBackendFormatData::equal unconditionally pure virtual. The D3D backend was left inconsistent: - GrD3DBackendFormatData::equal was fully guarded under GPU_TEST_UTILS, making the class abstract in non-test builds (the only backend that compiles D3D is SkiaSharp's Windows build). - GrD3DBackendTextureData::equal had its declaration outside the guard (only the body was guarded), so it was marked 'override' with no matching base virtual in non-test builds. Match GL/Vulkan/Metal: declare FormatData::equal unconditionally and fully guard TextureData::equal under GPU_TEST_UTILS. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The SK_SUPPORT_PDF guard added for the Tizen PDF stopgap broke PDF document creation on ALL platforms: SkiaSharp's C API shims compile into :core, but SK_SUPPORT_PDF is a public_define of :pdf (a dep of :skia, not :core), so the guard was always false in sk_document.cpp. sk_document_create_pdf_* returned nullptr everywhere, failing SKDocumentTest.CanCreatePdf / PdfFileIsClosed / etc. The Tizen stopgap is fully reverted (PDF is now enabled on every platform via the C++17 backport, #4155 / mono/skia PR #255), so the guard is no longer needed. Restore the unconditional PDF factories. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mattleibow
added a commit
to mono/SkiaSharp
that referenced
this pull request
Jun 12, 2026
[skia-sync] Update Skia to milestone m150 (4.150.0) (#4146) Changes: mono/skia@chrome/m148...chrome/m150 Companion: mono/skia#253 (merged into the skiasharp branch as 94451aa283) Fixes: #4155 (Tizen PDF stopgap, tracked for restore) Advances the bundled Skia from chrome/m148 to chrome/m150, bumping the SkiaSharp native/managed version to 4.150.0. Bumps the externals/skia submodule, regenerates scripts/VERSIONS.txt (skia release m150, libSkiaSharp milestone/soname 150, SkiaSharp assembly/file 4.150.0.0), updates SKIASHARP_VERSION in azure-templates-variables.yml, and refreshes cgmanifest.json (chrome_milestone 150, upstream_merge_commit c92514572e, Skia repo ref 94451aa283) for CVE/component tracking. m150 pulled in new C++20 surface area that broke three native legs, each with a distinct root cause. The fixes live in the mono/skia fork (companion PR #253) and a small amount of SkiaSharp pipeline config; this PR pins the merged fork commit and wires the build to it. ~~ Native build fixes (via fork PR #253) ~~ * Windows: m150's SkFontMgr_win_dw.cpp onMatch() now uses IDWriteFontSet4, which requires the Win11 SDK (10.0.22621). The build was resolving an older SDK and failing with "use of undeclared identifier 'IDWriteFontSet4'". Added a min_win_sdk_version floor in the fork's gn so the MSVC toolchain selects 10.0.22621+ when present, rather than pinning one exact version. Runtime-safe: the interface is acquired via QueryInterface with a null-check fallback to the legacy path, and the OS floor and DLL imports are unchanged (verified by CheckWindowsDependencies). * WASM (.NET 8 / emscripten 3.1.34, libc++ 15): SkPDFTag.cpp used std::views::reverse, gated behind incomplete-features and disabled in libc++ 15. Rewrote the single use as a reverse-iterator loop that also compiles under Tizen clang 10. The .NET 9 leg (libc++ 17) was unaffected. * Tizen (clang 10 + gcc 9.2 libstdc++, pre-C++20): m150's PDF backend now needs <compare> and ranges. Rather than disable PDF (which would regress SKDocument), backported the PDF sources to C++17 so PDF stays enabled on Tizen. Also fixed an optional::emplace and an SkOpts -march mismatch surfaced by the older toolchain. * D3D: fixed GrD3DBackendSurface.cpp to compile without GPU_TEST_UTILS, matching the m150 base-class change (FormatData::equal is unconditional; Texture/RenderTarget::equal are test-utils-gated) and the existing Vulkan backend. ~~ Submodule pin ~~ Re-pins externals/skia to 94451aa283, the merge commit of fork PR #253 on the stable skiasharp branch (tree-identical to the integration tip bceb12ad2c), and corrects the cgmanifest Skia commit reference to match. Full CI is green: build 158235 succeeded across all native platforms (Windows/macOS/Linux/WASM), managed build, API diff, tests, and samples. Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated upstream merge of
chrome/m150.Companion SkiaSharp PR: mono/SkiaSharp#4146
mono/skia PR Summary: Merge upstream Skia m148 → m150
Overview
Merged upstream
chrome/m150intoskia-sync/m150, starting from the fork'sskiasharpbranch (HEAD1a155bae3a). This advances the Skia engine from Chrome milestone 148 to 150.Merge Details
Merge commit:
0a248d1b82— "Merge upstream chrome/m150 into skia-sync/m150"Upstream tip merged:
c92514572e(tip ofupstream/chrome/m150)Conflicts resolved: 19 files
Branch tip:
bceb12ad2c(merge + post-merge portability fixes — see "Post-Merge Portability Fixes" below)Conflict Resolutions
DEPSRELEASE_NOTES.mdinclude/core/SkFont.hbreakText()overloads AND added upstream's newSkStrikeRef makeStrikeRef()src/base/SkSafeMath.hsrc/core/SkPixmap.cppsrc/core/SkRuntimeEffect.cppsrc/gpu/ganesh/SurfaceContext.cppsrc/gpu/ganesh/ops/AtlasTextOp.cppglyphSrcPadding()>0check with upstream'satlasManager->supportsBilerp()condition; took upstream's graceful stride-mismatch handling (log+return instead of hard assert)src/gpu/graphite/(5 files)src/pathops/SkOpCoincidence.{cpp,h}src/sksl/analysis/SkSLGetLoopUnrollInfo.cpptests/RegionTest.cpp// TODO(kjlubick)comment + added upstream's newRegion_setRectstest (the TODO comment was later dropped to match upstream)tests/SkGlyphTest.cpptests/SkRuntimeEffectTest.cppSkRuntimeShader_b507643404testBreaking Changes in m148→m150 (Assessment)
SkRegion::setRectssignature change toSkSpan<const SkIRect>setRectsSkShader::isOpaque()pure virtualSkStrikeRefnew class +SkFont::makeStrikeRef()SkFont.hmanual mergeSkFont.hSkLog.hgains#include <cstdarg>Post-Merge Portability Fixes
The merge compiled on the primary toolchains, but SkiaSharp's full CI (
SkiaSharp (Public)) builds the native libraries on older / niche toolchains (WASM emscripten 3.1.34 / libc++ 15, Tizen clang 10 + gcc 9.2, and the D3D backend on Windows) that upstream Skia CI does not. The following fork commits sit on top of the merge to make m150 build everywhere:047210c1bfTODO(kjlubick)comment inRegionTest.cppto match upstream8912293c37std::views::reverse→ reverse-iterator loop inSkPDFTag.cpp(libc++ 15 / clang 10 lack enabled ranges)d0b422e9c9(+ merge391fb705ff, PR #255)<=>/==to explicit C++17 operators (SkPDFTypes.h,SkPDFTag.cpp) — Tizen libstdc++ predates<compare>. Resolves #4155d2fe11b410min_win_sdk_versionfloor to10.0.22621.0ingn/BUILDCONFIG.gnso the MSVC toolchain selects the Win11 SDK that definesIDWriteFontSet4(m150SkFontMgr_win_dw.cpp). Floor, not a pin144ebf96d5optional::emplaceon aggregate → aggregate-init (libstdc++ 9.2)a8ea924948opts("ml3")/opts("ml4")use clang-10-march=haswell/skylake-avx512(m150'sx86-64-v3/v4need clang ≥ 12); keeps m150's new-mprefer-vector-width=512159b1ec9e5GrD3DBackendSurface.cpp:GrBackendFormatData::equalunconditional,GrBackendTextureData::equalfully guarded underGPU_TEST_UTILS— completes upstream20c304440c, which left the D3D backend abstract in non-test builds (only SkiaSharp compiles D3D)bceb12ad2cSK_SUPPORT_PDFguard insrc/c/sk_document.cpp— the C-API shim compiles into:core, which never receives:pdf'sSK_SUPPORT_PDFpublic define, so the guard was always false → PDF factories returned null everywhere (caught bySKDocumentTest)These are toolchain/portability fixes only — no change to Skia rendering behavior on any platform. Azure DevOps
SkiaSharp (Public)build 158224 is green across all stages (Native Windows/macOS/Linux/WASM, Native, Package NuGets, API Diff, Build Managed, Tests, Samples).Items Needing Human Attention
DEPS pinning: Fork continues to use custom-pinned native library versions. These were specifically upgraded as security/bug fixes. No action needed but worth tracking during releases.
AtlasTextOp.cpp merge: The upstream gracefully returns on stride mismatch (previously a hard assert). The combined
supportsBilerp() || glyphSrcPadding() > 0condition should be verified with a GPU test environment.SkStrikeRef: New class added upstream. Not exposed in C API yet. Could be future API addition if users request access to glyph strike internals.
Created by skia-upstream-sync.