Skip to content

[skia-sync] Merge upstream chrome/m150#249

Closed
mattleibow wants to merge 934 commits into
skiasharpfrom
skia-sync/m150
Closed

[skia-sync] Merge upstream chrome/m150#249
mattleibow wants to merge 934 commits into
skiasharpfrom
skia-sync/m150

Conversation

@mattleibow

Copy link
Copy Markdown
Collaborator

Automated upstream merge of chrome/m150.

mono/skia: Upstream merge chrome/m150 into skiasharp

Overview

Merges upstream chrome/m150 (commit 86bafa2700) into the skiasharp fork branch.
This brings in Skia milestones 148, 149, and 150.

Upstream merge commit

76b88362da — "Merge upstream chrome/m150 into skiasharp"

Conflict resolutions

File Resolution
DEPS Kept our pinned deps (expat 2.8.1, freetype, harfbuzz 14.2.0, libjpeg-turbo 3.1.4.1, libpng 1.6.58, libwebp, zlib 1.3.2.1, vulkanmemoryallocator, vulkan-headers); accepted upstream structure changes for brotli/skcms/dawn
include/core/SkFont.h Combined: kept fork-specific breakText() overloads AND added upstream makeStrikeRef() method from m150
RELEASE_NOTES.md Took upstream (adds m148/m149/m150 release notes)
include/utils/SkEventTracer.h Took upstream (updated onExit() comment)
src/utils/SkEventTracer.cpp Took upstream (adds atexit([]() { GetInstance()->onExit(); }) in SetInstance())
src/core/SkPixmap.cpp Took upstream (upstream adopted our RGBA/BGRA fix)
src/core/SkRuntimeEffect.cpp Took upstream
src/gpu/graphite/mtl/MtlCaps.mm Took upstream (Graphite — not used by SkiaSharp)
third_party/harfbuzz/BUILD.gn Kept ours (matches our pinned HarfBuzz 14.2.0)
modules/skcms/version.sha1 Took upstream (6010f358…)
infra/bots/tasks.json Took upstream
tests/RegionTest.cpp, tests/SkRuntimeEffectTest.cpp Took upstream

C API shim fixes (commit fabf585923)

kR16_float_SkColorType was inserted in the middle of the SkColorType C++ enum in m148
(between kA16_float and kRG16_float). This shifts all subsequent integer values by 1.

Changes:

  • include/c/sk_types.h: Added R16_FLOAT_SK_COLORTYPE between A16_FLOAT_SK_COLORTYPE and R16G16_FLOAT_SK_COLORTYPE
  • src/c/sk_enums.cpp: Added static_assert((int)SkColorType::kR16_float_SkColorType == (int)R16_FLOAT_SK_COLORTYPE, ...)

Items needing human attention

  • SkFont.breakText() is fork-specific: This method exists only in our fork and must be preserved in every upstream merge. The conflict in include/core/SkFont.h was carefully resolved to keep our breakText() overloads alongside the new upstream makeStrikeRef() method.

  • HarfBuzz pin: Our third_party/harfbuzz/BUILD.gn lists source files matching our pinned HarfBuzz 14.2.0. Upstream has a newer version with different source files. This MUST be kept as ours until HarfBuzz is separately bumped.

  • DEPS strategy: We keep explicit pinned SHAs for security-critical dependencies (expat, libpng, zlib, harfbuzz, libjpeg-turbo, libwebp). These should only be updated in dedicated security/dependency-bump PRs, not in milestone syncs.

Created by skia-upstream-sync.

recipe-roller and others added 30 commits May 6, 2026 19:35
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8682503672699218961

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/89aade9865c132c78ae28dbfb44111ae03322153
  89aade9 (chanli@google.com)
      [TurboCI] add `query_nodes` steps to placeholder recipe

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I138df8fd913d8780d40fd50c0a30e2cc79b345ac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1228096
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8682498012931576609

depot_tools:
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/8a58b411c2ee5869edbd00672c9c78b943039ff1
  8a58b41 (rop@google.com)
      Add detailed license validation status checks for milestone rev...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I43f0de9e967c67d778ca430294fff35eb4f24fa5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1228156
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://dawn.googlesource.com/dawn.git/+log/b64fc1768c2d..b048990c1246

2026-05-06 bsheedy@google.com Suppress more Pixel 10 failures
2026-05-06 alanbaker@google.com [glsl] Support buffer_view
2026-05-06 jrprice@google.com [hlsl] Add MatrixLayout type
2026-05-06 jrprice@google.com [hlsl] Add DXC header dir to include path for Tint
2026-05-06 rharrison@chromium.org [tint] Validate member of structs, even if they are not referenced
2026-05-06 cwallez@chromium.org [dawn][native] Remove kIndexOfDefault in ResourceTableDefaultResources
2026-05-06 jrprice@google.com [hlsl] Refactor common code in DecomposeStorageAccess
2026-05-06 cwallez@chromium.org [dawn][native] Quantize timestamp even on 1ns timestamp hardware
2026-05-06 rharrison@chromium.org [val] Enforce limit to location number for spirv backend
2026-05-06 dsinclair@chromium.org Use a lambda worklist
2026-05-06 jrprice@google.com [hlsl] Add support for Shader Model 6.10
2026-05-06 jrprice@google.com [tint] Use enum for --hlsl-shader-model option
2026-05-06 jrprice@google.com [d3d] Add platform feature to use HLSL 2021
2026-05-06 cwallez@chromium.org Revert "vulkan: Implement coherent FramebufferFetch"
2026-05-06 hitawala@chromium.org [vulkan] Add Vulkan.VkQueueSubmitUS metric for Vulkan QueueSubmits
2026-05-06 jiawei.shao@intel.com Rename `chromium_experimental_subgroup_size_control` to `subgroup_size_control`
2026-05-06 bajones@chromium.org Eagerly drop refrerences held by workaround callback
2026-05-06 bajones@chromium.org Fix OOB read due to RenderBundle indirect draw validation
2026-05-05 petermcneeley@google.com [tint] Missing tint end2end files
2026-05-05 rharrison@chromium.org [ir] Ensure that decoded identifiers are valid for WGSL
2026-05-05 jrprice@google.com [hlsl] Use HLSL 2021 for Tint tests and fuzzers
2026-05-05 jrprice@google.com [hlsl] Use HLSL 2021 select() instead of ternary
2026-05-05 dawn-automated-expectations@chops-service-accounts.iam.gserviceaccount.com Roll third_party/webgpu-cts/ 5c6b119c4..3b327ebc4 (7 commits)
2026-05-05 jrprice@google.com [hlsl] Add compiler target for DXC with HLSL 2021
2026-05-05 jiawei.shao@intel.com Support Intel Wildcat Lake integrated GPU family in `gpu_info.json`
2026-05-05 jiawei.shao@intel.com Remove all attributes about "subgroup_size_control" in `AdapterInfo`
2026-05-05 chrome-branch-day@chops-service-accounts.iam.gserviceaccount.com Activate dawn M149
2026-05-05 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 6cc7757d2bd0 to f9d5d49a3c59 (2 revisions)
2026-05-05 bajones@chromium.org Begin tracking validated IndirectDraw in a side table.
2026-05-04 rharrison@chromium.org [val] Tighten up bypass for kMslAllowEntryPointInterface
2026-05-04 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 61c46b826e6d to 5f0e794041ec (12 revisions)
2026-05-03 chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com Remove stale WebGPU Compat CTS expectations
2026-05-02 chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com Remove stale WebGPU CTS expectations
2026-05-01 kylechar@google.com Add suffix to monolithic pipeline cache key
2026-05-01 bsheedy@google.com Suppress more Pixel 10 failures
2026-05-01 kylechar@google.com vulkan: Implement coherent FramebufferFetch
2026-05-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 89556131bf9d to 6cc7757d2bd0 (1 revision)
2026-05-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 325082aabbed to 61c46b826e6d (31 revisions)
2026-05-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from d73829d4e677 to fe2615732899 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC cwallez@google.com,lokokung@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac14-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11
Bug: None
Tbr: lokokung@google.com
Change-Id: I2bb440e4a6fe086d84f8adc964213e644f415d7b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1227699
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://skia.googlesource.com/buildbot.git/+log/c08a2903efbe..f7c1e4ac4125

2026-05-06 eduardoyap@google.com [Pinpoint] Expose QueryPairwise RPC in service.proto
2026-05-06 viktarzinkou@google.com Fix peak detection for Mann-Whitney U test by inverting P-value magnitude
2026-05-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-final from a02a13f6c998 to 030bdcebf467
2026-05-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll command_wrapper from 4aa4301c3b8178f97... to c22572d57995c53bb... (1 revision)
2026-05-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Depot Tools from 22366974605e to fba5d8a8b46a (5 revisions)
2026-05-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-final from 5f3c62ec6e6e to 9b60011b738f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/infra-skia
Please CC kjlubick@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kjlubick@google.com
Change-Id: Icc81fcdd05109368f95413678e25be804190177d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1228062
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/angle/angle.git/+log/997936e81bd4..95d16933d919

2026-05-07 amaiorano@google.com Vulkan: fix potential OOB read in reformatStagedBufferUpdates
2026-05-07 yuxinhu@google.com Skip BasicCopyTextureTest.SelfCopyOOBWrite*GLES on Pixel 10
2026-05-07 bsheedy@chromium.org Remove win-perf builders
2026-05-07 kbr@chromium.org GL: Add recreateFboUponFlush workaround.
2026-05-07 m.maiya@samsung.com Skip trex_200 on S24 bot
2026-05-06 yuxinhu@google.com Skip AttachToMultipleCubeFacesThenMSRTT tests on Pixel 10
2026-05-06 syoussefi@chromium.org Vulkan: Re-enable dynamic state on JM Mali on r51+
2026-05-06 syoussefi@chromium.org Require that src texture is fb-complete in glCopy*Texture*
2026-05-06 zork@google.com [ANGLE][Metal] Fix GPU memory disclosure in index rewriting
2026-05-06 chenyanx.zhu@intel.com EGL: fix eglChooseConfig crash when EGL_CONFIG_ID is EGL_DONT_CARE
2026-05-06 zmo@chromium.org [angle] Use full logic for HLSL short-circuit unfolding.
2026-05-06 cclao@google.com Vulkan: Limit VertexConversionBuffer to single attribIndex
2026-05-06 bsheedy@chromium.org Calculate commit position in perf test script
2026-05-06 syoussefi@chromium.org Vulkan: Fix removing staged updates during cube map redefine
2026-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from f8972f88c952 to 7a23dfb3e490 (695 revisions)
2026-05-06 syoussefi@chromium.org Translator: Verify that qualifiers are paired with in/out
2026-05-06 solti@google.com Android: Bump com.android.angle targetSdkVersion to 37
2026-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 3fe33a325af9 to 979a45ec1bb1 (4 revisions)
2026-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f02244db668b to 0cac26b01455 (25 revisions)
2026-05-06 victorvianna@google.com Clarify C++ standard in .clang-format

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC alexisdavidc@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win11-Clang-Dell3930-GPU-GTX1660-x86_64-Debug-All-ANGLE
Tbr: alexisdavidc@google.com
Test: Test: angle_end2end_tests --gtest_filter="EGLChooseConfigTest.ConfigIdDontCare*"
Change-Id: I851057cee588973d58305b914ba355825f20e4ae
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1228118
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/766d49b68e2f..a4ff3c87bd50

Also rolling transitive DEPS:
  https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/a96bd4933c6adfc21329d15e9999791a0153bbf3..d88097b51e70f357a96237c4571ded3433ccde99

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC alexisdavidc@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: alexisdavidc@google.com
Change-Id: I3701b76677608d9196952d0b383264f16caf832e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1228476
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Change-Id: Ib2a1a9b2a87e3beb637c2af160f7af460b62b325
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1227756
Reviewed-by: Alexis Cruz-Ayala <alexisdavidc@google.com>
Commit-Queue: Alexis Cruz-Ayala <alexisdavidc@google.com>
Auto-Submit: Jorge Betancourt <jmbetancourt@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8682443906884557681

depot_tools:
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/a9e01d55dbd1213e45cf9465aff7091cedc1f7c2
  a9e01d5 (gavinmak@google.com)
      Revert "Support parallel DEPS hooks"

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I988bed0d2c2aef37e80f681318ced436150e89b3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1228956
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Change-Id: Ic92ae7fd7087a188a4a3ca523a75808f7ef06eae
Bug: oss-fuzz:506737090
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1229176
Commit-Queue: Kaylee Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Kaylee Lubick <kjlubick@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8682429436236628945

depot_tools:
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/059acdf446d83eea090f56d674fe038f7607804a
  059acdf (dsanders11@ucsbalum.com)
      gclient_paths: try `<gclient_root>/src/buildtools` for finding...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I99fd1572e7c3760b31ba230a378223efe4c21fb0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1229296
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
An SkPicture can contain an SkReadBuffer which can contain
an SkPicture which contains an SkPicture which can contain
an SkPicture which contains an SkPicture which can contain ...

https://review.skia.org/592736 added support for avoiding
deeply nested skps, but missed the case where a ReadBuffer got
tossed in the mix.

I had a test case for this in PS2, but removed it because it
was effectively just a huge opaque binary checked in and I
didn't want it to get stale eventually.

Bug: 496175229
Fixed: 496175229
Change-Id: I6183a78ed5a69499cb457d16d7e0fc430bff2b1f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1226696
Reviewed-by: Florin Malita <fmalita@google.com>
Commit-Queue: Kaylee Lubick <kjlubick@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8682423775120777521

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+log/419f0b9a3c8b99726df412e238a6e1f7b7b83e2f~..526437857cd166aa3680db39165847ceab45435d
  419f0b9 (chanli@google.com)
      [TurboCI] placeholder: fix getting workplan ID from current sta...
  5264378 (chanli@google.com)
      [TurboCI] re-enable real TurboCI client in recipes

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6c74c98d69edd79beff7d9b3a9dd08caa9087d09
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1229359
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/a4ff3c87bd50..f2bd0563dba7

Also rolling transitive DEPS:
  https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/8864cdc896bbc2a9b6eb36b3218fc9ef57908d77..7f233bc128bebd91c914ddc3678aa970828031d6
  https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/5d40749670ccde08fd91412d3daa074615940d6a..d2994039d549970c5d8f60603209a947c5241cb2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC alexisdavidc@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: alexisdavidc@google.com
Change-Id: I4a37fe49dc37fa85424149c8961a540aa9ec5859
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1229496
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://skia.googlesource.com/buildbot.git/+log/f7c1e4ac4125..99ee78410476

2026-05-07 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - on - perf/FREEZELOCK
2026-05-07 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - off - perf/FREEZELOCK
2026-05-07 wenbinzhang@google.com Revert "[public's a subset] Add TraceVisibility and TraceParams.is_public"
2026-05-07 wenbinzhang@google.com Revert "[public's a subset] fetch logic"
2026-05-07 eduardoyap@google.com [pinpoint] Support base_extra_args and experiment_extra_args in Pairwise Try Jobs
2026-05-07 borenet@google.com [mcp] Support loading logs in reverse for Skia tasks
2026-05-07 eduardoyap@google.com [Pinpoint] Handle compare pairwise edge cases (NaN/Inf JSON crash)
2026-05-07 eduardoyap@google.com [Pinpoint] Truncate mismatched control/treatment arrays in pairwise runner
2026-05-07 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - on - perf/FREEZELOCK
2026-05-07 eduardoyap@google.com [explore-multi-v2-sk] Support deterministic time range (begin/end) and synchronous drag URL updates
2026-05-07 borenet@google.com [task driver] Support loading log pages in reverse
2026-05-07 ansid@google.com Make shortcuts work on local runs
2026-05-07 faridzad@google.com [Skia] Fix the 'pinpoint/go/workflows/worker' build error.
2026-05-07 mordeckimarcin@google.com Show legacy anomalies on autopush by default
2026-05-07 viktarzinkou@google.com [perf] Provide an option to limit traces in backfilling
2026-05-07 ansid@google.com Rename multi-select-sk to resolve conflict with another multi-select-sk
2026-05-07 sergeirudenkov@google.com [public's a subset] fetch logic
2026-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-final from 030bdcebf467 to 2c96eeafb886
2026-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Depot Tools from fba5d8a8b46a to 8a58b411c2ee (3 revisions)
2026-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-final from 9b60011b738f to 85705a7dd4f0
2026-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll command_wrapper from c22572d57995c53bb... to 5bc13f809f6c32d4b... (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/infra-skia
Please CC kjlubick@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:346836299,chromium:504536191,chromium:508227920
Tbr: kjlubick@google.com
Change-Id: I4d2fe16bb00c1dd5d5b2213d5f3b7c036324b793
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1229776
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8682397350475607793

depot_tools:
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/835fc3f2cb489a1e0a2cf598350d648a28d31e49
  835fc3f (rop@google.com)
      [metadata] Add reciprocal license disallowance

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaf58fbc78fa7eb4aa2ccb81d30813d54fcdfd834
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1229858
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://chromium.googlesource.com/angle/angle.git/+log/95d16933d919..ab41985470ba

2026-05-07 syoussefi@chromium.org AST: Fix variable declaration in dead code in `case`
2026-05-07 solti@google.com Harness: Preserve --gtest_output for Google Test
2026-05-07 syoussefi@chromium.org Add a test for unbound storage images
2026-05-07 syoussefi@chromium.org Revert "GL: Assume GL 3.2+ when deciding caps"
2026-05-07 sergiosolano@google.com Update Span to match modern base::span patterns
2026-05-07 bsheedy@chromium.org Remove win-perf //infra/specs entries
2026-05-07 syoussefi@chromium.org EGL: Fix UAF if initialization fails
2026-05-07 syoussefi@chromium.org MSL: Inspect loop init/cond/expr in loop-forward-progress
2026-05-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0cac26b01455 to 9cab38ea0404 (7 revisions)
2026-05-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7a23dfb3e490 to 19bd71e8d112 (790 revisions)
2026-05-07 syoussefi@chromium.org Test that gl_Clip/CullDistance cannot be redeclared without size

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC alexisdavidc@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win11-Clang-Dell3930-GPU-GTX1660-x86_64-Debug-All-ANGLE
Tbr: alexisdavidc@google.com
Test: Test: b/510380885#comment2, b/510380885#comment3
Change-Id: I55169864a31e2473dae79a0f15372948574c4177
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1229658
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/f2bd0563dba7..df94adb30172

Also rolling transitive DEPS:
  https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/1f2dd1627ae782fa999b6ed86514c6a905438e3c..58006c901d1d5c37dece6b6610e9af87fa951375
  https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/7f233bc128bebd91c914ddc3678aa970828031d6..0e9de566b7d4051c5cc1b762e242c46565956bdf
  https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/d2994039d549970c5d8f60603209a947c5241cb2..353f23f2c0bdf90bce0df551633c5ed873f530ba
  https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/d88097b51e70f357a96237c4571ded3433ccde99..8752119a6a407bac16313d38f3e935c8d619b089

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC alexisdavidc@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: alexisdavidc@google.com
Change-Id: Iec3f7a322c4e802e8b857d5d93b6632f154b1b55
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1229751
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bug: b/502632493
Change-Id: If70ed0b515a52c57f211e7410d36caf0af368596
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1218399
Reviewed-by: Julia Lavrova <jlavrova@google.com>
Auto-Submit: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Florin Malita <fmalita@google.com>
Commit-Queue: Florin Malita <fmalita@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8682361489172267633

depot_tools:
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/d18b0f4fe3d0311cbc269f91813fbb7b6cf3dcb3
  d18b0f4 (agrieve@chromium.org)
      Improve the "build finished" message for agents

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I66fb85c29c13c53c86a8ab03971c40ef03e28964
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1230241
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This reverts commit 5a12179.

Reason for revert: Tint supports F16+FramebufferFetch now

Original change's description:
> Disable FramebufferFetch for Android
>
> Dawn/Vulkan doesn't support FramebufferFetch and ShaderF16 used
> together. Disable FramebufferFetch until that is resolved.
>
> Bug: b/493892934
> Change-Id: I07e3630e1d8b9582db712351738b0f5b25150c8c
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1226596
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Kyle Charbonneau <kylechar@google.com>

Bug: b/493892934
Change-Id: I523fc8518fceb4ff683c77dfef43978ec372e75c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1230737
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Kyle Charbonneau <kylechar@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8682319966624920177

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/70bb072f0c4b15194060aafbafe3e0ce79a0387f
  70bb072 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 3df8f33fc497 to af8531728740

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8cf1b908e403474982bba4b53dba858fdcfb3206
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1230418
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/df94adb30172..3a658da10db4

Also rolling transitive DEPS:
  https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/0e9de566b7d4051c5cc1b762e242c46565956bdf..8cfaaa1d4deedc865e52a42e654c5ec0d7d75eb0
  https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/353f23f2c0bdf90bce0df551633c5ed873f530ba..ead00c13573f705b49130425cb38d70bd2aea0cb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC alexisdavidc@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: alexisdavidc@google.com
Change-Id: I95cb11b42a50c665d188ab3d7728efb0b1848062
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1230464
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skp-skia
Please CC jmbetancourt@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SKP CIPD package: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: jmbetancourt@google.com
Change-Id: I6c97b4d6d55b7b9058ae09bb59becc3cfb184e07
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1230956
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/3a658da10db4..e069d6e7382e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC jmbetancourt@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: jmbetancourt@google.com
Change-Id: Ic234b03c4ed1f56ca61ceba5921da3d09b6581e1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1231096
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/debugger-app-base-skia
Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: borenet@google.com
Change-Id: I84d52ef72e3aafd00031e36563893e14072c011e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1231217
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://skia.googlesource.com/buildbot.git/+log/99ee78410476..4ff5776b821e

2026-05-08 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - off - perf/FREEZELOCK
2026-05-08 zhanliang@google.com [CBB] Use team alias for failure notification emails
2026-05-08 zhanliang@google.com Revert "[pinpoint] Support base_extra_args and experiment_extra_args in Pairwise Try Jobs"
2026-05-08 zhanliang@google.com [CBB] Improve failure emails
2026-05-08 sergeirudenkov@google.com Reland "[public's a subset] Add TraceVisibility and TraceParams.is_public"
2026-05-08 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - on - perf/FREEZELOCK
2026-05-08 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - off - perf/FREEZELOCK
2026-05-08 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - on - perf/FREEZELOCK
2026-05-08 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - off - perf/FREEZELOCK
2026-05-08 sruslan@google.com Make suggestions in multi-explore view query-specific.
2026-05-08 sruslan@google.com Extract trace type definitions to a separate file.
2026-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-final from 85705a7dd4f0 to 0bea37cb1de7
2026-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll command_wrapper from 5bc13f809f6c32d4b... to a1663394b3c883bb9... (1 revision)
2026-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Depot Tools from 8a58b411c2ee to 86ddfc92bce7 (4 revisions)
2026-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-final from 2c96eeafb886 to 79350e38c42b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/infra-skia
Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:346836299,chromium:504536191
Tbr: borenet@google.com
Change-Id: Ibe10c8515d1022ba725ade293d23852d424e94c7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1231198
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8682128072539906401

depot_tools:
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/7b46edbbedc92d910a485815c2499d74254b4f74
  7b46edb (wnwen@google.com)
      Add EPL-2.0 to allowlist

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ica02316e07b2804bbd3bc11c315287f4c0acacbc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1231202
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://chromium.googlesource.com/angle/angle.git/+log/ab41985470ba..2d8f36f37859

2026-05-10 kbr@chromium.org Add !isMesa to recreateFboUponFlush workaround.
2026-05-08 lexa.knyazev@gmail.com Remove unrelated code from image data size validation
2026-05-08 cclao@google.com Vulkan: Fix bug with framebuffer layer change without rebind
2026-05-08 syoussefi@chromium.org Update test to match ANGLE's style
2026-05-08 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll Chromium from 19bd71e8d112 to 7d34a38cf72c (905 revisions)
2026-05-08 bsheedy@chromium.org Remove legacy win-trace builder
2026-05-08 m.maiya@samsung.com Vulkan: Unconditionally enable GL_ANGLE_rgbx_internal_format extension
2026-05-08 ynovikov@chromium.org Skip DeleteTextureBoundToImageUnit on Pixel 10 GLES
2026-05-08 bsheedy@chromium.org Add src-side win-trace equivalent
2026-05-08 kbr@chromium.org Restrict recreateFboUponFlush workaround.
2026-05-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9cab38ea0404 to 4c5f45e113d5 (24 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC jmadill@google.com,jmbetancourt@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win11-Clang-Dell3930-GPU-GTX1660-x86_64-Debug-All-ANGLE
Tbr: jmbetancourt@google.com
Change-Id: I33aa1b6dcbf9eb66a21f3dd770be77143f0ea5f8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1231099
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/e069d6e7382e..4391cb02adc5

Also rolling transitive DEPS:
  https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/58006c901d1d5c37dece6b6610e9af87fa951375..98c842bd561ac67c5ff98d599c8c960ba9edb7fd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC jmbetancourt@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: jmbetancourt@google.com
Change-Id: Ie0b9b9104427d133ca5af134f25ef3bc912cccdd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1231284
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Change-Id: I9dae8bb736f4e45586db584e8c28421464392b95
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1160878
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Thomas Smith <thomsmit@google.com>
kjlubick and others added 18 commits May 29, 2026 13:51
This is a clang-tidy warning with newer versions of clang.

Change-Id: I5ebe52ea7b3a7fb11454c5c2d17ca811086a5de1
Bug: 451917121
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1249797
Reviewed-by: Thomas Smith <thomsmit@google.com>
Commit-Queue: Thomas Smith <thomsmit@google.com>
Auto-Submit: Kaylee Lubick <kjlubick@google.com>
Commit-Queue: Kaylee Lubick <kjlubick@google.com>
RETURN_FAIL_IF(!info.fRecording, ...) implies the need for a null check
on info.fRecording in RETURN_FAIL_IF.

Change-Id: I9d664e16ac825a6e87835e94b5e910fcadb70852
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1249756
Auto-Submit: Noelle Scobie <nscobie@google.com>
Commit-Queue: Noelle Scobie <nscobie@google.com>
Reviewed-by: Thomas Smith <thomsmit@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8680434415980351889

depot_tools:
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/f3f28514e02fcf7bb9a7062e287758ee821741eb
  f3f2851 (gavinmak@google.com)
      Exempt IFTTT comments in mojom files from CheckLongLines

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id6c8b5dc5569a9dfa01cd5a3f84a18c88a7d93cc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1249726
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/016cfd464461..b766d9ede7dd

Also rolling transitive DEPS:
  https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/7fa421b3cb2db75c9c8a241fe674f467dd4d240b..5b418e58bd952be2bb13ec613359da64f1ed04ba

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC fmalita@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: fmalita@google.com
Change-Id: I608599e1969be9489016c1ad72f13bcd88aab436
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1249579
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/b766d9ede7dd..dcdce5027a08

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC fmalita@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: fmalita@google.com
Change-Id: I8a49203a4228ee5a3481d0964c43bf109ca27e2b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1250156
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/dcdce5027a08..d8c0b6852f61

Also rolling transitive DEPS:
  https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/5b418e58bd952be2bb13ec613359da64f1ed04ba..af15c1bd0e5ec2c3da9e6439bc262cd73c0d79f4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC nicolettep@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: nicolettep@google.com
Change-Id: Ie62da6c638ac9c8075ed2d84046a63e166c466bc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1250276
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/d8c0b6852f61..b57006f9536e

Also rolling transitive DEPS:
  https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/af15c1bd0e5ec2c3da9e6439bc262cd73c0d79f4..39813baec458ada43263749757b15fbfbd6be107

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC nicolettep@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: nicolettep@google.com
Change-Id: Iee85b1537120755b50769d6aa8a205c10eed8f17
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1250377
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://skia.googlesource.com/buildbot.git/+log/db195a05b659..2da962880dc7

2026-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-final from c8dc9f871a83 to ec71bc8087ae
2026-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Depot Tools from 2f9bc10799af to 4bf9218cac07 (1 revision)
2026-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-final from cd0f7fec4181 to b341aa58ae4f
2026-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll command_wrapper from 60f170d7971d1f726... to 2e6f0be1cab54719a... (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/infra-skia
Please CC kjlubick@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kjlubick@google.com
Change-Id: I39f5b37c4e591e7a039dca6c396680cf15a5df96
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1250556
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/angle/angle.git/+log/31b176246d7e..c01fdb7503e3

2026-05-30 valentine.burley@collabora.com Vulkan: Fix Turnip driver version string
2026-05-29 bsheedy@chromium.org Suppress flaky Intel test
2026-05-29 timvp@google.com FramebufferTest: Fix InvalidateIncompleteDepthStencil
2026-05-29 bsheedy@chromium.org Switch Win/x64/rel to historyless
2026-05-29 cclao@google.com Vulkan: Fix ImageTestES3.RenderToYUVAHB regression
2026-05-29 yuxinhu@google.com Add an option to clean the submodules
2026-05-29 cclao@google.com Vulkan: Properly clean up CommandBufferHelpers on context error
2026-05-29 bsheedy@chromium.org Switch Linux/x64/Release to Starlark tests
2026-05-29 geofflang@chromium.org Manual roll third_party/dawn
2026-05-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 9898204d91d6 to d26a3e6606c0 (5 revisions)
2026-05-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4029144db7a0 to 3cececf546e2 (12 revisions)
2026-05-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 0e65a7575c25 to bdd6350bab8e (1600 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC jmadill@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win11-Clang-Dell3930-GPU-GTX1660-x86_64-Debug-All-ANGLE
Tbr: nicolettep@google.com
Test: Test: ./scripts/roll_aosp.sh in android external/angle
Test: Test: angle_end2end_tests \
Change-Id: I99e58854a636479f7bfddaa270bfa32dbc77a5bb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1250496
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Manual roll requested by kjlubick@google.com

https://dawn.googlesource.com/dawn.git/+log/ce586f1e2a62..63f25feec51e

2026-06-01 kjlubick@google.com Fix bazel select for windows
2026-05-31 chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com Remove stale WebGPU Compat CTS expectations
2026-05-31 chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com Remove stale WebGPU CTS expectations
2026-05-30 amaiorano@google.com [native][d3d12] Fix dispatch size 0 not increment dispatch counter
2026-05-30 amaiorano@google.com [native] Fix IndirectDrawValidationEncoder merging non-matching passes
2026-05-30 jrprice@google.com Bandaid fix for X11 header issue
2026-05-29 arthursonzogni@chromium.org infra: Enable Python unit tests for root PRESUBMIT
2026-05-29 bsheedy@google.com Suppress Pixel 10 failures
2026-05-29 alanbaker@google.com [msl] Fix host-shareable struct emission with buffer_view
2026-05-29 jrprice@google.com Bump golang version in DEPS
2026-05-29 kainino@chromium.org Fix cross-compilation for Windows on Mac/Linux
2026-05-29 kainino@chromium.org [gn] Autoformat all GN files
2026-05-29 blundell@chromium.org [GN] Avoid ANGLE dylibs being built when ANGLE is linked statically
2026-05-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a8f28255baa4 to 3cececf546e2 (7 revisions)
2026-05-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e357a3a4893e to 31b176246d7e (6 revisions)
2026-05-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5bdd0d2b0742 to 823a409ba1ef (751 revisions)
2026-05-29 kainino@chromium.org [cmake] Enable dawn_version target in Wasm
2026-05-29 dsinclair@chromium.org Update build file include paths.
2026-05-29 jrprice@google.com [ir] Add DisallowVectorMinMaxClamp property
2026-05-29 jrprice@google.com [ir] Combine scalarization options
2026-05-29 jrprice@google.com [ir] Move AllowOverrides to a property
2026-05-29 kainino@chromium.org [deps] Add clangd as optional dep
2026-05-29 lokokung@google.com [native] Early out storing function in the BlobCache.
2026-05-29 kainino@chromium.org [utils] Move windows_with_undefs.h to utils/
2026-05-29 kainino@chromium.org [utils] Move NonMovable and NonCopyable to utils/
2026-05-29 jrprice@google.com Revert "Reland: [gn] Add support for generated sources"
2026-05-29 lokokung@google.com [fuzz] Make sure that we teardown for fuzzer injected errors.
2026-05-29 dsinclair@chromium.org Update dawn/wire includes
2026-05-29 dsinclair@chromium.org Update dawn/utils includes
2026-05-29 dsinclair@chromium.org Update dawn/tests includes
2026-05-29 jrprice@google.com [ir] Add protobuf support for constexpr_if
2026-05-29 dsinclair@chromium.org Add resource_table transform document.
2026-05-28 jrprice@google.com [fuzz] Add generic mechanism for unsupported properties
2026-05-28 jrprice@google.com [ir] Move AllowMultipleEntryPoints to a property
2026-05-28 cwallez@chromium.org [dawn][vulkan] Put PipelineSpecialization caches under a Mutex.
2026-05-28 cwallez@chromium.org [dawn][common] Signal the CondVar before unlocking the mutex.
2026-05-28 rharrison@chromium.org Add -triage to ./tools/run fuzz
2026-05-28 amaiorano@google.com [native][d3d12] Fix use of incorrect descriptor heaps on cross-pass heap
2026-05-28 jrprice@google.com [ir] Add ValueArrayCount support to protobuf
2026-05-28 dsinclair@chromium.org Update dawn/samples includes
2026-05-28 dsinclair@chromium.org Update dawn/replay includes
2026-05-28 jrprice@google.com [ir] Add override support to protobuf
2026-05-28 cwallez@chromium.org [dawn][vk] Use VkDriverId to decide workaround toggles.
2026-05-28 dsinclair@chromium.org Update dawn/platform includes
2026-05-28 dsinclair@chromium.org Update dawn/partition_alloc includes
2026-05-28 jrprice@google.com [fuzz] Remove SubstituteOverridesConfig helpers
2026-05-28 dsinclair@chromium.org Update dawn/native includes
2026-05-28 jrprice@google.com [ir] Add Property enum to Module
2026-05-28 jrprice@google.com [fuzz] Pass --verbose to assembler during corpus generation
2026-05-28 dsinclair@chromium.org Update dawn/native/webgpu includes
2026-05-28 dsinclair@chromium.org Update dawn/native/vulkan includes
2026-05-28 kainino@chromium.org [utils] Add 'nocompile' testing
2026-05-28 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 6846f3d39e27 to 5bdd0d2b0742 (777 revisions)
2026-05-28 dsinclair@chromium.org Update dawn/native/utils includes
2026-05-28 dsinclair@chromium.org Update dawn/native/stream includes
2026-05-28 dsinclair@chromium.org Update dawn/native/opengl includes
2026-05-28 dsinclair@chromium.org Update dawn/native/null includes
2026-05-28 dsinclair@chromium.org Update dawn/native/metal includes
2026-05-28 dsinclair@chromium.org Update dawn/native/d3d12 includes
2026-05-28 dsinclair@chromium.org Update dawn/native/d3d11 includes
2026-05-28 dsinclair@chromium.org Update dawn/native/d3d includes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC cwallez@google.com,kjlubick@google.com,shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac14-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11
Bug: None
Tbr: shrekshao@google.com,kjlubick@google.com
Change-Id: I9a751a1193f608c2904bfe333f0cd19fe39295b8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1251096
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/b57006f9536e..d418e8ba7c95

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC nicolettep@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: nicolettep@google.com
Change-Id: I0f1704c1c21a1f9802702d26c2ed1ec7b4b25584
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1251136
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Follow-up to https://review.skia.org/1245496. Since we use the
Chromium Windows toolchain (which changed to dynamic ASAN linking
in https://crrev.com/c/5921462) we have to update what we do.

This uses dynamic linking and then copies in the runtime to the
out directory.

Bug: 514697001
Change-Id: I513b1e92b839ae7cade0361b8a757ba1370e45d5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1251116
Reviewed-by: Nicolette Prevost <nicolettep@google.com>
Commit-Queue: Kaylee Lubick <kjlubick@google.com>
Commit-Queue: Nicolette Prevost <nicolettep@google.com>
Change-Id: Ib0d1d9d37a441637038078219fdf0c7c29c2379b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1252356
Bot-Commit: chrome-branch-day <chrome-branch-day@chops-service-accounts.iam.gserviceaccount.com>
Change-Id: I75e49dd1b53884d6af91c691fa1a722758d35e6b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1252244
Bot-Commit: chrome-branch-day <chrome-branch-day@chops-service-accounts.iam.gserviceaccount.com>
A couple more headers have been moved to src/utils/BUILD.bazel.

Change-Id: Ie81ff2519c5e52fbb4bb77c012c8a1233badf1b4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1251476
Reviewed-by: Kaylee Lubick <kjlubick@google.com>
Commit-Queue: Kaylee Lubick <kjlubick@google.com>
Auto-Submit: Florin Malita <fmalita@google.com>
Commit-Queue: Florin Malita <fmalita@google.com>
(cherry picked from commit 886ce5f)
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1252536
Reviewed-by: Florin Malita <fmalita@google.com>
Auto-Submit: Kaylee Lubick <kjlubick@google.com>
Original change's description:
> Turn off LCD in SDF slugs when downscaling too far
>
> LCD text samples the glyph at 1/3 offsets derived from screen-space
> derivatives of its local coords. Each SDF atlas only has 2px of
> transparent padding that these offsets can read into.
>
> If an LCD slug was downscaled after creating its masks by a scale
> of ~0.2, its R and B samples could extend into adjacent glyphs.
> At such a downscaling, the SDF is already fairly low quality because
> it's not sampled by mipmaps. IMO switching to grayscale SDF looked
> better because it approached smooth gray vs. randomized colors.
>
> This applies to both Ganesh and Graphite, although Graphite is able to
> continue to use LCD with SDFs when there's perspective. Since Ganesh
> only uses SkMatrix and not Transform, there's no easy way to estimate
> the perspective scale factors applied over the slug's bounding box.
>
> I tested by modifying GM_slug to use LCD and SDF fonts and interacted
> with viewer's dynamic transforms to trigger the switch between modes.
>
> Bug: 516915337
> Change-Id: Idfa838cfe4ff9443bf2c15078ff52d34a5a5c8f3
> Fixed: 516915337
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1251156
> Reviewed-by: Thomas Smith <thomsmit@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

(cherry picked from commit 95dbfa2)

Bug: 519444909,516915337,516915337
Change-Id: Idfa838cfe4ff9443bf2c15078ff52d34a5a5c8f3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1254076
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
- Resolved DEPS conflicts: kept our pinned expat/freetype/harfbuzz/
  libjpeg-turbo/libpng/libwebp/zlib/vulkanmemoryallocator versions,
  accepted upstream structure changes; kept Dawn/WebGPU deps commented
- Resolved RELEASE_NOTES.md: took upstream (added m148/m149/m150 notes)
- Resolved include/core/SkFont.h: kept fork-specific breakText() methods
  AND added upstream makeStrikeRef() method from m150
- Resolved include/utils/SkEventTracer.h: took upstream comment update
- Resolved src/utils/SkEventTracer.cpp: took upstream atexit() callback
- Resolved src/core/SkPixmap.cpp: took upstream (same logic as our patch)
- Resolved src/core/SkRuntimeEffect.cpp: took upstream
- Resolved src/gpu/graphite/mtl/MtlCaps.mm: took upstream (Graphite)
- Resolved tests/RegionTest.cpp, SkRuntimeEffectTest.cpp: took upstream
- Resolved third_party/harfbuzz/BUILD.gn: kept ours (matches our HB pin)
- Resolved modules/skcms/version.sha1: took upstream
- Resolved infra/bots/tasks.json: took upstream

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kR16_float_SkColorType was inserted between kA16_float and kRG16_float
in m148. Mirror this in the sk_colortype_t C API enum and add the
corresponding static_assert.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Thomas Smith and others added 8 commits June 5, 2026 11:54
Original change's description:
> [ganesh] Prevent overflow in StrokeTessellateOp
>
> Bug: b/519168327
> Change-Id: Ic809a5c9c93018bc584b6284ba1b64205485f83b
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1253636
> Commit-Queue: Thomas Smith <thomsmit@google.com>
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>

(cherry picked from commit dcf3ebf)

Bug: 520437099,b/519168327
Change-Id: Ic809a5c9c93018bc584b6284ba1b64205485f83b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1256017
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
…erflow)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Original change's description:
> Reject Slugs that have creationMatrix with perspective
>
> This shouldn't happen during normal use [1] but if the data
> is corrupted, there are some assumptions that can can cause
> issues, like the ones linked in the bug.
>
> This rejects those and turns one assert into an actual runtime
> check to provide defense in depth.
>
> [1] https://github.com/google/skia/blob/9eecbdc30f7da675edab96974b23174a9d521e0c/src/text/gpu/SubRunContainer.cpp#L1578-L1581
>
> Bug: 520113415
> Fixed: 520113415
> Change-Id: I6ec23df9a23ea588fa89f7a62dc1f197fe3905fd
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1256016
> Commit-Queue: Kaylee Lubick <kjlubick@google.com>
> Reviewed-by: Thomas Smith <thomsmit@google.com>

(cherry picked from commit a145861)

Bug: 520918962,520113415,520113415
Change-Id: I6ec23df9a23ea588fa89f7a62dc1f197fe3905fd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1257276
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
The SkiaSharp C API shims (src/c/sk_typeface.cpp et al.) are compiled as
part of the :core GN target via gn/core.gni. However, SK_FONTMGR_FONTCONFIG_AVAILABLE
is only a public_define on :fontmgr_fontconfig, which does not propagate
up to :core (defines propagate to dependents, not dependencies).

Without this define, sk_fontmgr_create_default() falls through to the
#else branch and returns SkFontMgr_New_Custom_Empty() on Linux, producing
an empty font manager (0 font families). All font/text tests fail because
SKTypeface.Default has 0 glyphs.

The fix mirrors the existing pattern for GPU backend defines (SK_VULKAN,
SK_DIRECT3D, SK_METAL) which face the same issue: they are defined on
:gpu's all_dependent_configs but do not reach :core. The fix explicitly
propagates skia_enable_fontmgr_fontconfig => SK_FONTMGR_FONTCONFIG_AVAILABLE
into :core's defines.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Original change's description:
> Avoid improper mask formats for SDFT runs
>
> SDFTSubRun has a hard assumption of the kA8 mask format and
> if the vertex filler differs, there will be a memory mismatch.
>
> This catches it when deserializing the Slug and changes the
> debug-only assert to be runtime to make sure we don't miss other
> places.
>
> Bug: 520571816
> Fixed: 520571816
> Change-Id: I9ae3e509397e23d38d621cb7eb8bb5b955a43d7d
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1257397
> Commit-Queue: Kaylee Lubick <kjlubick@google.com>
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Reviewed-by: Thomas Smith <thomsmit@google.com>

(cherry picked from commit eac1515)

Bug: 522133313,520571816,520571816
Change-Id: I9ae3e509397e23d38d621cb7eb8bb5b955a43d7d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1260716
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Original change's description:
> [ganesh] Track async task execution for callbacks
>
> The submit proc is invoked with success=true if any tasks were executed
> and the submission of *those* tasks succeeded. Async reads also need
> to be gated on whether or not their actual task was executed.
>
> Bug: 517992755
> Fixed: 517992755
> Change-Id: I75b196111f03873c92b6d2f599a1055ce6a814cf
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1257336
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

(cherry picked from commit 22c683d)

Bug: 522134444,517992755,517992755
Change-Id: I75b196111f03873c92b6d2f599a1055ce6a814cf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1260736
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Merge upstream chrome/m150 bug fixes:
- [M150] [ganesh] Track async task execution for callbacks (c925145)
- [M150] Avoid improper mask formats for SDFT runs (74fb8a4)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mattleibow

Copy link
Copy Markdown
Collaborator Author

Closing this stale auto-generated skia-sync PR. The active milestone work is the m148 update (#4125 / #250); future milestones can be regenerated by the auto-sync workflow when needed.

@mattleibow mattleibow closed this Jun 11, 2026
@mattleibow mattleibow deleted the skia-sync/m150 branch June 11, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.