Add ANGLE to deps_os[win] for Windows-only sync#183
Open
mattleibow wants to merge 1 commit into
Open
Conversation
Move ANGLE dependency from separate clone logic in SkiaSharp's build.cake into the DEPS file using deps_os conditional section. This ensures git-sync-deps handles ANGLE checkout alongside all other dependencies, but only on Windows where it is needed. Pin: chromium/6275 (ea1cea778c4a2312ef1b963b29a62fe595dd4df8) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
deps_ossection to DEPS with ANGLE under thewinkey, sogit-sync-deps winchecks out ANGLE alongside all other Skia dependencies — but only on Windows where it is actually needed for WinUI builds.Pin:
chromium/6275(ea1cea778c4a2312ef1b963b29a62fe595dd4df8)Companion PR: mono/SkiaSharp — updates the cake build system to pass the OS arg to git-sync-deps, moves ANGLE submodule init and setup from winui-angle/build.cake into the shared sync task, and updates all paths.
How
deps_osworks ingit-sync-depsThe existing
git-sync-depsscript already supports adeps_osdictionary in the DEPS file. When an OS name is passed as a CLI arg (e.g.python tools/git-sync-deps win), entries under that OS key are merged into the deps that get cloned. On other platforms (macOS/Linux), ANGLE is never fetched.