Skip to content

[skia-sync] Merge upstream chrome/m148 bug fixes#4251

Closed
mattleibow wants to merge 1 commit into
release/4.148.xfrom
skia-sync/release-4.148.x
Closed

[skia-sync] Merge upstream chrome/m148 bug fixes#4251
mattleibow wants to merge 1 commit into
release/4.148.xfrom
skia-sync/release-4.148.x

Conversation

@mattleibow

Copy link
Copy Markdown
Contributor

Automated upstream bug-fix sync for m148. Targeting release branch release/4.148.x (mono/skia release/4.148.x).

Companion skia PR: mono/skia#264

mono/SkiaSharp PR: Merge upstream chrome/m148 bug fixes

Branch: skia-sync/release-4.148.xrelease/4.148.x

Summary

Bug-fix-only sync of the m148 release line. Two upstream cherry-picks merged with zero conflicts and no C API changes.

Breaking Change Analysis

None. Both upstream commits are internal bug fixes:

Change Risk SkiaSharp Impact
Mac typeface data race fix (SkTypeface_mac_ct) ⚪ NONE Internal thread-safety fix, no API change
Graphite pipeline fix (DawnGraphicsPipeline) ⚪ SKIP Graphite-only, SkiaSharp uses Ganesh

Version/Binding Updates

  • Milestone: Unchanged (m148)
  • VERSIONS.txt: Unchanged
  • cgmanifest.json: commitHash updated to 0ea9171b7f89b9876b835814b89f2dc366eeee95
  • Generated bindings: No changes (no C API diff)

C# Changes

None required — no new functions, no signature changes.

Build/Test Results

  • Native build: ✅ Passed (Linux x64)
  • C# build: ✅ 0 errors, 0 warnings
  • Tests: ✅ Passed: 5544, Skipped: 172, Failed: 0, Total: 5716

Items Needing Human Attention

None — clean sync with all tests passing.

Created by skia-upstream-sync.

Upstream cherry-picks merged into release/4.148.x:
- [m148] Resolved a Data Race on fStream in SkTypeface_Mac
- [graphite] Use stable collection for static bindings

Bug-fix-only sync (m148 release line). No C API changes, no version
bumps. Only cgmanifest.json commitHash updated.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

📦 Try the packages from this PR

Warning

Do not run these scripts without first reviewing the code in this PR.

Step 1 — Download the packages

bash / macOS / Linux:

curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 4251

PowerShell / Windows:

iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 4251"

Step 2 — Add the local NuGet source

dotnet nuget add source ~/.skiasharp/hives/pr-4251/packages --name skiasharp-pr-4251
More options
Option Description
--successful-only / -SuccessfulOnly Only use successful builds
--force / -Force Overwrite previously downloaded packages
--list / -List List available artifacts without downloading
--build-id ID / -BuildId ID Download from a specific build

Or download manually from Azure Pipelines — look for the nuget artifact on the build for this PR.

Remove the source when you're done:

dotnet nuget remove source skiasharp-pr-4251

@mattleibow mattleibow closed this Jun 25, 2026
@mattleibow mattleibow deleted the skia-sync/release-4.148.x branch June 25, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant