[skia-sync] Update skia to milestone 149#4141
Closed
mattleibow wants to merge 1 commit into
Closed
Conversation
- Update Skia submodule to chrome/m149 - Update milestone from 148 to 149 in VERSIONS.txt - Reset SK_C_INCREMENT to 0 (no new C API additions) - Update cgmanifest.json with new commit hash and chrome_milestone Breaking changes (m148→m149): None affecting C API shim. - SkCodec::Register removed (not used in C API) - SkShader::isOpaque() made pure virtual (not subclassed in C API) - SkFontMgr new match()/fallback() APIs (additive, not wrapped yet) - GpuStatsFlags bitfield ops (Graphite only, skip) Build: Linux x64 native build clean Tests: 5300 passed, 172 skipped (GPU/platform), 0 failed Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
📦 Try the packages from this PRWarning Do not run these scripts without first reviewing the code in this PR. Step 1 — Download the packages bash / macOS / Linux: curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 4141PowerShell / Windows: iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 4141"Step 2 — Add the local NuGet source dotnet nuget add source ~/.skiasharp/hives/pr-4141/packages --name skiasharp-pr-4141More options
Or download manually from Azure Pipelines — look for the Remove the source when you're done: dotnet nuget remove source skiasharp-pr-4141 |
Contributor
|
📖 Documentation Preview The documentation for this PR has been deployed and is available at: 🔗 View Staging Site This preview will be updated automatically when you push new commits to this PR. This comment is automatically updated by the documentation staging workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Skia milestone bump from m148 to m149.
Companion skia PR: mono/skia#252
mono/SkiaSharp PR Summary: Update Skia to milestone m149
Overview
Updates SkiaSharp to Skia milestone m149. The submodule
externals/skianow points tothe
skia-sync/m149branch in mono/skia.Changes
Version Files Updated
scripts/VERSIONS.txtcgmanifest.jsonSubmodule Update
externals/skiaupdated from1a155bae3a(m148) to2d0db2d5e8(m149 merge)SK_C_INCREMENT= 0 (no new C API additions this milestone)Bindings
binding/SkiaSharp/SkiaApi.generated.cs: No changes — C API signatures unchangedBreaking Change Analysis (m148→m149)
All changes are either additive (new APIs) or Graphite-only (which SkiaSharp uses Ganesh, not Graphite).
SkCodec::RegisterremovedSkShader::isOpaque()pure virtualSkFontMgrnewmatch()/fallback()SkFontArgumentstag constantsNo breaking changes to public SkiaSharp API. No
[Obsolete]attributes needed.Build Results
-stdlib=libstdc++override due to missing libc++ headers on this runner;CI Docker containers use the proper libc++ setup via
.NET cross-compilation imagesTest Results
Note on HarfBuzz failures: All 207 HarfBuzz test failures are pre-existing on
main(
EntryPointNotFoundException: hb_blob_create_from_file). Confirmed by running the sametest against the m148 baseline — same failure. Not caused by this PR.
Skipped tests (172) are expected: GPU tests skipped without hardware, platform-specific
tests skipped on Linux, etc.
Items Needing Human Attention
HarfBuzz test failures (pre-existing):
hb_blob_create_from_fileentry point not found.This should be investigated separately as a potential HarfBuzz binding issue.
New
SkFontMgrAPIs:match(Request)andfallback(Request)are new in m149.Consider exposing via
/api-add-reviewin a future PR for better font matching in SkiaSharp.libc++ on CI runners: The automated build outside Docker requires libc++ headers.
The actual CI pipeline uses Docker containers with proper libc++ setup — this is only
an issue for local/agent builds outside the Docker environment.
Created by skia-upstream-sync.