[skia-sync] Update skia to milestone 149#4118
Closed
mattleibow wants to merge 1 commit into
Closed
Conversation
- Merge upstream chrome/m149 into skia-sync/m149 submodule - Add R16_FLOAT_SK_COLORTYPE to C API (kR16_float_SkColorType added in m148) - Regenerate SkiaApi.generated.cs: R16Float = 21, shifts R16g16Float–R8Unorm up by 1 - Add SKColorType.R16Float to Definitions.cs, EnumMappings.cs, GRDefinitions.cs - Bump milestone 147→149 in VERSIONS.txt, cgmanifest.json Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
📦 Try the packages from this PRWarning Do not run these scripts without first reviewing the code in this PR. Step 1 — Download the packages bash / macOS / Linux: curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 4118PowerShell / Windows: iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 4118"Step 2 — Add the local NuGet source dotnet nuget add source ~/.skiasharp/hives/pr-4118/packages --name skiasharp-pr-4118More options
Or download manually from Azure Pipelines — look for the Remove the source when you're done: dotnet nuget remove source skiasharp-pr-4118 |
Collaborator
Author
|
Closing this stale auto-generated skia-sync PR. The active milestone work is the m148 update (#4125 / mono/skia#250); future milestones can be regenerated by the auto-sync workflow when needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Skia milestone bump from m147 to m149.
Companion skia PR: mono/skia#247
mono/SkiaSharp PR: Skia m147 → m149
Version Changes
Breaking Change Analysis: kR16_float_SkColorType
Severity: 🔴 HIGH — inserted mid-enum, shifted all subsequent values +1
R16FloatRgF16Alpha16R16UnormNote: Existing
SKColorTypepublic enum values for all previously-existing members are unchanged (RgF16 = 15,Alpha16 = 16, etc.). Only the internalSKColorTypeNativegenerated enum values shifted; the mapping layer (EnumMappings.cs) handles the translation transparently. Public ABI is preserved.Files Changed
C# Binding Changes
binding/SkiaSharp/SkiaApi.generated.csR16Float = 21, shifted subsequent native enum valuesbinding/SkiaSharp/Definitions.csSKColorType.R16Float = 28to public enum; added 2-bytes-per-pixel, shift=1, Opaque alpha typebinding/SkiaSharp/EnumMappings.csR16Float ↔ R16Floatto bothToNativeandFromNativemappingsbinding/SkiaSharp/GRDefinitions.csR16Float => R16FGL sized format mappingVersion Files
scripts/VERSIONS.txtcgmanifest.jsonBuild Results
libSkiaSharp.so.149.0.0,libHarfBuzzSharp.so.0.61420.0libc++-dev. Built using NDK clang with patched libc++ headers (ABI namespace patched tostd::__1::to match NDK's Linuxlibc++.a).Test Results
Verified Working
Pre-existing Failures (61 tests, all font/typeface related)
All 61 failures are in
SKFontTest,SKPaintTest,SKTypefaceTest,SKFontManagerTest,SKFontStyleSetTest.Root cause:
SKTypeface.Default.FamilyNamereturns empty string on this runner.legacyMakeTypeface(null)returns a valid typeface handle, but with empty family namefc-matchfinds "DejaVu Sans")tests/Dockerfile.linux)Items Needing Human Attention
libc++-devinstalled; this sync used an NDK-based workaround that is functionally equivalent but not the standard approachSKColorType.R16Float = 28: New public API — follows the existing pattern for R-channel color types (2 bytes, opaque, GL formatR16F)Created by skia-upstream-sync.