Skip to content

Bugfix #2967 - Change counter into boolean#4112

Open
Mangepange wants to merge 1 commit into
mono:mainfrom
Mangepange:bugfix-2967
Open

Bugfix #2967 - Change counter into boolean#4112
Mangepange wants to merge 1 commit into
mono:mainfrom
Mangepange:bugfix-2967

Conversation

@Mangepange

Copy link
Copy Markdown

Description of Change

Changed the integer counter for keeping track of Load and Unload events in SKXamlCanvas into a boolean.
This prevents issues when the Unload event comes before Load, and also when multiple Unload events are triggered (both of these situations arise due to WinUI issues).

(No added tests since I couldn't find any previous regarding the SKXamlCanvas)

Bugs Fixed

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

📦 Try the packages from this PR

Warning

Do not run these scripts without first reviewing the code in this PR.

Step 1 — Download the packages

bash / macOS / Linux:

curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 4112

PowerShell / Windows:

iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 4112"

Step 2 — Add the local NuGet source

dotnet nuget add source ~/.skiasharp/hives/pr-4112/packages --name skiasharp-pr-4112
More options
Option Description
--successful-only / -SuccessfulOnly Only use successful builds
--force / -Force Overwrite previously downloaded packages
--list / -List List available artifacts without downloading
--build-id ID / -BuildId ID Download from a specific build

Or download manually from Azure Pipelines — look for the nuget artifact on the build for this PR.

Remove the source when you're done:

dotnet nuget remove source skiasharp-pr-4112

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey there @@Mangepange! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@Mangepange

Copy link
Copy Markdown
Author

@dotnet-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[BUG] Multiple Unloaded events in WinUI causes empty SKXamlCanvas

1 participant