Add missing using declarations for SKFont instances in SKFontTest#3993
Draft
Copilot wants to merge 2 commits into
Draft
Add missing using declarations for SKFont instances in SKFontTest#3993Copilot wants to merge 2 commits into
using declarations for SKFont instances in SKFontTest#3993Copilot wants to merge 2 commits into
Conversation
10 tasks
Agent-Logs-Url: https://github.com/mono/SkiaSharp/sessions/6cbd81f0-35f7-4ada-90e9-8d2adf765c46 Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix SKFontTest by adding missing using declarations for SKFont
Add missing May 15, 2026
using declarations for SKFont instances in SKFontTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
27 test methods in
SKFontTest.cscreatenew SKFont(...)withoutusing, leaking native handles. The file already usesusing varin 14 other tests. This adds the missingusingkeyword to all remaining instances.Bugs Fixed
None.
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist