Skip to content

Add missing using declarations for SKFont instances in SKFontTest#3993

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-skfont-test-using-declarations
Draft

Add missing using declarations for SKFont instances in SKFontTest#3993
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-skfont-test-using-declarations

Conversation

Copilot AI commented May 15, 2026

Copy link
Copy Markdown
Contributor

Description of Change

27 test methods in SKFontTest.cs create new SKFont(...) without using, leaking native handles. The file already uses using var in 14 other tests. This adds the missing using keyword to all remaining instances.

// Before
var font = new SKFont(SKTypeface.Default);

// After
using var font = new SKFont(SKTypeface.Default);

Bugs Fixed

None.

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (existing tests unchanged — only resource cleanup added)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

Copilot AI changed the title [WIP] Fix SKFontTest by adding missing using declarations for SKFont Add missing using declarations for SKFont instances in SKFontTest May 15, 2026
Copilot AI requested a review from mattleibow May 15, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[fix-finder] Add missing using declarations for SKFont instances in SKFontTest

2 participants