update skia skill improvements#3644
Closed
ramezgerges wants to merge 1 commit into
Closed
Conversation
- Add upstream merge guide (new reference) covering genuine merge vs tree-override, per-file conflict resolution strategies, and post-merge verification steps - Add 11 new lessons to known-gotchas: git history preservation, native memory patterns, PR isolation, GPU test gaps, build flag churn, gitmodules, fontconfig guards, enum renumbering, changelog convention, refcount relaxation, pixel precision changes - Expand troubleshooting table with 8 new error/fix entries - Add recurring breaking change categories to the checklist - Expand Phase 4 with conflict resolution table, tree-override warning, and blame verification - Add API evolution policy to Phase 8 - Add PR review strategy for large diffs - Expand typical-changes and Phase 10 checklist with missing files Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
📦 Try the packages from this PRWarning Do not run these scripts without first reviewing the code in this PR. Step 1 — Download the packages bash / macOS / Linux: curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 3644PowerShell / Windows: iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 3644"Step 2 — Add the local NuGet source dotnet nuget add source ~/.skiasharp/hives/pr-3644/packages --name skiasharp-pr-3644More options
Or download manually from Azure Pipelines — look for the Remove the source when you're done: dotnet nuget remove source skiasharp-pr-3644 |
Contributor
Author
|
@mattleibow It was suggested to me that I should update the skills with what I have in my local Claude state + the m132 PR comments. Feel free to close this if it's more noisy than useful. |
mattleibow
added a commit
that referenced
this pull request
Apr 10, 2026
Incorporate learnings from PR #3644 and our m133 analysis, focusing on quality over quantity (-50 lines net). Key changes: - breaking-changes-checklist.md: Merge Steps 4a/4b/4c into a single 'Verify the Analysis' section (was duplicating gotchas 11-13). Add 'Recurring patterns' table consolidating Common C API Patterns and PR #3644's 'Recurring Breaking Change Categories' into one reference - known-gotchas.md: Reorganize into themed sections (C API layer, build system, dependencies, diff reading, merge strategy, testing). Merge HarfBuzz gotchas 7+10 into one. Add merge strategy (from PR #3644), fontconfig guards, enum renumbering, pixel precision, GN flag churn - SKILL.md Phase 2: Replace verbose 'three mandatory checks' with single reference to checklist. Phase 4: Add --no-commit merge, per-file conflict resolution table, git blame verification gate (from PR #3644) - typical-changes.md: Add BUILD.gn, .gitmodules, sk_types_priv.h, native/*/build.cake, GRDefinitions.cs (from PR #3644) - Remove 'MANDATORY' headers that diluted the signal — everything in the skill is mandatory by default Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mattleibow
added a commit
that referenced
this pull request
Apr 10, 2026
Improve the update-skia skill from m132→m133 lessons (#3658) Context: #3560 Context: #3644 The m132→m133 bump work exposed a few places where `update-skia` was too easy to follow into the wrong answer: moved headers looked deleted, struct layout changes were easy to miss until late validation, and reordered fields could be misread as removed API. Some of the existing guidance also leaned on "comment it out" workarounds that hide the real upstream change. Tighten the skill around those failure modes and fold the useful pieces of #3644 into a single, easier-to-follow workflow. The checklists and gotchas are now consolidated instead of duplicated, validation explicitly calls out struct size audits and relocation searches, and the guidance now pushes maintainers toward investigating the replacement API or enum strategy rather than silently suppressing the break. * reorganize gotchas by topic and add recurring-pattern references * bring merge strategy and `git blame` verification into the main flow * treat removed enums and legacy BUILD.gn flags as compatibility work to resolve, not shortcuts to paper over
Contributor
Author
|
Closing in favor of #3658 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds lessons learned during #3560.
Bugs Fixed
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist