Add validate-samples skill and building-samples documentation#3617
Closed
mattleibow wants to merge 8 commits into
Closed
Add validate-samples skill and building-samples documentation#3617mattleibow wants to merge 8 commits into
mattleibow wants to merge 8 commits into
Conversation
Add a Copilot skill that automates building and validating sample projects using CI-produced NuGet packages, plus a developer guide explaining the CI artifacts feed, cake targets, and troubleshooting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Move the 4 samples-related cake targets (samples-generate, samples-prepare, samples-run, samples) from build.cake into scripts/cake/samples.cake alongside the existing CreateSamplesDirectory helper. Key improvements: - Split monolithic 'samples' task into prepare/run phases - Add --sample filter argument for building specific samples - Enable Docker sample builds (previously commented out) - Better error reporting: collect failures and report at the end - Cleaner classification: build vs skip with reasons logged upfront Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mattleibow
force-pushed
the
dev/validate-samples-skill
branch
from
07a8279 to
def5191
Compare
- Remove non-existent validate-samples-full target from Quick Reference - Fix --artifactsFeed to --previewFeed (correct cake argument name) - Fix stale line references pointing to build.cake instead of samples.cake - Replace simplified version construction with actual code including FEATURE_NAME handling and conditional BUILD_NUMBER append - Fix download resolution to show actual PREVIEW_LABEL pattern - Remove incorrect externals-download ordering advice (both targets clear ./output/ so neither order preserves both outputs) - Remove externals-download from building-samples.md targets table and Building with Native Binaries section Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove duplicated inline bash detection logic from SKILL.md and building-samples.md. Both now reference the detect-preview-version.sh script, which prints values the AI agent can parse from stdout. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SKILL.md is now a lean AI runbook: just the 4 workflow steps, troubleshooting, and a link to docs. Version construction details, download resolution, cake arguments reference, and samples-generate internals now live exclusively in building-samples.md. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The docs no longer duplicate the workflow steps — they point to the validate-samples skill instead, with example prompts showing how to invoke it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace bash detect-preview-version.sh with detect-preview-version.ps1. Convert all inline code blocks in SKILL.md and building-samples.md to PowerShell using short aliases (rm, ls, etc.). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Copilot skill and developer documentation for building and validating SkiaSharp sample projects.
Changes
validate-samples skill (.github/skills/validate-samples/)
A Copilot skill that automates building and validating sample projects using CI-produced NuGet packages. It downloads the latest CI artifacts, detects the preview version, and runs the samples cake target to verify all samples compile correctly. Includes a helper script for extracting the preview version from CI packages.
Building samples documentation (\documentation/dev/building-samples.md)
Developer guide explaining how to build samples using the CI artifacts feed, including wrapper package structure, the samples cake target, manual local builds, and troubleshooting.
Extracted from #3553.