🐛 Require AC + Dependencies headings in plan prompt (closes #96)#98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the contract gap between
askcc planandaskcc developreported in #96:plancould succeed without writing## Acceptance Criteria/## Dependenciesheadings, leavingdevelop'svalidate_issue_readinessto fail immediately.Why
PLAN_AGENT_PROMPTitems 1 and 2 used "replace any existing X" wording, which is ambiguous when no existing X is present. Item 2 explicitly handled the empty case ("If none, include the heading with 'None identified.'"); item 1 did not. A reasonable agent interpretation was "if no existing section, do nothing," leaving the body in a statedeveloprejects.Changes
askcc/definitions.py—PLAN_AGENT_PROMPTissue-description-update section:## Tasks,## Requirements) to## Acceptance Criteria.## Post-Update Verificationstep: after editing, the agent re-reads the body and confirms both required headings are present (with a checklist item under AC), re-editing if either check fails. This converts the contract from "agent should remember to do it" to "agent verifies it before stopping."Verification
uv run pytest— 225 passeduv run poe check(ruff) — cleanuv run poe typecheck(pyright) — 0 errorsTest plan
askcc planagainst a fresh issue with no## Acceptance Criteria/## Dependenciessections; confirm the resulting body passesvalidate_issue_readiness.askcc planagainst an issue with a## Tasksheading; confirm the agent renames it to## Acceptance Criteriarather than leaving it.askcc planagainst an issue that already has<!-- draft -->AC / Dependencies sections; confirm replacement still works.