✨ Review/update PR description on develop and fix-ci runs#94
Merged
Conversation
Develop and fix-ci now review and refresh the existing PR description when pushing changes to a branch with an open PR. Develop also requires a GitHub auto-close keyword (Closes/Fixes #N) in the PR body so the target issue is linked and closes on merge.
monkut
commented
Apr 28, 2026
monkut
left a comment
Owner
Author
There was a problem hiding this comment.
Good, but simplify language, maintaining the full meaning but keeping it consise.
Ex)
Read the current PR body -> Read current PR body
Concision pass per PR #94 review feedback. Removes filler articles, redundant phrases, and verbose constructs across PREPARE, PLAN, DEVELOP, REVIEW, EXPLORE, DIAGNOSE, REVIEWPR, and FIX-CI prompts (and their user-prompt templates) while preserving meaning. Updates the new PR-description-update tests to match the shortened substrings.
Owner
Author
|
Addressed in 9207382: applied a concision pass to all action prompts (PREPARE, PLAN, DEVELOP, REVIEW, EXPLORE, DIAGNOSE, REVIEWPR, FIX-CI) and their user-prompt templates.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developandfix-ciaction prompts now review and refresh the existing PR description whenever changes are pushed to a branch with an open PR.developrequires a GitHub auto-close keyword (Closes #<n>/Fixes #<n>) in the PR body so the originating issue links to the PR and closes on merge.Additions
PR_DESCRIPTION_UPDATE_BODYconstant inaskcc/definitions.py, wrapped asDEVELOP_PR_DESCRIPTION_UPDATE(top-level section) andFIXCI_PR_DESCRIPTION_UPDATE(4-space-indented sub-step under fix-ci's numbered list). Keeps wording in sync between the two prompts.developprompt —On completiondistinguishes the new-PR vs existing-PR cases and points at the newPR description updatesection. ThePR descriptionsection gains a bullet requiringCloses #<issue-number>/Fixes #<issue-number>in the PR body.fix-ciprompt — new step 14 reviews and updates the PR description (refresh## Verification,## Summary,## Key Flows,## Test plan) before posting the summary comment (now step 15).definitions.py+ tests.tests/test_askcc.py(TestDevelopPromptPrDescriptionUpdate,TestDevelopPromptIssueReference,TestFixciPromptPrDescriptionUpdate) — 13 new substring/ordering assertions. ExistingTestDevelopPromptTestPlanUpdateand the new tests updated for the concise wording.Key Flows
flowchart TD A[develop/fix-ci finishes change] --> B{open PR exists for branch?} B -- no, develop --> C[open new PR with Closes #N in body] B -- yes --> D[read existing PR body] D --> E[refresh Verification, Summary, Key Flows, Test plan] E --> F[gh pr edit --body] C --> G[post issue/PR comment] F --> GVerification
uv run pytest— passed (214 tests)uv run ruff check .— passed (no issues)uv run ruff format --check askcc/definitions.py tests/test_askcc.py— passeduv run pyright askcc/definitions.py— passed (0 errors)Test plan
DEVELOP_AGENT_PROMPTincludes the newPR description updateheadingDEVELOP_AGENT_PROMPTincludesCloses #<issue-number>/Fixes #<issue-number>in the PR description sectionFIXCI_AGENT_PROMPTincludes the new "Review and update the PR description" stepgh prcommands for the bodyaskcc developagainst an issue with an existing PR and confirm the description is refreshedaskcc fix-ciand confirm the PR description's## Verificationsection is updated post-fix