Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions askcc/definitions.py
Original file line number Diff line number Diff line change
Expand Up @@ -322,14 +322,14 @@
`` `
```
- Mermaid label safety: quote labels containing `/`, `\\`, `(`, `)`, `|`, `:`, or starting \
with punctuation — e.g. `B["/simplify, commit, push"]`, not `B[/simplify, commit, push]`. \
with punctuation — e.g. `B["/code-review, commit, push"]`, not `B[/code-review, commit, push]`. \
Unquoted leading `/` or `\\` is parsed as parallelogram/trapezoid shape syntax and breaks \
rendering with a "Lexical error / Unrecognized text" message.
- Keep diagrams concise — one or two covering the most important flows. \
Skip this section for trivial changes (config-only, docs-only, single-line fix).

On completion:
- Run /simplify or /refactor to improve the code.
- Run /code-review or /refactor to improve the code.
- Commit and push the feature branch.
- If no PR exists, open one linked to the issue.
- If a PR exists (follow-up changes), review and update its description (see "PR description update").
Expand Down
4 changes: 2 additions & 2 deletions askcc/skills/handle-github-issue/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,10 @@ PR description:
- Include `## Key Flows` with mermaid diagrams for the main flows changed by this PR. Focus on control flow,
data flow, or state transitions. Skip this section for trivial changes (config-only, docs-only, single-line fix).
- Mermaid label safety: quote labels containing `/`, `\`, `(`, `)`, `|`, `:`, or starting with punctuation —
e.g. `B["/simplify, commit, push"]`, not `B[/simplify, commit, push]`.
e.g. `B["/code-review, commit, push"]`, not `B[/code-review, commit, push]`.

On completion:
- Run /simplify or /refactor to improve the code.
- Run /code-review or /refactor to improve the code.
- Commit and push the feature branch.
- If no PR exists, open one linked to the issue.
- If a PR exists (follow-up changes), review and update its description (see "PR description update" below).
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "askcc"
version = "0.2.13"
version = "0.2.14"
description = "A one-shot cc cli executor"
authors = [{ name = "mknt", email = "shane.cousins@gmail.com" }]
readme = "README.md"
Expand Down
4 changes: 2 additions & 2 deletions tests/test_askcc.py
Original file line number Diff line number Diff line change
Expand Up @@ -445,14 +445,14 @@ class TestDevelopPromptMermaidLabelSafety:
r"""The develop prompt must instruct quoting mermaid labels with shape-reserved chars.

Without quoting, labels starting with `/` or `\` are parsed as parallelogram/trapezoid
shape syntax (e.g. `B[/simplify]`) and break rendering with a lexical error.
shape syntax (e.g. `B[/code-review]`) and break rendering with a lexical error.
"""

def test_includes_label_safety_guidance(self):
assert "Mermaid label safety" in DEVELOP_AGENT_PROMPT

def test_includes_quoted_example(self):
assert 'B["/simplify, commit, push"]' in DEVELOP_AGENT_PROMPT
assert 'B["/code-review, commit, push"]' in DEVELOP_AGENT_PROMPT

def test_warns_against_parallelogram_collision(self):
assert "parallelogram/trapezoid shape syntax" in DEVELOP_AGENT_PROMPT
Expand Down
2 changes: 1 addition & 1 deletion uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading