🐛 Verify assignee in plan post-update verification (closes #106)#107
Merged
Conversation
Closes the contract gap between `askcc plan` and `askcc develop` for the assignee check, mirroring the AC/Dependencies fix from #96. The plan prompt instructs `gh issue edit --add-assignee "@me"`, but the post-update verification loop only checked AC + Dependencies headings, so a missed assignee step produced a silent failure mode where develop's validate_issue_readiness rejected the issue. The verification block now fetches both `body` and `assignees` via a single `gh issue view --json body,assignees` call and re-assigns / re-edits until all three plan-controllable readiness checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the contract gap between
askcc planandaskcc developfor the assignee check, mirroring the AC/Dependencies fix from #96.Why
PLAN_AGENT_PROMPT's Post-Update Verification block ataskcc/definitions.py:170-173re-read the body and confirmed## Acceptance Criteria+## Dependencieswere present, but did not verify the assignee. The plan prompt instructsgh issue edit <url> --add-assignee "@me"(definitions.py:164); a missed assignee step produced a silent failure mode wheredevelop'svalidate_issue_readiness(functions.py:362-371) rejected the issue.This is the same class of contract gap as #96, just for the assignee rather than the body headings.
Changes
askcc/definitions.py—PLAN_AGENT_PROMPTPost-Update Verification block:gh issue view --json body -q .bodytogh issue view --json body,assignees(single call, both fields).pyproject.toml/uv.lock— version bump 0.2.12 → 0.2.13.Verification
uv run poe check(ruff) — cleanuv run poe typecheck(pyright) — 0 errorsuv run pytest— 256 passedTest plan
askcc planagainst a fresh, unassigned issue with no## Acceptance Criteria/## Dependenciessections; confirm the resulting body passesvalidate_issue_readinessAND the issue has an assignee.askcc planagainst an issue that is already assigned and already has the required headings; confirm the verification loop is a no-op.askcc developagainst the issue produced by the first test; confirm pre-flight passes 4/4 checks.