Skip to content

fix(ipa): Update ipa-spectral to include mongoDBEmployeeAccessGrant#1328

Merged
andreaangiolillo merged 2 commits into
mainfrom
update_ipa-spectral.yaml
Jun 23, 2026
Merged

fix(ipa): Update ipa-spectral to include mongoDBEmployeeAccessGrant#1328
andreaangiolillo merged 2 commits into
mainfrom
update_ipa-spectral.yaml

Conversation

@andreaangiolillo

Copy link
Copy Markdown
Collaborator

Proposed changes

This PR addresses this comment: https://github.com/10gen/mms/pull/172469#discussion_r3458750564

@andreaangiolillo andreaangiolillo requested a review from a team as a code owner June 23, 2026 10:10
@andreaangiolillo andreaangiolillo changed the title fix: Update ipa-spectral to include mongoDBEmployeeAccessGrant fix(ipa): Update ipa-spectral to include mongoDBEmployeeAccessGrant Jun 23, 2026
Comment thread tools/spectral/ipa/ipa-spectral.yaml Outdated
- '**#/components/schemas/LegacyAtlasTenantClusterUpgradeRequest/properties/mongoDBEmployeeAccessGrant' # unable to document exceptions, to be covered by CLOUDP-308286
- '**#/components/schemas/AdvancedAutoScalingSettings/properties/diskGB' # unable to document exceptions, to be covered by CLOUDP-308286
- '**#/components/schemas/UserSecurity/properties/customerX509' # unable to document exceptions, to be covered by CLOUDP-308286
- '**#/components/schemas/ApiAtlasClusterDescriptionPreview/properties/mongoDBEmployeeAccessGrant' # unable to document exceptions, to be covered by CLOUDP-293178

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Let's reference the CLOUDP-308286 ticket here to match the others. We can update this once that ticket is addressed

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated it

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is expected for the spectral link to fail? @yelizhenden-mdb

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but it fails to something else. Let me take a deeper look

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a PR to fix this: https://github.com/10gen/mms/pull/172298
I think you can merge with the failure

Comment thread tools/spectral/ipa/ipa-spectral.yaml Outdated
@andreaangiolillo andreaangiolillo merged commit ef5350a into main Jun 23, 2026
6 of 7 checks passed
@andreaangiolillo andreaangiolillo deleted the update_ipa-spectral.yaml branch June 23, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants