Skip to content

fix possible command injection #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeroenvervaeke merged 1 commit into from
Nov 21, 2025
Merged

fix possible command injection #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,9 @@ runs:

if [ -z "${{ inputs.project-id }}" ]
then
atlas cluster create ${{ inputs.create-cluster-name }} ${CLUSTER_CONFIG}
atlas cluster create "${{ inputs.create-cluster-name }}" ${CLUSTER_CONFIG}
else
atlas cluster create ${{ inputs.create-cluster-name }} --projectId ${{ inputs.project-id }} ${CLUSTER_CONFIG}
atlas cluster create "${{ inputs.create-cluster-name }}" --projectId "${{ inputs.project-id }}" ${CLUSTER_CONFIG}
fi

- name: Delete Cluster
Expand All @@ -154,8 +154,8 @@ runs:
env:
ATLAS_GITHUB_ACTION: "true"
run: |
atlas cluster delete ${{ inputs.delete-cluster-name }} --force --projectId ${{ inputs.delete-project-id }}
if ! atlas cluster watch ${{ inputs.delete-cluster-name }} --projectId ${{ inputs.delete-project-id }} >/dev/null 2>&1; then
atlas cluster delete "${{ inputs.delete-cluster-name }}" --force --projectId "${{ inputs.delete-project-id }}"
if ! atlas cluster watch "${{ inputs.delete-cluster-name }}" --projectId "${{ inputs.delete-project-id }}" >/dev/null 2>&1; then
echo "Atlas Cluster '${{ inputs.delete-cluster-name }}' is deleted"
exit 0
fi
Expand All @@ -166,7 +166,7 @@ runs:
env:
ATLAS_GITHUB_ACTION: "true"
run: |
atlas project delete ${{ inputs.delete-project-id }} --force
atlas project delete "${{ inputs.delete-project-id }}" --force

- name: Setup
if: ${{ inputs.run-setup == 'true' && inputs.username && inputs.password }}
Expand Down