Fix tests in Docker for 3.x#827
Open
denis-trofimov wants to merge 3 commits into
Open
Conversation
The php:7.2-cli image is based on EOL Debian Buster; apt-get update fails against the default mirrors. Point apt at archive.debian.org and document the requirement in the README.
php:7.2-cli cannot parse dev packages installed on PHP 7.4 (e.g. phpdocumentor/reflection-docblock), which caused 200+ PHPUnit errors. Use php:7.4-cli-buster and document the version mismatch in the README.
Add README instructions for installing dependencies in the container when vendor/ is missing and Composer is not baked into the image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes Fix tests in Docker for 3.x #828
The php:7.2-cli image is based on EOL Debian Buster; apt-get update fails against the default mirrors. Point apt at archive.debian.org and document the requirement in the README.
if Docker runs an older PHP (for example 7.2 while dependencies were resolved on 7.4), PHPUnit can fail with hundreds of
ParseErrors invendor/(often in packages used by Prophecy, such asphpdocumentor/reflection-docblock).