Fork 202604#826
Open
kdocki wants to merge 5 commits into
Open
Conversation
…ratio is present.
…gative (this is an unnecessary check and prevents valid use cases).
Restores the zero-total guard that was removed in 990f29e while still allowing negative ratios as long as the total is non-zero. Without this, allocate([0, 0]) hit a DivisionByZeroError in BcMathCalculator::share instead of the documented InvalidArgumentException. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
Please include some tests and rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually when we allocate it is all positive, example break apart $100 ... 50/50 (which is $50 / $50). This fork was made to handle an real world edge case we ran into where need to allocate across "debt & credits owed."
So imagine you have $100 and you want to allocate it [2, -1]? This may seem strange but effectively this is saying, I'll give you $200 and you owe me $100 (mathematically $100 = $200 - $100). It is still a valid allocation although a bit of a brain twister until you release that it's dealing with credit/debt so not all the money has been paid between 2 different parties that are settling an account balance.