Introduce Currency::zero() factory for Money#825
Merged
Conversation
When building up an amount through calculations, you often start from an empty Money in a known currency. The typical pattern is: ```php $amount = new Money(0, $currency); $amount = $amount->add(...); ``` Since the currency is usually the thing you already have in hand, reading the code flows better when the currency itself produces the zero value: ```php $amount = $currency->zero()->add(...); ```
Contributor
Author
|
@frederikbosch Ready for review, whenever you have time 🙏 |
Member
|
This looks good @ruudk. I very much recognize the pattern you mention in the PR. Therefore I think it is very good addition to the library. |
Member
|
I will tag tomorrow. |
Contributor
Author
|
Friendly ping 😁 |
Member
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a nice Developer Experience improvement:
When building up an amount through calculations, you often start from an empty Money in a known currency. The typical pattern is:
Since the currency is usually the thing you already have in hand, reading the code flows better when the currency itself produces the zero value: