Skip to content

fix(collector): exclude Self-receiver types only at receiver position, keep them as params elsewhere#6

Merged
monchin merged 2 commits into
masterfrom
fix/pyself-location
Jun 13, 2026
Merged

fix(collector): exclude Self-receiver types only at receiver position, keep them as params elsewhere#6
monchin merged 2 commits into
masterfrom
fix/pyself-location

Conversation

@monchin

@monchin monchin commented Jun 13, 2026

Copy link
Copy Markdown
Owner

Description

In last fix (b17dff2), I missed a situation that Py<Self> is not the first param, e.g.:

#[pymethod]
fn compare(&self, other: Py<Self>) -> bool {
    return true;
}

rylai would swallow other in last commit. So it should be fixed.

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Refactor / chore

Checklist

  • Code follows the project style (cargo fmt, cargo clippy).
  • Self-review done.
  • Comments and docs are in English.
  • Pre-commit checks pass (prek run --all-files or equivalent).
  • CI passes (build, test, lint on Ubuntu, Windows, macOS).

@monchin monchin merged commit b0c5a7b into master Jun 13, 2026
0 of 9 checks passed
@monchin monchin deleted the fix/pyself-location branch June 13, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant