refactor: extract packages into packages/<name>.nix#2686
Open
Lymah123 wants to merge 1 commit into
Open
Conversation
Author
|
@mightyiam , the PR is ready for review |
mightyiam
reviewed
Jul 4, 2026
| lib, | ||
| }: | ||
| let | ||
| pluginRoot = ./../vim-plugin; |
Member
There was a problem hiding this comment.
Suggested change
| pluginRoot = ./../vim-plugin; | |
| pluginRoot = ../vim-plugin; |
| pname = "statix"; | ||
| version = "0.6.0-git"; | ||
| src = lib.fileset.toSource { | ||
| root = ./..; |
Member
There was a problem hiding this comment.
Suggested change
| root = ./..; | |
| root = ../.; |
Comment on lines
+19
to
+20
| ./../Cargo.lock | ||
| ./../insta.yaml |
Member
There was a problem hiding this comment.
Suggested change
| ./../Cargo.lock | |
| ./../insta.yaml | |
| ../Cargo.lock | |
| ../insta.yaml |
| (file.hasExt "rs") | ||
| (file.hasExt "snap") | ||
| ] | ||
| ) ./..) |
Member
There was a problem hiding this comment.
Suggested change
| ) ./..) | |
| ) ../.) |
| ./../insta.yaml | ||
| ]; | ||
| }; | ||
| cargoLock.lockFile = ./../Cargo.lock; |
Member
There was a problem hiding this comment.
Suggested change
| cargoLock.lockFile = ./../Cargo.lock; | |
| cargoLock.lockFile = ../Cargo.lock; |
| meta = { | ||
| mainProgram = "statix"; | ||
| description = "Lints and suggestions for the Nix programming language"; | ||
| homepage = "https://git.peppe.rs/languages/statix/about"; |
Member
There was a problem hiding this comment.
Suggested change
| homepage = "https://git.peppe.rs/languages/statix/about"; | |
| homepage = "https://github.com/molybdenumsoftware/statix"; |
Comment on lines
+2
to
+3
| statix = final.callPackage ./packages/statix.nix { }; | ||
| statix-vim = final.callPackage ./packages/statix-vim.nix { }; |
Member
There was a problem hiding this comment.
Suggested change
| statix = final.callPackage ./packages/statix.nix { }; | |
| statix-vim = final.callPackage ./packages/statix-vim.nix { }; | |
| statix = prev.callPackage ./packages/statix.nix { }; | |
| statix-vim = prev.callPackage ./packages/statix-vim.nix { }; |
I think prev is more correct. And this seems to be an existing issue. May as well correct it, but in a separate commit. Of type chore, I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the
statixandstatix-vimpackage definitions fromoverlay.nixintopackages/statix.nixandpackages/statix-vim.nix respectively, and calls each viacallPackagein the overlay.