Personality speech for custom companions + natural hide animation + spin clip fix - #7
Merged
Merged
Conversation
…on + spin clip fix - ISS-042: add PERSONALITY_POOLS (friendly/curious/lazy/energetic/ mischievous x pet/mischief/idle/activity/clipboard/screenshot) so user-imported companions without speech talk in a personality-matched voice; pickReaction order: char speech -> personality -> neutral pool - ISS-041: redesign hide animation to duck the companion down behind the window's bottom edge (translateY/dy, mild squash, near-full opacity) instead of flattening + fading, for every companion - ISS-039 follow-up: use #creature.anim-spin selector (ID rule was overriding the center transform-origin) and tighten spin scale to 0.75 - tests: personality pools + custom-companion fallback + hide duck-down 174 tests green, 19 packs validated, local Mischief.app rebuilt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gives user-imported companions a personality-matched voice, makes the hide animation look natural for every companion, and properly fixes the spin/roll clipping.
Personality speech for custom companions (ISS-042)
Custom companions have no species-specific dialogue, so every bubble used the neutral generic pools regardless of personality. Added
PERSONALITY_POOLScovering friendly / curious / lazy / energetic / mischievous across pet, mischief, idle, activity, clipboard, and screenshot signals.pickReactionnow resolves: character speech → personality pool → neutral generic pool, so:speechwins).Hide animation redesigned (ISS-041)
The old hide squashed the sprite flat (
scale(1.15, 0.5)) and faded it — looked bad for all companions. Now it ducks down behind the window's bottom edge (translateY / positive dy, mild squash ~0.9, near-full opacity), reading naturally as "hiding behind the corner" for sprites and cutouts alike.Spin clip fix follow-up (ISS-039)
The first fix didn't stick because
#creature { transform-origin: 50% 90% }(ID selector) was overriding the.anim-spincenter-origin rule. Switched to#creature.anim-spinand tightened the scale to 0.75 for a comfortable margin.Verification
Mischief.apprebuilt and running.