Online event support with auto country via organizer geolocation#174
Merged
Conversation
Preparing first-class support for online events. Two new columns:
* event_type varchar(16) NOT NULL DEFAULT 'in_person'
— effective domain "in_person" | "online". Plain varchar keeps
migration low-risk; no Postgres enum needed.
* meeting_url text NULL
— Zoom/Meet/Discord invite for online events. Kept separate
from externalUrl (which is still "redirect attendees to external
registration") to avoid conflating two distinct concepts.
Existing rows read as in_person with meetingUrl NULL thanks to the
NOT NULL DEFAULT — backward compatible. Application code in
subsequent commits.
The migration uses IF NOT EXISTS so replay against a DB that
already has the columns (e.g. applied via raw SQL during development)
is a no-op rather than an error.
Events can now be created and updated as online events. Changes:
* POST /api/events (create.ts): accepts eventType/meetingUrl +
optional organizerLat/organizerLng. For online events, validates
the URL, strips placeId/venueDetail, and reverse-geocodes the
organizer's coords (browser GPS, sent client-side) into a country
code via the existing reverseGeocodeCountry utility. No coords
⇒ country = NULL ⇒ event surfaces only in global feeds.
* PATCH /api/events/:id (update.ts): handles transitions in both
directions (in_person ↔ online), clearing the now-irrelevant
fields on flip. Also re-derives country on any placeId change,
fixing a pre-existing bug where country went stale.
* ICS feed (events/ics.ts + the two projection controllers):
LOCATION uses meetingUrl for online events, physical-location
text for in-person. Calendar apps render the URL as free text
that joiners can copy.
* GET /api/events/:id (detail.ts) + useEventDetail EventData type:
include eventType and meetingUrl so the UI can render them.
Coords are consumed only by reverseGeocodeCountry and then
discarded — never persisted anywhere. Only the resolved country
ends up in the DB.
WhereCard now leads with a segmented In-person | Online toggle:
* In-person (default) — the existing PlacePicker + venueDetail
stay exactly as they were.
* Online — hides the picker, shows a single Meeting URL input
plus a small helper hint (Zoom / Meet / Discord / etc.).
When the user toggles to online, WhereCard silently calls
navigator.geolocation.getCurrentPosition **only if** the browser
already reports permission state "granted" — we never trigger a
fresh permission prompt from inside the event form. Organizers who
have visited /places will have almost certainly granted it.
Coords are plumbed up to the form state but only to be submitted
(server reverse-geocodes to a country code and discards them).
The dashboard edit page now reuses <WhereCard> instead of inline
<PlacePicker>, so the form shape is identical between create and
edit — including the online/in-person transition flow.
When event.eventType === "online", show a dedicated "Online event" block with the meeting URL as a new-tab link, in the same visual slot as the physical-location card for in-person events. The existing location/map block now renders only for non-online events (it was already guarded on placeLatitude/placeLongitude being non-null, so no regression — just a clearer condition).
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 10 minutes and 30 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds first-class online-event support: organizers toggle In-person / Online on the event form, and online events capture a meeting URL (Zoom/Meet/Discord/etc.) instead of a physical venue. For country discoverability, the browser silently supplies the organizer's geolocation (only when permission is already granted — no fresh prompt), the server reverse-geocodes it to an ISO country code via the existing
reverseGeocodeCountryutility, and only the country code is persisted — raw coords are discarded. A bonus fix: country now recomputes when an in-person event'splaceIdchanges (previously went stale).Assisted-By: Claude Code(claude-opus-4-7)