fix: record overrun candles as SKIPPED_OVERRUN, not data-unavailable (#169) - #172
Merged
Merged
Conversation
…169) A candle missed because our own processing overran was filed as SKIPPED_DATA_UNAVAILABLE - "we could not get market data". The data was fine. The previous session was still running. That matters because SKIPPED_DATA_UNAVAILABLE is the signal you check when you suspect the Alpaca feed is broken. Overrun candles polluted it, so a run showing eight "data unavailable" rows sent you to check the feed when the real story was an investigation running longer than its candle. Adds SKIPPED_OVERRUN as a Session status and uses it for the market-open branch of _handle_overrun_candles. SKIPPED_MARKET_CLOSED is unchanged, and SKIPPED_DATA_UNAVAILABLE keeps its meaning and its other uses. Both were already outside the FR-018 count, so run length is unaffected. data-model.md gains the new value plus a table explaining what each status means, since "COMPLETED, SKIPPED_TIMEOUT, ..." on one line did not say why you would see one rather than another. Closes #169
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Reviewed by step-3.7-flash · Input: 67.5K · Output: 14.6K · Cached: 1M |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #169.
A candle missed because our own processing overran was filed as
SKIPPED_DATA_UNAVAILABLE- "we could not get market data". The data was fine. The previous session was still running.That matters because
SKIPPED_DATA_UNAVAILABLEis the signal you check when you suspect the Alpaca feed is broken. Overrun candles polluted it, so a run showing eight "data unavailable" rows sent you off to check the feed when the real story was an investigation running longer than its candle. Two different problems, two different fixes, previously indistinguishable in the memory bank and in the session report.What changed
SKIPPED_OVERRUNadded as a Session status, used for the market-open branch of_handle_overrun_candles.SKIPPED_MARKET_CLOSEDunchanged - that branch was already correct.SKIPPED_DATA_UNAVAILABLEkeeps its meaning and its other uses (a failed investigation still returns it).Spec
data-model.mdgains the new value, plus a table saying what each status actually means - the previous one-line list did not explain why you would see one rather than another.