[MOOSE-401] Round theme clamp values to nearest 2px#358
Merged
Conversation
Wrap each clamp() min/preferred/max argument with round(down, …, 4px) so fluid spacing and typography snap to a predictable 4px grid at runtime. Co-authored-by: Cursor <cursoragent@cursor.com>
…per-arg Apply round(down, clamp(...), 4px) so the computed clamp result snaps to 4px, matching the intended CSS round() usage. Co-authored-by: Cursor <cursoragent@cursor.com>
…lues Smaller step keeps subtle clamp ranges on a predictable grid without overshooting on small token sizes. Co-authored-by: Cursor <cursoragent@cursor.com>
GeoffDusome
changed the title
GeoffDusome
requested review from
LayaTaal,
Vinsanity,
dpellenwood,
jamiepaul and
spadilha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do/fix?
Wraps each theme
clamp()withround(down, clamp(…), 2px)so the computed fluid value snaps down to a predictable 2px grid. Applies to fluid font sizes, spacing presets, and grid gutter/margin intheme.json, plus matching fallbacks inlayout/_variables.pcss.A 2px step avoids coarse jumps on smaller clamp ranges where a 4px interval might barely change between breakpoints.
References: Better fluid sizing with round()
QA
Links to relevant issues
Test Environment
Test plan
round()(Chrome/Edge/Firefox/Safari, baseline 2024+).--wp--custom--spacing--grid-gutter,--wp--custom--spacing--grid-margin) still scale fluidly and align with layout expectations.Screenshots/video:
Pull request checklist