ci: split ci.yml into reusable _checks.yml#19
Merged
Conversation
Mirror modern-di's structural split: ci.yml becomes a thin trigger wrapper containing the `checks:` job (delegates to _checks.yml via workflow_call) plus the autosemver-specific `action-smoke` job (PR-only, dogfoods the local composite action with dry-run wiring). _checks.yml holds the lint and pytest jobs. action-smoke stays in ci.yml rather than _checks.yml because it exercises `uses: ./` against the local checkout — autosemver-specific, not a candidate for a reusable workflow. Action pins were already bumped to v6/v4/v8.2.0 in an earlier sweep, so this PR is structural only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Structural mirror of modern-di's CI shape, matching the rest of the modern-python org repos:
ci.ymlbecomes a thin trigger wrapper (push tomain,pull_request, concurrency group) that delegates to_checks.yml._checks.ymlis a reusable workflow (on: workflow_call) holding thelintandpytestjobs.action-smokejob stays inci.ymlalongside thechecks:wrapper — it exercisesuses: ./against the local checkout (not a candidate for a reusable workflow).Action pins were already bumped to
@v6/@v4/@v8.2.0in an earlier sweep, so this PR is structural only.Behaviour change
None. Same triggers, same concurrency group, same jobs (lint, pytest matrix, action-smoke), same steps, same matrix. The split adds a
workflow_callindirection plus future-proofs the shape so additional callers (nightly schedule, manual dispatch) can reuse the checks without duplicating definitions.Test plan
lint+pytest(4-Python matrix) run via thecheckscaller, plusaction-smoke(PR-only).🤖 Generated with Claude Code