ci(action-smoke): gate on pull_request to avoid false fail on main#13
Merged
Conversation
On push-to-main the merge tip IS a `feat/`/`bugfix/` source, so branch-prefix returns `created` and `bump=patch|minor` — the tightened no-bump assertions then fail by design. Coverage of that path lives in the dogfood workflow (`.github/workflows/semvertag.yml`), which runs the same `uses: ./` end-to-end on every push to main. Gating action-smoke on `pull_request` keeps the assertion's intent (catch PR- time regressions in action.yml's normalization) without colliding with main's expected created-tag path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#12 tightened action-smoke's assertion from non-empty to exact-equality on
status=no-bump. That assertion holds for PR commits (non-merge tip → branch-prefix no-bump) but FAILS on push-to-main where the merge tip IS afeat//bugfix/source → branch-prefix correctly returnscreatedwithbump=patch|minor. Concrete failure: run 27187224380, post-#12 main push,status=created bump=patch(the real 0.4.1 tag was created).Fix
Gate the job on
github.event_name == 'pull_request'. The PR-time regression-detection use case is preserved; the redundant main-push run goes away. The dogfood workflow (.github/workflows/semvertag.yml) already exercisesuses: ./end-to-end on every push to main, so coverage is unchanged.Test plan