fix(ci): tag-major prepends v so floating tag matches docs#11
Merged
Conversation
This project tags releases bare-semver (`0.4.0`), but action consumers
follow the GHA convention `uses: modern-python/semvertag@v0`. The
original tag-major.yml computed `major="${RELEASE_TAG%%.*}"` which on
a `0.4.0` release produces `0`, not `v0` — so `@v0` would resolve to
nothing.
Strip any leading `v` from RELEASE_TAG, then unconditionally prepend
`v` to the major segment. Works for both bare (`0.4.0`) and
v-prefixed (`v0.4.0`) release styles.
Runbook Steps 2 + 3 corrected to match: release tag is `0.4.0` (not
`v0.4.0`); manual `v0` bootstrap points at `0.4.0`, not `v0.4.0`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Caught after merging #10 and observing the dogfood workflow create tag
0.4.0(bare semver, this project's convention) — surfaced the gap thattag-major.ymlwould produce a floating tag named0, not thev0our docs promise.tag-major.yml: strip any leadingvfromRELEASE_TAG, then unconditionally prependvto the major segment. Works for both bare (0.4.0) and v-prefixed (v0.4.0) release styles.planning/releases/0.4.0.mdSteps 2 + 3: corrected tag name fromv0.4.0→0.4.0; bootstrap command now pointsv0at0.4.0(notv0.4.0, which doesn't exist).Test plan
tag-major.ymlfires on subsequent releases and createsv0(next release would update it).v0tag.