Skip to content

fix(retry-budget): close 7 audit findings (0.8.3) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesnik512 merged 9 commits into from
Jun 8, 2026
+2,030 −56
Merged

fix(retry-budget): close 7 audit findings (0.8.3) #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
05c438f
spec: retry-budget cluster (0.8.3) — close 7 audit findings
lesnik512 Jun 8, 2026
14c21ab
plan: retry-budget cluster (0.8.3) — 7-task TDD sequence
lesnik512 Jun 8, 2026
79daf0c
fix(budget): ceiling uses math.ceil, not int truncation
lesnik512 Jun 8, 2026
04bbdc8
fix(retry): hoist deposit() to per-request, not per-attempt
lesnik512 Jun 8, 2026
fd60067
feat(retry): give up when Retry-After exceeds max_delay
lesnik512 Jun 8, 2026
777d927
test(retry-props): property test for the budget-exhaustion path
lesnik512 Jun 8, 2026
049bfa9
fix(retry): scope streaming-body refusal note to its actual blocker site
lesnik512 Jun 8, 2026
6b399eb
fix(client): map RuntimeError → TransportError via is_closed, not sub…
lesnik512 Jun 8, 2026
073147d
docs(release): draft 0.8.3 notes — RetryBudget cluster + retry/client…
lesnik512 Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/resilience.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ from httpware.middleware.resilience import AsyncRetry
| `max_delay` | `5.0` (s) | Ceiling for backoff. |
| `retry_status_codes` | `frozenset({408, 429, 502, 503, 504})` | Status codes considered retryable. |
| `retry_methods` | `frozenset({"GET", "HEAD", "OPTIONS", "PUT", "DELETE"})` | Idempotent methods only by default. POST excluded; pass an explicit frozenset including `"POST"` to retry it. |
| `respect_retry_after` | `True` | When the response carries a `Retry-After` header on a retryable status, sleep for the header value (clamped to `max_delay`) instead of the jittered backoff. |
| `respect_retry_after` | `True` | When the response carries a `Retry-After` header on a retryable status, sleep for the header value instead of the jittered backoff. If the header value exceeds `max_delay`, AsyncRetry gives up and re-raises the underlying `StatusError` with a PEP 678 note `httpware: Retry-After (Ns) exceeded max_delay (Ms); giving up`. Set `max_delay` higher (or `respect_retry_after=False`) to opt out. |
| `budget` | `RetryBudget()` (default-configured) | The token bucket. Pass a shared `RetryBudget` instance to apply one budget across multiple clients. |

For a whole-attempt wall-clock bound, use `httpx2.Timeout` on the client or
Expand Down Expand Up @@ -185,7 +185,7 @@ from httpware.middleware.resilience import Retry
| `max_delay` | `5.0` (s) | Ceiling for backoff. |
| `retry_status_codes` | `frozenset({408, 429, 502, 503, 504})` | Status codes considered retryable. |
| `retry_methods` | `frozenset({"GET", "HEAD", "OPTIONS", "PUT", "DELETE"})` | Idempotent methods only by default. POST excluded; pass an explicit frozenset including `"POST"` to retry it. |
| `respect_retry_after` | `True` | When the response carries a `Retry-After` header on a retryable status, sleep for the header value (clamped to `max_delay`) instead of the jittered backoff. |
| `respect_retry_after` | `True` | When the response carries a `Retry-After` header on a retryable status, sleep for the header value instead of the jittered backoff. If the header value exceeds `max_delay`, Retry gives up and re-raises the underlying `StatusError` with a PEP 678 note `httpware: Retry-After (Ns) exceeded max_delay (Ms); giving up`. Set `max_delay` higher (or `respect_retry_after=False`) to opt out. |
| `budget` | `RetryBudget()` (default-configured) | The token bucket. Pass a shared `RetryBudget` instance to apply one budget across multiple clients — sync, async, or both. |

`Retry` uses `time.sleep` between attempts. `Retry-After`, streaming-body refusal, exhaustion behavior, and `RetryBudgetExhaustedError` semantics are identical to `AsyncRetry`.
Expand Down
Loading
Loading