feat(nix): drop into dev shell#339
Open
haarchri wants to merge 1 commit into
Open
Conversation
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
When running via nix.sh, the cluster lives inside the container's Docker daemon and would vanish when the container exits. Drop into a dev shell so the user can interact with it before exiting.
copies the behaviour we have in crossplane core https://github.com/crossplane/crossplane/blob/main/nix/apps.nix#L316-L321
Fixes #
I have:
nix flake check(or./nix.sh flake check) and made sure it passes.git commit -s.