Skip to content

select-group 페이지, 게스트 로그인 로직 제거#59

Open
yoouyeon wants to merge 2 commits into
developfrom
refactor/MD-43
Open

select-group 페이지, 게스트 로그인 로직 제거#59
yoouyeon wants to merge 2 commits into
developfrom
refactor/MD-43

Conversation

@yoouyeon
Copy link
Copy Markdown
Contributor

💻 작업 내용

정산하기 플로우 정책 변경에 따라 select-group 페이지를 제거하고, 기존 게스트 로그인 로직도 함께 삭제했습니다.

제거된 항목

  • src/pages/selectGroup/ 디렉토리 전체 삭제
  • 게스트 토큰 API (getGuestToken, GuestTokenData) 및 MSW 핸들러 삭제
  • LoginPage의 게스트 로그인 분기 로직 삭제

변경된 항목

  • 홈 화면 "정산하기" 버튼: /select-group → /group-setup 으로 직접 이동
  • createExpensePageGuardLoader: 유효하지 않은 groupToken일 때 /select-group → /group-setup 으로 리다이렉트
  • ROUTE 설정에서 selectGroup 키 제거

✅ 테스트 리스트 (선택)

📸 스크린샷

  • 홈 화면 "정산하기" 버튼 클릭 → /group-setup 이동 확인
  • /select-group 직접 접속 → 404 NotFound 확인
  • /create-expense/invalid-token 접속 → /group-setup 리다이렉트 확인
  • 카카오 로그인 버튼 정상 동작 확인

yoouyeon added 2 commits May 31, 2026 17:59
게스트 로그인 정책이 제거됨에 따라 남아있던 게스트 로그인 코드도 제거함
- 기존 모임 기능을 제거함에 따라 select-group 페이지
- 기존 select-group 페이지 진입점을 group-setup으로 변경
@yoouyeon yoouyeon added the ✨ Feature 신규 기능 추가 label May 31, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 31, 2026

Warning

Review limit reached

@yoouyeon, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 57 minutes and 30 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7092ae18-739c-4c60-839d-7112703a0670

📥 Commits

Reviewing files that changed from the base of the PR and between 344c4fa and 1a6bdc2.

📒 Files selected for processing (17)
  • src/app/Router.tsx
  • src/entities/auth/api/auth.ts
  • src/mocks/handlers/auth.ts
  • src/pages/CreateExpensePage/lib/createExpensePageGuardLoader.ts
  • src/pages/home/ui/HomePageSection/index.tsx
  • src/pages/login/LoginPage.tsx
  • src/pages/selectGroup/SelectGroupPage.styles.ts
  • src/pages/selectGroup/SelectGroupPage.tsx
  • src/pages/selectGroup/index.ts
  • src/pages/selectGroup/ui/CreateGroupLinkButton.styles.ts
  • src/pages/selectGroup/ui/CreateGroupLinkButton.tsx
  • src/pages/selectGroup/ui/EmptyBox.styles.ts
  • src/pages/selectGroup/ui/EmptyBox.tsx
  • src/pages/selectGroup/ui/GroupLinkButton.styles.ts
  • src/pages/selectGroup/ui/GroupLinkButton.tsx
  • src/pages/selectGroup/ui/index.ts
  • src/shared/config/route.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/MD-43

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 31, 2026

📝 관련 이슈

MD-43

@github-actions github-actions Bot requested a review from ongheong May 31, 2026 11:58
@yoouyeon yoouyeon added the RABBIT_REVIEW 사람의 리뷰는 생략하고 코드래빗의 리뷰만 해결한 뒤 머지하는 PR label May 31, 2026
Comment on lines +14 to +15
const redirectPathAfterLogin = searchParams.get('redirectTo') ?? undefined;
kakaoLogin(redirectPathAfterLogin);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

만약 redirectPathAfterLogin에 undefined가 들어가면 어떻게 되나요? 404페이지로 이동하게 될까요?

Copy link
Copy Markdown
Contributor Author

@yoouyeon yoouyeon May 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

홈으로 이동하게 됩니다!

redirectPathAfterLogin 함수 안에서는 getSafeRedirectPath 유틸함수로 URL을 전처리하는데요.

function kakaoLogin(redirectPathAfterLogin?: string) {
  const safePath = getSafeRedirectPath(redirectPathAfterLogin);
  // ...
}

getSafeRedirectPath 함수는 undefined 인자가 들어오는 경우 기본적으로 ROUTE.home 을 반환하도록 되어 있습니다!

function getSafeRedirectPath(
  path: string | null | undefined,
  fallback: string = ROUTE.home
): string {
  return path && isSafeSameOriginPath(path) ? path : fallback;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Feature 신규 기능 추가 RABBIT_REVIEW 사람의 리뷰는 생략하고 코드래빗의 리뷰만 해결한 뒤 머지하는 PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants