select-group 페이지, 게스트 로그인 로직 제거#59
Conversation
게스트 로그인 정책이 제거됨에 따라 남아있던 게스트 로그인 코드도 제거함
- 기존 모임 기능을 제거함에 따라 select-group 페이지 - 기존 select-group 페이지 진입점을 group-setup으로 변경
|
Warning Review limit reached
More reviews will be available in 57 minutes and 30 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (17)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📝 관련 이슈 |
| const redirectPathAfterLogin = searchParams.get('redirectTo') ?? undefined; | ||
| kakaoLogin(redirectPathAfterLogin); |
There was a problem hiding this comment.
만약 redirectPathAfterLogin에 undefined가 들어가면 어떻게 되나요? 404페이지로 이동하게 될까요?
There was a problem hiding this comment.
홈으로 이동하게 됩니다!
redirectPathAfterLogin 함수 안에서는 getSafeRedirectPath 유틸함수로 URL을 전처리하는데요.
function kakaoLogin(redirectPathAfterLogin?: string) {
const safePath = getSafeRedirectPath(redirectPathAfterLogin);
// ...
}getSafeRedirectPath 함수는 undefined 인자가 들어오는 경우 기본적으로 ROUTE.home 을 반환하도록 되어 있습니다!
function getSafeRedirectPath(
path: string | null | undefined,
fallback: string = ROUTE.home
): string {
return path && isSafeSameOriginPath(path) ? path : fallback;
}
💻 작업 내용
정산하기 플로우 정책 변경에 따라 select-group 페이지를 제거하고, 기존 게스트 로그인 로직도 함께 삭제했습니다.
제거된 항목
변경된 항목
✅ 테스트 리스트 (선택)
📸 스크린샷