Skip to content

(fix) : 토큰 만료 응답과 정산 응답 정보 수정#48

Merged
sudhdkso merged 1 commit into
developfrom
fix/member-count
May 10, 2026
Merged

(fix) : 토큰 만료 응답과 정산 응답 정보 수정#48
sudhdkso merged 1 commit into
developfrom
fix/member-count

Conversation

@sudhdkso
Copy link
Copy Markdown
Contributor

@sudhdkso sudhdkso commented May 10, 2026

#️⃣연관된 이슈

X

🔀반영 브랜치

fix/member-count -> develop

🔧변경 사항

  • 정산 헤더 응답에 createdAt, completedAt 필드를 추가했습니다.
  • 정산 헤더 조회 시 정산 생성일과 완료일을 함께 내려주도록 수정했습니다.
  • 관련 서비스/컨트롤러 테스트 데이터를 새 응답 스펙에 맞게 갱신했습니다.
  • 만료된 JWT가 들어온 경우 401토큰이 만료되었습니다. 메시지를 JSON으로 내려주도록 수정했습니다.
  • 정산 목록 조회에서 내 멤버 row와 전체 참여자 집계용 멤버 row를 분리해 totalMemberCount, 완료 인원 집계가 전체 정산 멤버 기준으로 계산되도록 수정했습니다.

💬리뷰 요구사항(선택)

X

✅체크

  • 테스트 코드 포함 여부: 포함
  • 불필요한 로그 제거: 해당 없음
  • 예외 처리 여부: 기존 흐름 유지

🧪검증

  • ./gradlew --no-daemon test --tests com.dnd.moddo.domain.settlement.service.implementation.SettlementReaderTest --tests com.dnd.moddo.domain.settlement.service.QuerySettlementServiceTest --tests com.dnd.moddo.domain.settlement.controller.SettlementControllerTest
  • ./gradlew --no-daemon test --tests com.dnd.moddo.domain.auth.service.JwtFilterTest --tests com.dnd.moddo.domain.settlement.controller.SettlementControllerTest

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9707b647-dd5e-48fd-add0-347819461a5f

📥 Commits

Reviewing files that changed from the base of the PR and between 62af661 and 6f7cd6d.

📒 Files selected for processing (5)
  • src/main/java/com/dnd/moddo/event/application/impl/SettlementReader.java
  • src/main/java/com/dnd/moddo/event/presentation/response/SettlementHeaderResponse.java
  • src/test/java/com/dnd/moddo/domain/settlement/controller/SettlementControllerTest.java
  • src/test/java/com/dnd/moddo/domain/settlement/service/QuerySettlementServiceTest.java
  • src/test/java/com/dnd/moddo/domain/settlement/service/implementation/SettlementReaderTest.java

Walkthrough

SettlementHeaderResponse 레코드가 createdAt과 completedAt 타임스탐프 필드를 추가하여 정산 생명주기 정보를 전달합니다. SettlementReader는 새로운 필드들을 응답에 명시적으로 포함하도록 업데이트되고, 모든 관련 테스트는 확장된 응답 구조로 조정됩니다.

Changes

Settlement Header Timestamp Extension

Layer / File(s) Summary
Data Contract
src/main/java/com/dnd/moddo/event/presentation/response/SettlementHeaderResponse.java
SettlementHeaderResponse 레코드에 LocalDateTime createdAtLocalDateTime completedAt 필드를 추가합니다. of(...) 팩토리 메서드 시그니처가 두 개의 새 타임스탐프 파라미터를 수용하도록 확장되며, 기존의 5-파라미터 형태는 제거됩니다.
Core Implementation
src/main/java/com/dnd/moddo/event/application/impl/SettlementReader.java
findByHeader 메서드가 SettlementHeaderResponse.of(...) 호출에 settlement.getAccountNumber(), settlement.getCreatedAt(), settlement.getCompletedAt()을 명시적으로 전달하도록 업데이트됩니다.
Test Updates
src/test/java/com/dnd/moddo/domain/settlement/controller/SettlementControllerTest.java, src/test/java/com/dnd/moddo/domain/settlement/service/QuerySettlementServiceTest.java, src/test/java/com/dnd/moddo/domain/settlement/service/implementation/SettlementReaderTest.java
SettlementControllerTest의 테스트 데이터가 LocalDateTime.now()null을 포함하도록 확장됩니다. QuerySettlementServiceTest의 예상 응답이 settlement의 createdAt()completedAt()을 포함합니다. SettlementReaderTest의 모의 객체가 고정된 타임스탐프 값을 반환하도록 설정되고, 응답이 일치하는 타임스탐프를 포함하는지 검증하는 새로운 어설션이 추가됩니다.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 정산 응답에 시간이 담겨,
생성부터 완료까지 흐른 길,
타임스탐프 두 개 추가되어,
생명주기 전체를 드러내네!
테스트들도 함께 춤을 춘다. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목은 '정산 헤더 응답 시간 정보 추가'로, 변경사항의 핵심인 createdAt과 completedAt 필드 추가를 명확하게 설명합니다.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/member-count

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sudhdkso sudhdkso marked this pull request as ready for review May 10, 2026 03:35
@github-actions
Copy link
Copy Markdown

📝 테스트 커버리지 리포트입니다!

File Coverage [100%] 🍏
SettlementReader.java 100% 🍏
Total Project Coverage 70.45%

@sudhdkso sudhdkso merged commit 3f4bd3a into develop May 10, 2026
3 checks passed
@sudhdkso sudhdkso changed the title (feature) : 정산 헤더 응답 시간 정보 추가 (fix) : 토큰 만료 응답과 정산 응답 정보 수정 May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant