Skip to content

test: moved tests from mocha to playwright#49

Merged
gmegidish merged 6 commits into
mainfrom
migrate-tests-to-playwright
Jun 14, 2026
Merged

test: moved tests from mocha to playwright#49
gmegidish merged 6 commits into
mainfrom
migrate-tests-to-playwright

Conversation

@gmegidish

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

The pull request migrates the test suite from Mocha/CommonJS to Playwright/TypeScript. tests/package.json swaps mocha for @playwright/test and typescript; a new tests/tsconfig.json and tests/playwright.config.ts configure the TypeScript compiler and Playwright runner. A new tests/global-setup.ts handles simulator discovery via xcrun simctl, launches the XCUITest runner bundle with the JSON-RPC listen port injected, and polls /health before tests start. tests/rpc.test.js is removed and replaced by tests/rpc.test.ts; tests/mjpeg.test.ts is converted from Mocha to Playwright. scripts/test-coverage.sh is rewritten to build an instrumented runner via xcodebuild build-for-testing, install it on the simulator, run Playwright tests with coverage env vars, and merge .profraw files via llvm-profdata. The Makefile coverage-html target switches from find-based profdata discovery to a fixed path.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the rationale for switching to Playwright and any notable impacts.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: migrating the test suite from Mocha to Playwright.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch migrate-tests-to-playwright

Comment @coderabbitai help to get the list of available commands and usage tips.

@gmegidish gmegidish merged commit 2c57d03 into main Jun 14, 2026
4 of 5 checks passed
@gmegidish gmegidish deleted the migrate-tests-to-playwright branch June 14, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant