You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The pull request migrates the test suite from Mocha/CommonJS to Playwright/TypeScript. tests/package.json swaps mocha for @playwright/test and typescript; a new tests/tsconfig.json and tests/playwright.config.ts configure the TypeScript compiler and Playwright runner. A new tests/global-setup.ts handles simulator discovery via xcrun simctl, launches the XCUITest runner bundle with the JSON-RPC listen port injected, and polls /health before tests start. tests/rpc.test.js is removed and replaced by tests/rpc.test.ts; tests/mjpeg.test.ts is converted from Mocha to Playwright. scripts/test-coverage.sh is rewritten to build an instrumented runner via xcodebuild build-for-testing, install it on the simulator, run Playwright tests with coverage env vars, and merge .profraw files via llvm-profdata. The Makefilecoverage-html target switches from find-based profdata discovery to a fixed path.
🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name
Status
Explanation
Resolution
Docstring Coverage
⚠️ Warning
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check
❓ Inconclusive
No description was provided by the author, making it impossible to assess relevance to the changeset.
Add a pull request description explaining the rationale for switching to Playwright and any notable impacts.
✅ Passed checks (3 passed)
Check name
Status
Explanation
Title check
✅ Passed
The title accurately and specifically describes the main change: migrating the test suite from Mocha to Playwright.
Linked Issues check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
✅ Passed
Check skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches🧪 Generate unit tests (beta)
Create PR with unit tests
Commit unit tests in branch migrate-tests-to-playwright
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.