docs: update README installation steps#44
Conversation
WalkthroughThe README documentation has been updated in two areas. The "Building from Source" section now includes explicit instructions to install the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 83-86: The description for the device.screenshot example is
inconsistent: the JSON-RPC call sets "format": "jpg" but the text says it
returns a PNG; update the README so they match by either changing the params in
the example (the JSON string for method "device.screenshot" and params "format")
to "png" or change the descriptive sentence to state it returns a base64-encoded
JPEG; ensure references to "device.screenshot" and the "format" param are
updated accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| curl -X POST http://127.0.0.1:12004/rpc \ | ||
| -H "Content-Type: application/json" \ | ||
| -d '{"jsonrpc":"2.0","method":"device.screenshot","params":{},"id":1}' | ||
| -d '{"jsonrpc":"2.0","method":"device.screenshot","params":{ "format": "png" },"id":1}' |
There was a problem hiding this comment.
found that current implementation of device.screenshot (here) set format as mandatory parameters.
|
@Rezisn I cannot merge unless you sign your commits. Can you do that please? |
Submodules have been removed, moved to another repo
03bf48e to
676d722
Compare
|
@gmegidish i rewrote the commits to have the signed version, thanks |
Summary
xcbeautifyas a required dependency for building devicekit-ios.device.screenshot.