ci: replace JDK17 pipeline with mno-adapters-style CI + release-please (start 5.0.0)#7
Merged
Merged
Conversation
…e (start 5.0.0) - ci-cd.yml: build/test/sast on maven:3-eclipse-temurin-25 (was JDK 17, which could not compile maven.compiler.release=25) and push the dev image mobiera/<repo>:main to Docker Hub on main; configure MVN_SETTINGS in the test/sast jobs so private deps resolve - release-please.yml + release-please-config.json + .release-please-manifest.json: release-type maven, baseline 5.0.0; release-build pushes mobiera/<repo>:<version> - pr-title-lint.yml: conventional-commit PR titles - pom <version> set to 5.0.0; remove old ci.yml (github-tag-action)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The previous
ci.ymlset up JDK 17, which cannot compilemaven.compiler.release=25(now onmainafter #6) — that's why the repo no longer built on GitHub. It also usedgithub-tag-action(which auto-taggedv1.0.5on the #6 merge), not release-please.What
Replaces it with the same pipeline the
mno-adapters-*repos use, targeting Docker Hub (per current image configmobiera/service-log):.github/workflows/ci-cd.yml(replacesci.yml) —build/test/sastonmaven:3-eclipse-temurin-25; onmainbuilds & pushesmobiera/service-log:mainto Docker Hub (DOCKER_HUB_LOGIN/DOCKER_HUB_PWD).MVN_SETTINGSconfigured in every Maven job (incl. test/sast) so private deps resolve..github/workflows/release-please.yml—googleapis/release-please-action@v4; on release, builds from the tag (JDK 25) and pushesmobiera/service-log:<version>..github/workflows/pr-title-lint.yml— conventional-commit PR titles.release-please-config.json—release-type: maven,package-name: service-log,skip-snapshot: true..release-please-manifest.json— baseline5.0.0; pom<version>→5.0.0(was1.1-SNAPSHOT).Notes
MVN_SETTINGS,DOCKER_HUB_LOGIN,DOCKER_HUB_PWD.v5.0.0, land a commit onmainwith aRelease-As: 5.0.0footer; otherwise the first release-please PR bumps from the5.0.0baseline per conventional commits.