Fix UnicodeDecodeError on Windows by specifying utf-8 encoding#30
Open
ace-xc wants to merge 1 commit into
Open
Fix UnicodeDecodeError on Windows by specifying utf-8 encoding#30ace-xc wants to merge 1 commit into
ace-xc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows systems (where the default encoding is often GBK or CP1252), installing this package fails with a UnicodeDecodeError because
setup.pyattempts to readREADME.rstandVERSIONwithout specifying an encoding. Python then uses the system default encoding, which cannot decode the UTF-8 characters in those files.Error Message:
Solution
I explicitly added encoding='utf-8' to the open() calls in
setup.py. This ensures that the files are correctly read as UTF-8 regardless of the operating system's default encoding settings.Verification
Verified that
pip install .works correctly on Windows after this change.