Support more multi-line responses and additional binary data responses#24
Open
mnightingale wants to merge 1 commit into
Open
Support more multi-line responses and additional binary data responses#24mnightingale wants to merge 1 commit into
mnightingale wants to merge 1 commit into
Conversation
…nal status codes to regard as binary data
|
Honestly, I only use your decoder function with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary motivation is because currently the yEnc metadata checks were only performed for article/body responses, I wasn’t aware of the XZVER/XZHDR usage.
I haven't added support for the
[COMPRESS=GZIP]responses; maybe in the future if anyone requests it but they are quite annoying if the.\r\nmust be decompressed. I did see there isxfeature compress gzipbut I couldn’t seem to get it to work as I expected and it’s difficult to find any information about it. So only Astraweb style for now.@Tensai75 could you try this out?