Create Timezone Converter page#99
Conversation
inssein
left a comment
There was a problem hiding this comment.
Thanks for sending over the contribution. A few things from my end:
- I will fix the bundle size action not working, currently worked on at https://github.com/mnara-solutions/utiliti.dev/actions/runs/21845921563/job/63041611225
moment-timezoneis a huge library, adding about 800kb to the page. I think you can get a lot of the same functionality by either usingIntl.DateTimeFormat, or potentially some features ofdate-fns, which is already a dependency.- Typo in PR title
- I think the UI could use some improvements.
- Do we need a convert button? I think you could do without it, but if you think we need it, have it follow the same style as the rest of the app.
- Could we use a smart dropdown that allows search? We may have an example already, but at the very least, let's use the component
<Dropdown /> - Might be worth looking at UI's of other timezone converters to see if we can innovate here.
Bundle Size Report
|
|
@shabbiryusufali I fixed the bundle size reporter and made it more useful, so it shows you a diff against main. Pull the latest changes before continuing working. |
Just crossing out completed suggestions/tasks to keep a track of this |
|
@inssein I finally got around to making a searchable dropdown. Let me know what you think. I also addressed all the other comments in a previous commit |
This PR finishes the plan from Issue #20