Bugfix and small feature - #3
Open
jhit wants to merge 6 commits into
Open
Conversation
Signed-off-by: Jürgen Hörmann <juergen@sfxonline.de>
This causes a fatal error in the assignment with $i. I suppose when shopping worlds get removed from $emotions the array is not re-indexed. Maybe this happens when shopping worlds get deactivated. I did not investigate this more deeply, just fixed the code.
Signed-off-by: Jürgen Hörmann <juergen@sfxonline.de>
Signed-off-by: Jürgen Hörmann <juergen@sfxonline.de>
Signed-off-by: Jürgen Hörmann <juergen@sfxonline.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem with the iteration over $emotions when the array has missing indexes. I cannot say why this is happening, but it was an issue in one of our stores.
Additionally, I added a feature that you can set custom CSS classes for shopping worlds to make custom styling possible.