fix: properly seed DataLoader workers for reproducibility - #716
Open
GiGiKoneti wants to merge 3 commits into
Open
fix: properly seed DataLoader workers for reproducibility#716GiGiKoneti wants to merge 3 commits into
GiGiKoneti wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR addresses the
DataLoaderworker seeding part of #265 (and #267). As suggested by the maintainers in #267, PyTorch Lightning natively handles proper DataLoaders worker seeding (worker_init_fn) automatically if we simply passworkers=Truetoseed_everything.neural_lam/train_model.pyto useseed.seed_everything(args.seed, workers=True). This resolves the issue where multiple workers could end up with correlated random states.(Note: The
CUBLAS_WORKSPACE_CONFIGenvironment variable from the original issue is omitted from this PR, adhering to the maintainer's decision in #267 that imposing environment variables for maximum determinism falls outside the scope of neural-lam and is better left to user execution scripts.)Issue Link
Resolves #265
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee