Skip to content

fix: properly seed DataLoader workers for reproducibility - #716

Open
GiGiKoneti wants to merge 3 commits into
mllam:mainfrom
GiGiKoneti:fix/issue-265-dataloader-seeding
Open

fix: properly seed DataLoader workers for reproducibility#716
GiGiKoneti wants to merge 3 commits into
mllam:mainfrom
GiGiKoneti:fix/issue-265-dataloader-seeding

Conversation

@GiGiKoneti

Copy link
Copy Markdown
Contributor

Describe your changes

This PR addresses the DataLoader worker seeding part of #265 (and #267). As suggested by the maintainers in #267, PyTorch Lightning natively handles proper DataLoaders worker seeding (worker_init_fn) automatically if we simply pass workers=True to seed_everything.

  • Modified neural_lam/train_model.py to use seed.seed_everything(args.seed, workers=True). This resolves the issue where multiple workers could end up with correlated random states.

(Note: The CUBLAS_WORKSPACE_CONFIG environment variable from the original issue is omitted from this PR, adhering to the maintainer's decision in #267 that imposing environment variables for maximum determinism falls outside the scope of neural-lam and is better left to user execution scripts.)

Issue Link

Resolves #265

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the README to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form (context).
  • I have requested a reviewer and an assignee (assignee is responsible for merging). This applies only if you have write access to the repo, otherwise feel free to tag a maintainer to add a reviewer and assignee.

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section
    reflecting type of change (add section where missing):
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug
    • maintenance: when your contribution is relates to repo maintenance, e.g. CI/CD or documentation

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • (if the PR is not just maintenance/bugfix) the PR is assigned to the next milestone. If it is not, propose it for a future milestone.
  • author has added an entry to the changelog (and designated the change as added, changed, fixed or maintenance)
  • Once the PR is ready to be merged, squash commits and merge the PR.

@sadamov
sadamov self-requested a review August 10, 2026 07:08
@sadamov sadamov self-assigned this Aug 10, 2026
@sadamov sadamov added the bug Something isn't working label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complete deterministic training by adding CUBLAS workspace config and DataLoader worker seeding

2 participants