Skip to content

feat: rename spread_squared to ensemble_spread, use std instead of var - #692

Closed
Kirwa-web wants to merge 2 commits into
mllam:mainfrom
Kirwa-web:feat/ensemble-spread-metric-v3
Closed

feat: rename spread_squared to ensemble_spread, use std instead of var#692
Kirwa-web wants to merge 2 commits into
mllam:mainfrom
Kirwa-web:feat/ensemble-spread-metric-v3

Conversation

@Kirwa-web

Copy link
Copy Markdown
Contributor

Describe your changes

Renames the spread_squared metric to ensemble_spread and changes the
computation from variance (torch.var) to standard deviation (torch.std),
making the metric name and behaviour consistent with how ensemble spread is
conventionally reported.

Issue Link

Closes #62

Type of change

  • ✨ New feature (non-breaking change that adds functionality)

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the README to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form (context).
  • I have requested a reviewer and an assignee (assignee is responsible for merging). This applies only if you have write access to the repo, otherwise feel free to tag a maintainer to add a reviewer and assignee.

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section
    reflecting type of change (add section where missing):
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug
    • maintenance: when your contribution is relates to repo maintenance, e.g. CI/CD or documentation

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • (if the PR is not just maintenance/bugfix) the PR is assigned to the next milestone. If it is not, propose it for a future milestone.
  • author has added an entry to the changelog (and designated the change as added, changed, fixed or maintenance)
  • Once the PR is ready to be merged, squash commits and merge the PR.

@Sir-Sloth-The-Lazy

Copy link
Copy Markdown
Contributor

we have an open PR on this , It would be a duplicate work if you work on this seperately, kind of a waste for your efforts. Please check PR #226

@sadamov sadamov added the duplicate This issue or pull request already exists label Jun 29, 2026
@sadamov

sadamov commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

yeah the overlap here is clear, we also recently consolidated efforts on the prob. piping: #649 would be great to get your input directly in #226 @Kirwa-web

@sadamov sadamov closed this Jun 29, 2026
@Kirwa-web

Copy link
Copy Markdown
Contributor Author

Good catch..from outside it's hard to see all the in-flight branches. I'll read through #226 and #649 before touching this area again, rather than add another parallel effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge Graph-EFM model from prob_model_lam branch

3 participants