Add PersistencePredictor baseline model - #677
Open
GiGiKoneti wants to merge 11 commits into
Open
Conversation
sadamov
reviewed
Jun 22, 2026
Collaborator
There was a problem hiding this comment.
Thanks @GiGiKoneti, this is clean and well-scoped. I ran it locally: the 5 tests pass, pre-commit is clean, and --eval test --model persistence runs end-to-end with the loss growing by lead time...
A few small asks inline, none of them block the logic.
- the training guard in
train_model.pycompares against the literal"persistence". Fine for a single baseline, though atrainable = Falseclass attribute would be more robust if more analytical baselines arrive later. --output_stdis silently ignored with persistence (documented, harmless). Alogger.warningwould make the no-op explicit.- README is still unchecked in the PR checklist. A one-liner noting
--model persistenceneeds--eval val/testwould help discoverability.
Contributor
Author
|
Collaborator
|
Looking very good, I added some ideas above that could be small improvements :) |
sadamov
reviewed
Jun 29, 2026
sadamov
left a comment
Collaborator
There was a problem hiding this comment.
Clean and correct, already approved. A few small polish asks inline, none block the logic.
Contributor
Author
|
Done!
|
sadamov
self-requested a review
June 30, 2026 07:32
sadamov
approved these changes
Jun 30, 2026
…lve conflict in test_train_model_warnings.py
…oneti/neural-lam into feat/persistence-predictor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
PersistencePredictor, a baselineStepPredictormodel that returns the previous state unchanged at each autoregressive step.PersistencePredictoraspersistencein theMODELSregistry insideneural_lam/models/__init__.py.neural_lam/train_model.pyto prevent training the persistence model, raising a ValueError if training is attempted.No changes to any existing prediction pathways.
None.
Issue Link
closes #676
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee