Skip to content

more verbose coverage linting errors - #659

Open
leifdenby wants to merge 1 commit into
mllam:mainfrom
leifdenby:maint/more-verbose-coverage-output
Open

more verbose coverage linting errors#659
leifdenby wants to merge 1 commit into
mllam:mainfrom
leifdenby:maint/more-verbose-coverage-output

Conversation

@leifdenby

@leifdenby leifdenby commented Jun 15, 2026

Copy link
Copy Markdown
Member

Describe your changes

I was working on #323 and found that one of the functions I am introducing didn't have complete docstring coverage. With #252 we now use interogate to ensure that we have 100% coverage through a the pre-commit hook (which is great!) however, the current output you get when running uv run pre-commit doesn't actually tell you what functions/modules to fix (only the offending files):

Screenshot 2026-06-15 at 14 05 57

My suggestion with this PR is to include the include module and function name from "interogate" pre-commit linting tool for functions/modules that are missing docstrings, like so:

Screenshot 2026-06-15 at 14 10 48

No change to deps required

Maybe @Mohit-Lakra or @sadamov you have thoughts on this?

Issue Link

#252

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the README to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form (context).
  • I have requested a reviewer and an assignee (assignee is responsible for merging). This applies only if you have write access to the repo, otherwise feel free to tag a maintainer to add a reviewer and assignee.

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section
    reflecting type of change (add section where missing):
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug
    • maintenance: when your contribution is relates to repo maintenance, e.g. CI/CD or documentation

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • (if the PR is not just maintenance/bugfix) the PR is assigned to the next milestone. If it is not, propose it for a future milestone.
  • author has added an entry to the changelog (and designated the change as added, changed, fixed or maintenance)
  • Once the PR is ready to be merged, squash commits and merge the PR.

include module and function name from "interogate" pre-commit linting tool for functions/modules that are missing docstrings
@Mohit-Lakra

Mohit-Lakra commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@leifdenby, I support this idea. I faced the same issue while adding docstrings. Whenever pre-commit failed because of interrogate, I usually had to run interrogate --verbose afterwards to identify the files or functions causing the failure.
Showing that information directly in the pre-commit output would make debugging much easier and improve the developer experience.
😁😁

@sadamov
sadamov self-requested a review June 16, 2026 03:04
@sadamov sadamov added the maintenance Refactoring codebase, no new behaviour label Jun 16, 2026

@sadamov sadamov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leifdenby leifdenby added this to the v0.7.0 (proposed) milestone Jun 24, 2026
@observingClouds observingClouds added the ready Review complete - proposed for milestone label Jul 6, 2026
@leifdenby leifdenby modified the milestones: v0.7.0 (proposed), v0.7.0 Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Refactoring codebase, no new behaviour ready Review complete - proposed for milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants