more verbose coverage linting errors - #659
Open
leifdenby wants to merge 1 commit into
Open
Conversation
include module and function name from "interogate" pre-commit linting tool for functions/modules that are missing docstrings
Contributor
|
@leifdenby, I support this idea. I faced the same issue while adding docstrings. Whenever |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
I was working on #323 and found that one of the functions I am introducing didn't have complete docstring coverage. With #252 we now use
interogateto ensure that we have 100% coverage through a the pre-commit hook (which is great!) however, the current output you get when runninguv run pre-commitdoesn't actually tell you what functions/modules to fix (only the offending files):My suggestion with this PR is to include the include module and function name from "interogate" pre-commit linting tool for functions/modules that are missing docstrings, like so:
No change to deps required
Maybe @Mohit-Lakra or @sadamov you have thoughts on this?
Issue Link
#252
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee