Skip to content

Solving Issues#61 - #517

Closed
sumit08kumar wants to merge 5 commits into
mllam:mainfrom
sumit08kumar:main
Closed

Solving Issues#61#517
sumit08kumar wants to merge 5 commits into
mllam:mainfrom
sumit08kumar:main

Conversation

@sumit08kumar

Copy link
Copy Markdown

Describe your changes

This PR implements the foundational Sphinx documentation system for neural-lam, as requested in Issue #61.

Key Changes:

  • Sphinx Configuration: Set up docs/conf.py with 8 extensions (autodoc, napoleon, intersphinx, myst-parser, etc.) and sphinx-book-theme.
  • API Reference: Created .rst stubs for 8 core modules to auto-generate documentation from Python docstrings.
  • User Guide Migration: Transformed the monolithic README into a structured navigation tree (getting_started.md, user_guide/data.md, user_guide/graphs.md, training.md, evaluation.md, contributing.md).
  • CI/CD Pipeline: Added .github/workflows/docs.yml to validate documentation on every PR (warnings become errors).
  • RTD Deployment: Configured .readthedocs.yaml with CPU-only PyTorch for automated staging and production deployment.

Motivation and Context:
Currently, code documentation is buried in docstrings and the README has grown too large to navigate easily. This PR provides a searchable, versioned, and hyperlinked documentation website similar to PyTorch Geometric, making the project more accessible to researchers.

Dependencies:
Added docs dependency group to pyproject.toml including:
sphinx, sphinx-book-theme, myst-parser, sphinx-autodoc-typehints, sphinx-copybutton.

Issue Link

Closes #61

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the README to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form (context).
  • I have requested a reviewer and an assignee (assignee is responsible for merging). This applies only if you have write access to the repo, otherwise feel free to tag a maintainer to add a reviewer and assignee.

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain
  • the build passes without warnings

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section
    reflecting type of change (add section where missing):
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug
    • maintenance: when your contribution is relates to repo maintenance, e.g. CI/CD or documentation
      maintenance: implemented Sphinx documentation system with RTD and CI/CD validation

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • (if the PR is not just maintenance/bugfix) the PR is assigned to the next milestone. If it is not, propose it for a future milestone.
  • author has added an entry to the changelog (and designated the change as added, changed, fixed or maintenance)
  • Once the PR is ready to be merged, squash commits and merge the PR.

@kshirajahere

kshirajahere commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

@sumit08kumar hey thanks but i think you can work directly in #252 #272, you had made the same PR previously and it was closed because there is already an existing PR that solves issue #61. It makes the job easier for the org maintainers if everything is streamlined :)

@sumit08kumar

Copy link
Copy Markdown
Author

@sumit08kumar hey thanks but i think you can work directly in #252 #272, you had made the same PR previously and it was closed because there is already an existing PR that solves issue #61. It makes the job easier for the org maintainers if everything is streamlined :)

I have tried to work directly into the PRs but it is not working as I need permission or I need to locally to that

@Mohit-Lakra

Copy link
Copy Markdown
Contributor

I have tried to work directly into the PRs but it is not working as I need permission or I need to locally to that

you can raise a PR against my branch
This is the best way to work, as many people are working on these PRs So if everyone is given access then it will be a critical situation
whereas PRs are easy to maintain

@sumit08kumar

Copy link
Copy Markdown
Author

I have tried to work directly into the PRs but it is not working as I need permission or I need to locally to that

you can raise a PR against my branch
This is the best way to work, as many people are working on these PRs So if everyone is given access then it will be a critical situation
whereas PRs are easy to maintain

I understand that. Can tell me how can I do that @Mohit-Lakra

@Mohit-Lakra

Copy link
Copy Markdown
Contributor

I understand that. Can tell me how can I do that @Mohit-Lakra

Go to my repo, fork the repo
use the branch i used to raise PR
add changes
commit it
and then create a PR
😄

@sumit08kumar

Copy link
Copy Markdown
Author

I understand that. Can tell me how can I do that @Mohit-Lakra

Go to my repo, fork the repo
use the branch i used to raise PR
add changes
commit it
and then create a PR
😄

I have tried this but the issues is that it doesn't allow me to then create the pr.
Thanks @Mohit-Lakra
I will try again...

@Mohit-Lakra

Mohit-Lakra commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

git remote add contributor <my_repo>
Try to use this command and try to take some stack overflow help

@sadamov

sadamov commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

I am closing this since the author is working directly with @Mohit-Lakra now. Also the title is rather cryptic 🤨

@sadamov sadamov closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Structured documentation for Neural-LAM

4 participants